Commit Graph

1888 Commits

Author SHA1 Message Date
Stephan Schroevers
de8870781d Upgrade Guava 23.5-jre -> 23.6-jre
See https://github.com/google/guava/releases/tag/v23.6
2018-04-28 13:23:26 +02:00
Stephan Schroevers
06c4a4da03 Rename com.picnicinternational -> systems.picnic 2018-04-28 13:23:26 +02:00
Stephan Schroevers
2c515874ea Use Optional in PrimitiveComparisonCheck like elsewhere 2018-04-28 13:23:26 +02:00
Stephan Schroevers
3f79a928e1 Enable null analysis 2018-04-28 13:23:26 +02:00
Stephan Schroevers
e680a00c1d Introduce a README.md 2018-04-28 13:23:26 +02:00
Stephan Schroevers
26b149cde8 Compile with (most off) -Xdoclint 2018-04-28 13:23:26 +02:00
Stephan Schroevers
a40e7c314b Introduce -Dverification.warn 2018-04-28 13:23:26 +02:00
Stephan Schroevers
b7a35cc0e7 Upgrade Checkstyle 8.5 -> 8.7
See http://checkstyle.sourceforge.net/releasenotes.html
2018-04-28 13:23:26 +02:00
Stephan Schroevers
cc1db9d3a4 Use another formatter so that imports are also sorted 2018-04-28 13:23:26 +02:00
Stephan Schroevers
461754df83 Document Slf4jLogStatementCheck caveat 2018-04-28 13:23:26 +02:00
Stephan Schroevers
b7aaa6f5e7 Introduce Slf4jLogStatementCheck 2018-04-28 13:23:26 +02:00
Stephan Schroevers
db7ffddeed Just always use TEXT_MATCH to test replacements 2018-04-28 13:23:26 +02:00
Stephan Schroevers
47bfe88d66 Update tags 2018-04-28 13:23:26 +02:00
Stephan Schroevers
f43831fba1 Upgrade PITest 1.3.0 -> 1.3.1
See:
- https://github.com/hcoles/pitest/releases/tag/pitest-parent-1.3.1
- https://github.com/hcoles/pitest/compare/pitest-parent-1.3.0...pitest-parent-1.3.1
2018-04-28 13:23:26 +02:00
Stephan Schroevers
dadb21e506 Introduce MethodReferenceUsageCheck 2018-04-28 13:23:26 +02:00
Stephan Schroevers
e0fb686bf0 Upgrade PITest 1.2.5 -> 1.3.0
See https://github.com/hcoles/pitest/releases/tag/pitest-parent-1.3.0
2018-04-28 13:23:26 +02:00
Stephan Schroevers
b60da3e761 Fix build by allowing junit:junit:jar:4.13-SNAPSHOT to be retrieved
While there, make sure PITest writes reports to a stable directory.
2018-04-28 13:23:26 +02:00
Stephan Schroevers
14261514f3 Add Objects#toString support to RedundantStringConversionCheck 2018-04-28 13:23:26 +02:00
Stephan Schroevers
786d843956 Some tweaks 2018-04-28 13:23:26 +02:00
Stephan Schroevers
9b3f6c07fa Add package-info.java 2018-04-28 13:23:26 +02:00
Stephan Schroevers
c16ba79921 Introduce but disable the Guava Beta Checker 2018-04-28 13:23:26 +02:00
Stephan Schroevers
ee4c6faef2 POM cleanup and updates
Note that Guava was previously already upgraded past the version depended on by
Error Prone itself. Ideally we downgrade to version 22.0, but then
`RequireUpperBoundDeps` complains about the "newer" version 22.0-android being
pulled in. We'll fix this next time Error Prone upgrades Guava.
2018-04-28 13:23:26 +02:00
Stephan Schroevers
9951b4327f Fix bugs and increase test coverage based on mutation testing findings 2018-04-28 13:23:26 +02:00
Stephan Schroevers
d88f00161a Add support for mutation testing 2018-04-28 13:23:26 +02:00
Stephan Schroevers
36df438792 Introduce RedundantStringConversionCheck 2018-04-28 13:23:26 +02:00
Stephan Schroevers
2a18b42a31 Drop obsolete flags (-XepAllDisabledChecksAsWarnings handles this) 2018-04-28 13:23:26 +02:00
Stephan Schroevers
e5cf0d1737 Upgrade Error Prone, apply some tweaks 2018-04-28 13:23:26 +02:00
Stephan Schroevers
092d5bb17b Rename PrimitiveComparisonCheck, retain more of the original code 2018-04-28 13:23:26 +02:00
Stephan Schroevers
2762773b08 Introduce AutowiredConstructor, removing redundant @Autowired annotations 2018-04-28 13:23:26 +02:00
Stephan Schroevers
9bb4871dd1 Reduce formatting side-effects in CanonicalAnnotationSyntax suggested fixes 2018-04-28 13:23:26 +02:00
Stephan Schroevers
3736f7d174 Introduce SpringMvcAnnotationCheck
While there: drop the unused `googleformatter-maven-plugin` fork.
2018-04-28 13:23:26 +02:00
Stephan Schroevers
f8a3b64167 Extract some annotation argument selection logic
So that it can be reused.
2018-04-28 13:23:26 +02:00
Stephan Schroevers
be5c149a66 Support dropping trailing commas from annotation arrays 2018-04-28 13:23:26 +02:00
Stephan Schroevers
151783e63f Support in/exclusions for LexicographicalAnnotationAttributeListingCheck
While there:
- Also enable more compiler checks.
- Add and apply the Google Java formatter. (Yeah, this should have been a
  separate commit...
2018-04-28 13:23:26 +02:00
Stephan Schroevers
f2b393e72d Introduce lexicographic annotation sorting 2018-04-28 13:23:26 +02:00
Stephan Schroevers
dc7ef5deca Also drop redundant curlies 2018-04-28 13:23:26 +02:00
Stephan Schroevers
66ebebbe35 Introduce a CanonicalAnnotationSyntax check
While there, clean up some existing code.
2018-04-28 13:23:26 +02:00
Stephan Schroevers
1f8fe5ff94 Initial commit for error-prone-contrib
- The `pom.xml` needs to be cleaned up a lot. Ideally we split off parts of the
  PRP parent pom so that it can be reused.
- Code style: maybe we should more closely follow the error-prone project by
  also using two-space indentation. This project could be an incubator for
  plugins contributed to EP. (It is for this reason also that I used Auto
  Service and JUnit.)
2018-04-28 13:23:26 +02:00