jlengrand/error-prone-support
1
0
Fork 0
mirror of https://github.com/jlengrand/error-prone-support.git synced 2026-03-10 08:11:25 +00:00
Code Issues Packages Projects Releases Wiki Activity

Document Slf4jLogStatementCheck caveat

Browse Source
This commit is contained in:
Stephan Schroevers
2017-12-31 16:07:06 +01:00
parent b7aaa6f5e7
commit 461754df83
1 changed files with 2 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
error-prone-contrib/src/main/java/com/picnicinternational/errorprone/bugpatterns/Slf4jLogStatementCheck.java
View File

@@ -26,6 +26,8 @@ import java.util.List;
import java.util.Optional;
import java.util.regex.Pattern;
// XXX: The special-casing of Throwable applies only to SLF4J 1.6.0+; see https://www.slf4j.org/faq.html#paramException.
// That should be documented.
// XXX: Also simplify `LOG.error(String.format("Something %s", arg), throwable)`.
// XXX: Write a similar checker for Spring RestTemplates, String.format and friends, Guava
// preconditions, ...