Update tags

error-prone-contrib/src/main/java/com/picnicinternational/errorprone/bugpatterns/AutowiredConstructorCheck.java

@@ -26,7 +26,7 @@ import com.sun.tools.javac.code.Symbol.MethodSymbol;
   summary = "Omit `@Autowired` on a class' sole constuctor, as it is redundant",
   linkType = LinkType.NONE,
   severity = SeverityLevel.SUGGESTION,
-  tags = StandardTags.STYLE,
+  tags = StandardTags.SIMPLIFICATION,
   providesFix = ProvidesFix.REQUIRES_HUMAN_ATTENTION
 )
 public final class AutowiredConstructorCheck extends BugChecker implements AnnotationTreeMatcher {

error-prone-contrib/src/main/java/com/picnicinternational/errorprone/bugpatterns/CanonicalAnnotationSyntaxCheck.java

@@ -32,7 +32,7 @@ import java.util.regex.Pattern;
   summary = "Omit redundant syntax from annotation declarations",
   linkType = LinkType.NONE,
   severity = SeverityLevel.SUGGESTION,
-  tags = StandardTags.STYLE,
+  tags = StandardTags.SIMPLIFICATION,
   providesFix = ProvidesFix.REQUIRES_HUMAN_ATTENTION
 )
 public final class CanonicalAnnotationSyntaxCheck extends BugChecker

error-prone-contrib/src/main/java/com/picnicinternational/errorprone/bugpatterns/PrimitiveComparisonCheck.java

@@ -47,7 +47,7 @@ import javax.annotation.CheckForNull;
           + " of the provided function",
   linkType = LinkType.NONE,
   severity = SeverityLevel.WARNING,
-  tags = StandardTags.LIKELY_ERROR,
+  tags = StandardTags.PERFORMANCE,
   providesFix = ProvidesFix.REQUIRES_HUMAN_ATTENTION
 )
 public final class PrimitiveComparisonCheck extends BugChecker

error-prone-contrib/src/main/java/com/picnicinternational/errorprone/bugpatterns/RedundantStringConversionCheck.java

@@ -49,7 +49,7 @@ import java.util.regex.Pattern;
   summary = "Avoid redundant string conversions when possible",
   linkType = LinkType.NONE,
   severity = SeverityLevel.SUGGESTION,
-  tags = StandardTags.STYLE,
+  tags = StandardTags.SIMPLIFICATION,
   providesFix = ProvidesFix.REQUIRES_HUMAN_ATTENTION
 )
 public final class RedundantStringConversionCheck extends BugChecker

error-prone-contrib/src/main/java/com/picnicinternational/errorprone/bugpatterns/SpringMvcAnnotationCheck.java

@@ -33,7 +33,7 @@ import java.util.Optional;
       "Prefer the conciseness of `@{Get,Put,Post,Delete,Patch}Mapping` over `@RequestMapping`",
   linkType = LinkType.NONE,
   severity = SeverityLevel.SUGGESTION,
-  tags = StandardTags.STYLE,
+  tags = StandardTags.SIMPLIFICATION,
   providesFix = ProvidesFix.REQUIRES_HUMAN_ATTENTION
 )
 public final class SpringMvcAnnotationCheck extends BugChecker implements AnnotationTreeMatcher {

error-prone-contrib/src/test/java/com/picnicinternational/errorprone/bugpatterns/RedundantStringConversionCheckTest.java

@@ -353,6 +353,7 @@ public final class RedundantStringConversionCheckTest {
             "",
             "class A {",
             "  private static final Logger LOG = LoggerFactory.getLogger(A.class);",
+            "",
             "  private final Marker marker = MarkerFactory.getMarker(A.class.getName());",
             "  private final Formattable f = (formatter, flags, width, precision) -> {};",
             "  private final Object o = new Object();",