jlengrand/error-prone-support
1
0
Fork 0
mirror of https://github.com/jlengrand/error-prone-support.git synced 2026-03-10 08:11:25 +00:00
Code Issues Packages Projects Releases Wiki Activity

Some tweaks

Browse Source
This commit is contained in:
Stephan Schroevers
2017-12-10 15:59:34 +01:00
parent 9b3f6c07fa
commit 786d843956
4 changed files with 13 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
error-prone-contrib/src/main/java/com/picnicinternational/errorprone/bugpatterns/LexicographicalAnnotationAttributeListingCheck.java
View File

@@ -44,7 +44,7 @@ import java.util.stream.Stream;
public final class LexicographicalAnnotationAttributeListingCheck extends BugChecker
implements AnnotationTreeMatcher {
private static final long serialVersionUID = 1L;
private static final String FLAG_PREFIX = "LexicographicalAnnotationAttributeListingCheck:";
private static final String FLAG_PREFIX = "LexicographicalAnnotationAttributeListing:";
private static final String INCLUDED_ANNOTATIONS_FLAG = FLAG_PREFIX + "Includes";
private static final String EXCLUDED_ANNOTATIONS_FLAG = FLAG_PREFIX + "Excludes";

2
error-prone-contrib/src/main/java/com/picnicinternational/errorprone/bugpatterns/RedundantStringConversionCheck.java
View File

@@ -54,7 +54,7 @@ import java.util.regex.Pattern;
public final class RedundantStringConversionCheck extends BugChecker
implements BinaryTreeMatcher, CompoundAssignmentTreeMatcher, MethodInvocationTreeMatcher {
private static final long serialVersionUID = 1L;
private static final String FLAG_PREFIX = "RedundantStringConversionCheck:";
private static final String FLAG_PREFIX = "RedundantStringConversion:";
private static final String EXTRA_STRING_CONVERSION_METHODS_FLAG =
FLAG_PREFIX + "ExtraConversionMethods";
private static final Matcher<ExpressionTree> ANY_EXPR = (t, s) -> true;

4
error-prone-contrib/src/test/java/com/picnicinternational/errorprone/bugpatterns/LexicographicalAnnotationAttributeListingCheckTest.java
View File

@@ -18,8 +18,8 @@ public final class LexicographicalAnnotationAttributeListingCheckTest {
LexicographicalAnnotationAttributeListingCheck.class, getClass())
.setArgs(
ImmutableList.of(
"-XepOpt:LexicographicalAnnotationAttributeListingCheck:Includes=pkg.A.Foo,pkg.A.Bar",
"-XepOpt:LexicographicalAnnotationAttributeListingCheck:Excludes=pkg.A.Bar#value"));
"-XepOpt:LexicographicalAnnotationAttributeListing:Includes=pkg.A.Foo,pkg.A.Bar",
"-XepOpt:LexicographicalAnnotationAttributeListing:Excludes=pkg.A.Bar#value"));
private final BugCheckerRefactoringTestHelper refactoringTestHelper =
BugCheckerRefactoringTestHelper.newInstance(
new LexicographicalAnnotationAttributeListingCheck(), getClass());

10
error-prone-contrib/src/test/java/com/picnicinternational/errorprone/bugpatterns/RedundantStringConversionCheckTest.java
View File

@@ -19,7 +19,7 @@ public final class RedundantStringConversionCheckTest {
CompilationTestHelper.newInstance(RedundantStringConversionCheck.class, getClass())
.setArgs(
ImmutableList.of(
"-XepOpt:RedundantStringConversionCheck:ExtraConversionMethods=java.lang.Enum#name(),A#name(),A.B#toString(int)"));
"-XepOpt:RedundantStringConversion:ExtraConversionMethods=java.lang.Enum#name(),A#name(),A.B#toString(int)"));
private final BugCheckerRefactoringTestHelper refactoringTestHelper =
BugCheckerRefactoringTestHelper.newInstance(new RedundantStringConversionCheck(), getClass());
@@ -412,6 +412,14 @@ public final class RedundantStringConversionCheckTest {
" }",
" }",
"",
" enum E {",
" ELEM;",
"",
" public String toString() {",
" return \"__\" + name() + \"__\";",
" }",
" }",
"",
" private final B b = new B();",
" private final String s = b.toString();",
"",