jlengrand/vert.x
1
0
Fork 0
mirror of https://github.com/jlengrand/vert.x.git synced 2026-03-10 08:51:19 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix wrong EventBusMetrics reply failure reporting regression due to context tracing changes

Browse Source
This commit is contained in:
Julien Viet
2019-03-04 11:01:01 +01:00
parent 127e79377d
commit 929bc97381
2 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/main/java/io/vertx/core/eventbus/impl/EventBusImpl.java
View File

@@ -478,7 +478,7 @@ public class EventBusImpl implements EventBus, MetricsProvider {
void fail(ReplyException failure) {
registration.unregister();
if (metrics != null) {
metrics.replyFailure(registration.address, failure.failureType());
metrics.replyFailure(registration.repliedAddress, failure.failureType());
}
trace(null, failure);
result.tryFail(failure);

4
src/test/java/io/vertx/core/spi/metrics/MetricsTest.java
View File

@@ -423,7 +423,7 @@ public class MetricsTest extends VertxTestBase {
});
awaitLatch(latch);
FakeEventBusMetrics metrics = FakeMetricsBase.getMetrics(eb);
assertEquals(Collections.singletonList("__vertx.reply.1"), metrics.getReplyFailureAddresses());
assertEquals(Collections.singletonList("some-address1"), metrics.getReplyFailureAddresses());
assertEquals(Collections.singletonList(ReplyFailure.NO_HANDLERS), metrics.getReplyFailures());
}
@@ -482,7 +482,7 @@ public class MetricsTest extends VertxTestBase {
latch.countDown();
});
awaitLatch(latch);
assertEquals(Collections.singletonList(replyAddress.get()), metrics.getReplyFailureAddresses());
assertEquals(Collections.singletonList("foo"), metrics.getReplyFailureAddresses());
assertEquals(Collections.singletonList(ReplyFailure.RECIPIENT_FAILURE), metrics.getReplyFailures());
}