jlengrand/vert.x
1
0
Fork 0
mirror of https://github.com/jlengrand/vert.x.git synced 2026-03-10 08:51:19 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #1186 from nevesmarcio/2.x_memleak_only

Browse Source 
Memory leak fix in the subscribers cache
This commit is contained in:
Julien Viet
2018-04-16 11:30:25 +02:00
committed by GitHub
parent 61d6f58249 33fb5a77a1
commit 825c18d05d
1 changed files with 9 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
vertx-hazelcast/src/main/java/org/vertx/java/spi/cluster/impl/hazelcast/HazelcastAsyncMultiMap.java
View File

@@ -114,11 +114,15 @@ class HazelcastAsyncMultiMap<K, V> implements AsyncMultiMap<K, V>, EntryListener
} else {
sids = new ChoosableSet<>(0);
}
ChoosableSet<V> prev = cache.putIfAbsent(k, sids);
if (prev != null) {
// Merge them
prev.merge(sids);
sids = prev;
//SBKD-322 Quick fix for memory leak that has been caused by adding to subscribers cache
//empty sets. When no subscribers are present just omit caching it.
if (!sids.isEmpty()) {
ChoosableSet<V> prev = cache.putIfAbsent(k, sids);
if (prev != null) {
// Merge them
prev.merge(sids);
sids = prev;
}
}
sids.setInitialised();
sresult.setResult(sids);