HTTP/2 client clear text upgrade should send the preface after the upgrade request - see #3287 - see #3286

2026-03-10 08:51:19 +00:00 · 2020-02-18 10:28:07 +01:00
parent acee43c53e
commit 4413e5cb44
3 changed files with 17 additions and 183 deletions
--- a/src/main/asciidoc/dataobjects.adoc
+++ b/src/main/asciidoc/dataobjects.adoc
@@ -145,10 +145,6 @@ Set the idle timeout, default time unit is seconds. Zero means don't timeout.
 |[[idleTimeoutUnit]]`@idleTimeoutUnit`|`link:enums.html#TimeUnit[TimeUnit]`|+++
 Set the idle timeout unit. If not specified, default is seconds.
 +++
-|[[jdkSslEngineOptions]]`@jdkSslEngineOptions`|`link:dataobjects.html#JdkSSLEngineOptions[JdkSSLEngineOptions]`|-
-|[[keyStoreOptions]]`@keyStoreOptions`|`link:dataobjects.html#JksOptions[JksOptions]`|+++
-Set the key/cert options in jks format, aka Java keystore.
-+++
 |[[localAddress]]`@localAddress`|`String`|+++
 Set the local interface to bind for network connections. When the local address is null,
 it will pick any local address, the default local address is null.
@@ -160,22 +156,6 @@ Set to true to enabled network activity logging: Netty's pipeline is configured
 Set the metrics name identifying the reported metrics, useful for grouping metrics
 with the same name.
 +++
-|[[openSslEngineOptions]]`@openSslEngineOptions`|`link:dataobjects.html#OpenSSLEngineOptions[OpenSSLEngineOptions]`|-
-|[[pemKeyCertOptions]]`@pemKeyCertOptions`|`link:dataobjects.html#PemKeyCertOptions[PemKeyCertOptions]`|+++
-Set the key/cert store options in pem format.
-+++
-|[[pemTrustOptions]]`@pemTrustOptions`|`link:dataobjects.html#PemTrustOptions[PemTrustOptions]`|+++
-Set the trust options in pem format
-+++
-|[[pfxKeyCertOptions]]`@pfxKeyCertOptions`|`link:dataobjects.html#PfxOptions[PfxOptions]`|+++
-Set the key/cert options in pfx format.
-+++
-|[[pfxTrustOptions]]`@pfxTrustOptions`|`link:dataobjects.html#PfxOptions[PfxOptions]`|+++
-Set the trust options in pfx format
-+++
-|[[proxyOptions]]`@proxyOptions`|`link:dataobjects.html#ProxyOptions[ProxyOptions]`|+++
-Set proxy options for connections via CONNECT proxy (e.g. Squid) or a SOCKS proxy.
-+++
 |[[receiveBufferSize]]`@receiveBufferSize`|`Number (int)`|+++
 Set the TCP receive buffer size
 +++
@@ -223,9 +203,6 @@ Set the value of traffic class
 |[[trustAll]]`@trustAll`|`Boolean`|+++
 Set whether all server certificates should be trusted
 +++
-|[[trustStoreOptions]]`@trustStoreOptions`|`link:dataobjects.html#JksOptions[JksOptions]`|+++
-Set the trust options in jks format, aka Java truststore
-+++
 |[[useAlpn]]`@useAlpn`|`Boolean`|+++
 Set the ALPN usage.
 +++
@@ -478,26 +455,9 @@ Set the idle timeout, default time unit is seconds. Zero means don't timeout.
 |[[idleTimeoutUnit]]`@idleTimeoutUnit`|`link:enums.html#TimeUnit[TimeUnit]`|+++
 Set the idle timeout unit. If not specified, default is seconds.
 +++
-|[[jdkSslEngineOptions]]`@jdkSslEngineOptions`|`link:dataobjects.html#JdkSSLEngineOptions[JdkSSLEngineOptions]`|-
-|[[keyStoreOptions]]`@keyStoreOptions`|`link:dataobjects.html#JksOptions[JksOptions]`|+++
-Set the key/cert options in jks format, aka Java keystore.
-+++
 |[[logActivity]]`@logActivity`|`Boolean`|+++
 Set to true to enabled network activity logging: Netty's pipeline is configured for logging on Netty's logger.
 +++
-|[[openSslEngineOptions]]`@openSslEngineOptions`|`link:dataobjects.html#OpenSSLEngineOptions[OpenSSLEngineOptions]`|-
-|[[pemKeyCertOptions]]`@pemKeyCertOptions`|`link:dataobjects.html#PemKeyCertOptions[PemKeyCertOptions]`|+++
-Set the key/cert store options in pem format.
-+++
-|[[pemTrustOptions]]`@pemTrustOptions`|`link:dataobjects.html#PemTrustOptions[PemTrustOptions]`|+++
-Set the trust options in pem format
-+++
-|[[pfxKeyCertOptions]]`@pfxKeyCertOptions`|`link:dataobjects.html#PfxOptions[PfxOptions]`|+++
-Set the key/cert options in pfx format.
-+++
-|[[pfxTrustOptions]]`@pfxTrustOptions`|`link:dataobjects.html#PfxOptions[PfxOptions]`|+++
-Set the trust options in pfx format
-+++
 |[[port]]`@port`|`Number (int)`|+++
 Sets the port.
 +++
@@ -554,9 +514,6 @@ Set the value of traffic class
 |[[trustAll]]`@trustAll`|`Boolean`|+++
 Set whether all server certificates should be trusted.
 +++
-|[[trustStoreOptions]]`@trustStoreOptions`|`link:dataobjects.html#JksOptions[JksOptions]`|+++
-Set the trust options in jks format, aka Java truststore
-+++
 |[[useAlpn]]`@useAlpn`|`Boolean`|+++
 Set the ALPN usage.
 +++
@@ -733,10 +690,6 @@ Set the idle timeout, default time unit is seconds. Zero means don't timeout.
 |[[idleTimeoutUnit]]`@idleTimeoutUnit`|`link:enums.html#TimeUnit[TimeUnit]`|+++
 Set the idle timeout unit. If not specified, default is seconds.
 +++
-|[[initialSettings]]`@initialSettings`|`link:dataobjects.html#Http2Settings[Http2Settings]`|+++
-Set the HTTP/2 connection settings immediately sent by to the server when the client connects.
-+++
-|[[jdkSslEngineOptions]]`@jdkSslEngineOptions`|`link:dataobjects.html#JdkSSLEngineOptions[JdkSSLEngineOptions]`|-
 |[[keepAlive]]`@keepAlive`|`Boolean`|+++
 Set whether keep alive is enabled on the client
 +++
@@ -745,9 +698,6 @@ Set the keep alive timeout for HTTP/1.x, in seconds.
 <p/>
 This value determines how long a connection remains unused in the pool before being evicted and closed.
 +++
-|[[keyStoreOptions]]`@keyStoreOptions`|`link:dataobjects.html#JksOptions[JksOptions]`|+++
-Set the key/cert options in jks format, aka Java keystore.
-+++
 |[[localAddress]]`@localAddress`|`String`|+++
 Set the local interface to bind for network connections. When the local address is null,
 it will pick any local address, the default local address is null.
@@ -784,19 +734,6 @@ Set the max WebSocket message size
 Set the metrics name identifying the reported metrics, useful for grouping metrics
 with the same name.
 +++
-|[[openSslEngineOptions]]`@openSslEngineOptions`|`link:dataobjects.html#OpenSSLEngineOptions[OpenSSLEngineOptions]`|-
-|[[pemKeyCertOptions]]`@pemKeyCertOptions`|`link:dataobjects.html#PemKeyCertOptions[PemKeyCertOptions]`|+++
-Set the key/cert store options in pem format.
-+++
-|[[pemTrustOptions]]`@pemTrustOptions`|`link:dataobjects.html#PemTrustOptions[PemTrustOptions]`|+++
-Set the trust options in pem format
-+++
-|[[pfxKeyCertOptions]]`@pfxKeyCertOptions`|`link:dataobjects.html#PfxOptions[PfxOptions]`|+++
-Set the key/cert options in pfx format.
-+++
-|[[pfxTrustOptions]]`@pfxTrustOptions`|`link:dataobjects.html#PfxOptions[PfxOptions]`|+++
-Set the trust options in pfx format
-+++
 |[[pipelining]]`@pipelining`|`Boolean`|+++
 Set whether pipe-lining is enabled on the client
 +++
@@ -810,9 +747,6 @@ Set the connection pool cleaner period in milli seconds, a non positive value di
 |[[protocolVersion]]`@protocolVersion`|`link:enums.html#HttpVersion[HttpVersion]`|+++
 Set the protocol version.
 +++
-|[[proxyOptions]]`@proxyOptions`|`link:dataobjects.html#ProxyOptions[ProxyOptions]`|+++
-Set proxy options for connections via CONNECT proxy (e.g. Squid) or a SOCKS proxy.
-+++
 |[[receiveBufferSize]]`@receiveBufferSize`|`Number (int)`|+++
 Set the TCP receive buffer size
 +++
@@ -868,9 +802,6 @@ Set the value of traffic class
 |[[trustAll]]`@trustAll`|`Boolean`|+++
 Set whether all server certificates should be trusted
 +++
-|[[trustStoreOptions]]`@trustStoreOptions`|`link:dataobjects.html#JksOptions[JksOptions]`|+++
-Set the trust options in jks format, aka Java truststore
-+++
 |[[tryUseCompression]]`@tryUseCompression`|`Boolean`|+++
 Set whether compression is enabled
 +++
@@ -995,13 +926,6 @@ Set the idle timeout, default time unit is seconds. Zero means don't timeout.
 |[[idleTimeoutUnit]]`@idleTimeoutUnit`|`link:enums.html#TimeUnit[TimeUnit]`|+++
 Set the idle timeout unit. If not specified, default is seconds.
 +++
-|[[initialSettings]]`@initialSettings`|`link:dataobjects.html#Http2Settings[Http2Settings]`|+++
-Set the HTTP/2 connection settings immediatly sent by the server when a client connects.
-+++
-|[[jdkSslEngineOptions]]`@jdkSslEngineOptions`|`link:dataobjects.html#JdkSSLEngineOptions[JdkSSLEngineOptions]`|-
-|[[keyStoreOptions]]`@keyStoreOptions`|`link:dataobjects.html#JksOptions[JksOptions]`|+++
-Set the key/cert options in jks format, aka Java keystore.
-+++
 |[[logActivity]]`@logActivity`|`Boolean`|+++
 Set to true to enabled network activity logging: Netty's pipeline is configured for logging on Netty's logger.
 +++
@@ -1020,25 +944,12 @@ Set the maximum WebSocket frames size
 |[[maxWebSocketMessageSize]]`@maxWebSocketMessageSize`|`Number (int)`|+++
 Set the maximum WebSocket message size
 +++
-|[[openSslEngineOptions]]`@openSslEngineOptions`|`link:dataobjects.html#OpenSSLEngineOptions[OpenSSLEngineOptions]`|-
-|[[pemKeyCertOptions]]`@pemKeyCertOptions`|`link:dataobjects.html#PemKeyCertOptions[PemKeyCertOptions]`|+++
-Set the key/cert store options in pem format.
-+++
-|[[pemTrustOptions]]`@pemTrustOptions`|`link:dataobjects.html#PemTrustOptions[PemTrustOptions]`|+++
-Set the trust options in pem format
-+++
 |[[perFrameWebSocketCompressionSupported]]`@perFrameWebSocketCompressionSupported`|`Boolean`|+++
 Enable or disable support for the WebSocket per-frame deflate compression extension.
 +++
 |[[perMessageWebSocketCompressionSupported]]`@perMessageWebSocketCompressionSupported`|`Boolean`|+++
 Enable or disable support for WebSocket per-message deflate compression extension.
 +++
-|[[pfxKeyCertOptions]]`@pfxKeyCertOptions`|`link:dataobjects.html#PfxOptions[PfxOptions]`|+++
-Set the key/cert options in pfx format.
-+++
-|[[pfxTrustOptions]]`@pfxTrustOptions`|`link:dataobjects.html#PfxOptions[PfxOptions]`|+++
-Set the trust options in pfx format
-+++
 |[[port]]`@port`|`Number (int)`|+++
 Set the port
 +++
@@ -1089,9 +1000,6 @@ Enable the <code>TCP_QUICKACK</code> option - only with linux native transport.
 |[[trafficClass]]`@trafficClass`|`Number (int)`|+++
 Set the value of traffic class
 +++
-|[[trustStoreOptions]]`@trustStoreOptions`|`link:dataobjects.html#JksOptions[JksOptions]`|+++
-Set the trust options in jks format, aka Java truststore
-+++
 |[[useAlpn]]`@useAlpn`|`Boolean`|+++
 Set the ALPN usage.
 +++
@@ -1224,10 +1132,6 @@ Set the idle timeout, default time unit is seconds. Zero means don't timeout.
 |[[idleTimeoutUnit]]`@idleTimeoutUnit`|`link:enums.html#TimeUnit[TimeUnit]`|+++
 Set the idle timeout unit. If not specified, default is seconds.
 +++
-|[[jdkSslEngineOptions]]`@jdkSslEngineOptions`|`link:dataobjects.html#JdkSSLEngineOptions[JdkSSLEngineOptions]`|-
-|[[keyStoreOptions]]`@keyStoreOptions`|`link:dataobjects.html#JksOptions[JksOptions]`|+++
-Set the key/cert options in jks format, aka Java keystore.
-+++
 |[[localAddress]]`@localAddress`|`String`|+++
 Set the local interface to bind for network connections. When the local address is null,
 it will pick any local address, the default local address is null.
@@ -1239,22 +1143,6 @@ Set to true to enabled network activity logging: Netty's pipeline is configured
 Set the metrics name identifying the reported metrics, useful for grouping metrics
 with the same name.
 +++
-|[[openSslEngineOptions]]`@openSslEngineOptions`|`link:dataobjects.html#OpenSSLEngineOptions[OpenSSLEngineOptions]`|-
-|[[pemKeyCertOptions]]`@pemKeyCertOptions`|`link:dataobjects.html#PemKeyCertOptions[PemKeyCertOptions]`|+++
-Set the key/cert store options in pem format.
-+++
-|[[pemTrustOptions]]`@pemTrustOptions`|`link:dataobjects.html#PemTrustOptions[PemTrustOptions]`|+++
-Set the trust options in pem format
-+++
-|[[pfxKeyCertOptions]]`@pfxKeyCertOptions`|`link:dataobjects.html#PfxOptions[PfxOptions]`|+++
-Set the key/cert options in pfx format.
-+++
-|[[pfxTrustOptions]]`@pfxTrustOptions`|`link:dataobjects.html#PfxOptions[PfxOptions]`|+++
-Set the trust options in pfx format
-+++
-|[[proxyOptions]]`@proxyOptions`|`link:dataobjects.html#ProxyOptions[ProxyOptions]`|+++
-Set proxy options for connections via CONNECT proxy (e.g. Squid) or a SOCKS proxy.
-+++
 |[[receiveBufferSize]]`@receiveBufferSize`|`Number (int)`|+++
 Set the TCP receive buffer size
 +++
@@ -1308,9 +1196,6 @@ Set the value of traffic class
 |[[trustAll]]`@trustAll`|`Boolean`|+++
 Set whether all server certificates should be trusted
 +++
-|[[trustStoreOptions]]`@trustStoreOptions`|`link:dataobjects.html#JksOptions[JksOptions]`|+++
-Set the trust options in jks format, aka Java truststore
-+++
 |[[useAlpn]]`@useAlpn`|`Boolean`|+++
 Set the ALPN usage.
 +++
@@ -1358,26 +1243,9 @@ Set the idle timeout, default time unit is seconds. Zero means don't timeout.
 |[[idleTimeoutUnit]]`@idleTimeoutUnit`|`link:enums.html#TimeUnit[TimeUnit]`|+++
 Set the idle timeout unit. If not specified, default is seconds.
 +++
-|[[jdkSslEngineOptions]]`@jdkSslEngineOptions`|`link:dataobjects.html#JdkSSLEngineOptions[JdkSSLEngineOptions]`|-
-|[[keyStoreOptions]]`@keyStoreOptions`|`link:dataobjects.html#JksOptions[JksOptions]`|+++
-Set the key/cert options in jks format, aka Java keystore.
-+++
 |[[logActivity]]`@logActivity`|`Boolean`|+++
 Set to true to enabled network activity logging: Netty's pipeline is configured for logging on Netty's logger.
 +++
-|[[openSslEngineOptions]]`@openSslEngineOptions`|`link:dataobjects.html#OpenSSLEngineOptions[OpenSSLEngineOptions]`|-
-|[[pemKeyCertOptions]]`@pemKeyCertOptions`|`link:dataobjects.html#PemKeyCertOptions[PemKeyCertOptions]`|+++
-Set the key/cert store options in pem format.
-+++
-|[[pemTrustOptions]]`@pemTrustOptions`|`link:dataobjects.html#PemTrustOptions[PemTrustOptions]`|+++
-Set the trust options in pem format
-+++
-|[[pfxKeyCertOptions]]`@pfxKeyCertOptions`|`link:dataobjects.html#PfxOptions[PfxOptions]`|+++
-Set the key/cert options in pfx format.
-+++
-|[[pfxTrustOptions]]`@pfxTrustOptions`|`link:dataobjects.html#PfxOptions[PfxOptions]`|+++
-Set the trust options in pfx format
-+++
 |[[port]]`@port`|`Number (int)`|+++
 Set the port
 +++
@@ -1428,9 +1296,6 @@ Enable the <code>TCP_QUICKACK</code> option - only with linux native transport.
 |[[trafficClass]]`@trafficClass`|`Number (int)`|+++
 Set the value of traffic class
 +++
-|[[trustStoreOptions]]`@trustStoreOptions`|`link:dataobjects.html#JksOptions[JksOptions]`|+++
-Set the trust options in jks format, aka Java truststore
-+++
 |[[useAlpn]]`@useAlpn`|`Boolean`|+++
 Set the ALPN usage.
 +++
@@ -1910,26 +1775,9 @@ Set the idle timeout, default time unit is seconds. Zero means don't timeout.
 |[[idleTimeoutUnit]]`@idleTimeoutUnit`|`link:enums.html#TimeUnit[TimeUnit]`|+++
 Set the idle timeout unit. If not specified, default is seconds.
 +++
-|[[jdkSslEngineOptions]]`@jdkSslEngineOptions`|`link:dataobjects.html#JdkSSLEngineOptions[JdkSSLEngineOptions]`|-
-|[[keyStoreOptions]]`@keyStoreOptions`|`link:dataobjects.html#JksOptions[JksOptions]`|+++
-Set the key/cert options in jks format, aka Java keystore.
-+++
 |[[logActivity]]`@logActivity`|`Boolean`|+++
 Set to true to enabled network activity logging: Netty's pipeline is configured for logging on Netty's logger.
 +++
-|[[openSslEngineOptions]]`@openSslEngineOptions`|`link:dataobjects.html#OpenSSLEngineOptions[OpenSSLEngineOptions]`|-
-|[[pemKeyCertOptions]]`@pemKeyCertOptions`|`link:dataobjects.html#PemKeyCertOptions[PemKeyCertOptions]`|+++
-Set the key/cert store options in pem format.
-+++
-|[[pemTrustOptions]]`@pemTrustOptions`|`link:dataobjects.html#PemTrustOptions[PemTrustOptions]`|+++
-Set the trust options in pem format
-+++
-|[[pfxKeyCertOptions]]`@pfxKeyCertOptions`|`link:dataobjects.html#PfxOptions[PfxOptions]`|+++
-Set the key/cert options in pfx format.
-+++
-|[[pfxTrustOptions]]`@pfxTrustOptions`|`link:dataobjects.html#PfxOptions[PfxOptions]`|+++
-Set the trust options in pfx format
-+++
 |[[receiveBufferSize]]`@receiveBufferSize`|`Number (int)`|+++
 Set the TCP receive buffer size
 +++
@@ -1974,9 +1822,6 @@ Enable the <code>TCP_QUICKACK</code> option - only with linux native transport.
 |[[trafficClass]]`@trafficClass`|`Number (int)`|+++
 Set the value of traffic class
 +++
-|[[trustStoreOptions]]`@trustStoreOptions`|`link:dataobjects.html#JksOptions[JksOptions]`|+++
-Set the trust options in jks format, aka Java truststore
-+++
 |[[useAlpn]]`@useAlpn`|`Boolean`|+++
 Set the ALPN usage.
 +++
@@ -2012,9 +1857,6 @@ Set whether tracing will be enabled on the Vert.x instance.
 [frame="topbot"]
 |===
 ^|Name | Type ^| Description
-|[[addressResolverOptions]]`@addressResolverOptions`|`link:dataobjects.html#AddressResolverOptions[AddressResolverOptions]`|+++
-Sets the address resolver configuration to configure resolving DNS servers, cache TTL, etc...
-+++
 |[[blockedThreadCheckInterval]]`@blockedThreadCheckInterval`|`Number (long)`|+++
 Sets the value of blocked thread check period, in link.
 <p>
@@ -2048,15 +1890,9 @@ See link for an explanation.
 |[[clustered]]`@clustered`|`Boolean`|+++
 Set whether or not the Vert.x instance will be clustered.
 +++
-|[[eventBusOptions]]`@eventBusOptions`|`link:dataobjects.html#EventBusOptions[EventBusOptions]`|+++
-Sets the event bus configuration to configure the host, port, ssl...
-+++
 |[[eventLoopPoolSize]]`@eventLoopPoolSize`|`Number (int)`|+++
 Set the number of event loop threads to be used by the Vert.x instance.
 +++
-|[[fileSystemOptions]]`@fileSystemOptions`|`link:dataobjects.html#FileSystemOptions[FileSystemOptions]`|+++
-Set the file system options
-+++
 |[[haEnabled]]`@haEnabled`|`Boolean`|+++
 Set whether HA will be enabled on the Vert.x instance.
 +++
@@ -2082,16 +1918,12 @@ Sets the value of max worker execute time, in link.
 |[[maxWorkerExecuteTimeUnit]]`@maxWorkerExecuteTimeUnit`|`link:enums.html#TimeUnit[TimeUnit]`|+++
 Set the time unit of <code>maxWorkerExecuteTime</code>.
 +++
-|[[metricsOptions]]`@metricsOptions`|`link:dataobjects.html#MetricsOptions[MetricsOptions]`|+++
-Set the metrics options
-+++
 |[[preferNativeTransport]]`@preferNativeTransport`|`Boolean`|+++
 Set wether to prefer the native transport to the JDK transport.
 +++
 |[[quorumSize]]`@quorumSize`|`Number (int)`|+++
 Set the quorum size to be used when HA is enabled.
 +++
-|[[tracingOptions]]`@tracingOptions`|`link:dataobjects.html#TracingOptions[TracingOptions]`|-
 |[[warningExceptionTime]]`@warningExceptionTime`|`Number (long)`|+++
 Set the threshold value above this, the blocked warning contains a stack trace. in link.
 The default value of link is
--- a/src/main/java/io/vertx/core/http/impl/Http2UpgradedClientConnection.java
+++ b/src/main/java/io/vertx/core/http/impl/Http2UpgradedClientConnection.java
@@ -146,7 +146,6 @@ public class Http2UpgradedClientConnection implements HttpClientConnection {
        }
      }

-
      VertxHttp2ClientUpgradeCodec upgradeCodec = new VertxHttp2ClientUpgradeCodec(client.getOptions().getInitialSettings()) {
        @Override
        public void upgradeTo(ChannelHandlerContext ctx, FullHttpResponse upgradeResponse) throws Exception {
@@ -222,17 +221,26 @@ public class Http2UpgradedClientConnection implements HttpClientConnection {
      };
      pipeline.addAfter("codec", null, new UpgradeRequestHandler());
      pipeline.addAfter("codec", null, upgradeHandler);
-      Runnable task = () -> {
+      doWriteHead(method, uri, headers, authority, chunked, buf, end, priority, listener);
+    }
+
+    private void doWriteHead(HttpMethod method,
+                             String uri,
+                             MultiMap headers,
+                             String authority,
+                             boolean chunked,
+                             ByteBuf buf,
+                             boolean end,
+                             StreamPriority priority,
+                             Handler<AsyncResult<Void>> listener) {
+      EventExecutor exec = conn.channelHandlerContext().executor();
+      if (exec.inEventLoop()) {
        stream.writeHead(method, uri, headers, authority, chunked, buf, end, priority, listener);
        if (end) {
          end();
        }
-      };
-      EventExecutor exec = conn.channelHandlerContext().executor();
-      if (exec.inEventLoop()) {
-        task.run();
      } else {
-        exec.execute(task);
+        exec.execute(() -> doWriteHead(method, uri, headers, authority, chunked, buf, end, priority, listener));
      }
    }

@@ -241,8 +249,8 @@ public class Http2UpgradedClientConnection implements HttpClientConnection {
      List<Object> messages = pending;
      pending = null;
      ChannelHandlerContext context = conn.channelHandlerContext().pipeline().context("codec");
-      for (Object message : messages) {
-        context.fireChannelRead(message);
+      for (Object msg : messages) {
+        context.fireChannelRead(msg);
      }
    }

--- a/src/test/java/io/vertx/core/http/Http2ClientTest.java
+++ b/src/test/java/io/vertx/core/http/Http2ClientTest.java
@@ -1638,12 +1638,6 @@ public class Http2ClientTest extends Http2TestBase {
        });
      });
      HttpClientRequest req = client.request(HttpMethod.GET, "/somepath")
-        .setHandler(onSuccess(resp -> {
-          resp.exceptionHandler(err -> {
-            assertOnIOContext(ctx);
-            complete();
-          });
-        }))
        .exceptionHandler(err -> {
          complete();
        });