jlengrand/picocli
1
0
Fork 0
mirror of https://github.com/jlengrand/picocli.git synced 2026-03-10 08:41:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

[#1229][#1184] update RELEASE-NOTES for bugfix

Browse Source
This commit is contained in:
Remko Popma
2020-10-27 06:23:08 +09:00
parent aae922931e
commit 33f4fd2b15
2 changed files with 4 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
RELEASE-NOTES.md
View File

@@ -20,6 +20,7 @@ Picocli follows [semantic versioning](http://semver.org/).
## <a name="4.6.0-fixes"></a> Fixed issues
* [#1184] API: Added public methods `Help.Layout::colorScheme`, `Help.Layout::textTable`, `Help.Layout::optionRenderer`, `Help.Layout::parameterRenderer`, and `Help::calcLongOptionColumnWidth`.
* [#1229] Bugfix: Fix compilation error introduced with fc5ef6de6 (#1184). Thanks to [Andreas Deininger](https://github.com/deining) for the pull request.
* [#1225] Bugfix: Error message for unmatched positional argument reports incorrect index when value equals a previously matched argument. Thanks to [Vitaly Shukela](https://github.com/vi) for raising this.
* [#1215] DOC: User manual improvements, including more tabs with Kotlin source code. Thanks to [Andreas Deininger](https://github.com/deining) for the pull request.
* [#1219] DOC: User manual improvements: added more tabs with Kotlin code. Thanks to [Andreas Deininger](https://github.com/deining) for the pull request.

6
src/main/java/picocli/CommandLine.java
View File

@@ -15107,13 +15107,13 @@ public class CommandLine {
int len = cjk ? values[0][3].getCJKAdjustedLength() : values[0][3].length;
if (len < longOptionsColWidth) { max = Math.max(max, len); }
}
List<PositionalParamSpec> positionalParamSpecs = new ArrayList<PositionalParamSpec>(positionals); // iterate in declaration order
List<PositionalParamSpec> positionalsWithAtFile = new ArrayList<PositionalParamSpec>(positionals); // iterate in declaration order
if (hasAtFileParameter()) {
positionalParamSpecs.add(0, AT_FILE_POSITIONAL_PARAM);
positionalsWithAtFile.add(0, AT_FILE_POSITIONAL_PARAM);
AT_FILE_POSITIONAL_PARAM.messages(commandSpec.usageMessage().messages());
}
//IParameterRenderer paramRenderer = new DefaultParameterRenderer(false, " ");
for (PositionalParamSpec positionalParamSpecs : positionals) {
for (PositionalParamSpec positional : positionalsWithAtFile) {
if (positional.hidden()) { continue; }
//Text[][] values = paramRenderer.render(positional, parameterLabelRenderer(), colorScheme); // values[0][3]; //
Text label = parameterLabelRenderer().renderParameterLabel(positional, aColorScheme.ansi(), aColorScheme.parameterStyles);