jlengrand/open-wc
1
0
Fork 0
mirror of https://github.com/jlengrand/open-wc.git synced 2026-03-10 08:31:19 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(scoped-elements): refactor to remove optional chain in Cache

Browse Source
This commit is contained in:
Matthew Ailes
2020-11-11 16:18:32 -05:00
committed by Lars den Bakker
parent 1375963db8
commit 9fb1c1319d
3 changed files with 19 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
.changeset/plenty-plants-hunt.md Normal file
View File

@@ -0,0 +1,5 @@
---
'@open-wc/scoped-elements': patch
---
refactor to remove optional chaining syntax in Cache file for better tooling compatibility

4
packages/scoped-elements/src/Cache.js
View File

@@ -19,7 +19,7 @@ export class Cache {
* @return {boolean}
*/
has(key) {
return !!(this._cache.has(key) || this._parent?._cache.has(key));
return !!(this._cache.has(key) || (this._parent && this._parent._cache.has(key)));
}
/**
@@ -44,6 +44,6 @@ export class Cache {
* @return {Q}
*/
get(key) {
return this._cache.get(key) || this._parent?._cache.get(key);
return this._cache.get(key) || (this._parent && this._parent._cache.get(key));
}
}

12
packages/scoped-elements/test-web/Cache.test.js
View File

@@ -24,6 +24,12 @@ describe('Cache', () => {
expect(cache.has('key')).to.be.false;
});
it(`should return false if the key does not exist and no parent exists`, () => {
const cache = new Cache();
expect(cache.has('key')).to.be.false;
});
it(`should return true if the key exist`, () => {
const cache = new Cache();
cache._cache.set('key', 'value');
@@ -93,6 +99,12 @@ describe('Cache', () => {
expect(cache.get('key')).to.be.undefined;
});
it('should return undefined in case key does not exist and parent does not exist', () => {
const cache = new Cache();
expect(cache.get('key')).to.be.undefined;
});
it('should return undefined in case the key is not provided', () => {
const parent = new Cache();
const cache = new Cache(parent);