[maven-release-plugin] prepare release github-api-1.59

Presumably due to the behaviour change on GitHub API?

pom.xml

@@ -7,7 +7,7 @@
   </parent>
 
   <artifactId>github-api</artifactId>
-  <version>1.58</version>
+  <version>1.59</version>
   <name>GitHub API for Java</name>
   <url>http://github-api.kohsuke.org/</url>
   <description>GitHub API for Java</description>
@@ -16,7 +16,7 @@
     <connection>scm:git:git@github.com/kohsuke/${project.artifactId}.git</connection>
     <developerConnection>scm:git:ssh://git@github.com/kohsuke/${project.artifactId}.git</developerConnection>
     <url>http://${project.artifactId}.kohsuke.org/</url>
-    <tag>github-api-1.58</tag>
+    <tag>HEAD</tag>
   </scm>
 
   <distributionManagement>

src/main/java/org/kohsuke/github/GHAsset.java

@@ -21,6 +21,7 @@ public class GHAsset {
     private long download_count;
     private Date created_at;
     private Date updated_at;
+    private String browser_download_url;
 
     public String getContentType() {
         return content_type;
@@ -80,6 +81,10 @@ public class GHAsset {
         return url;
     }
 
+    public String getBrowserDownloadUrl() {
+        return browser_download_url;
+    }
+
     private void edit(String key, Object value) throws IOException {
         new Requester(root)._with(key, value).method("PATCH").to(getApiRoute());
     }

src/main/java/org/kohsuke/github/GHAuthorization.java

@@ -22,6 +22,15 @@ public class GHAuthorization {
 	public static final String DELETE_REPO = "delete_repo";
 	public static final String NOTIFICATIONS = "notifications";
 	public static final String GIST = "gist";
+	public static final String READ_HOOK = "read:repo_hook";
+	public static final String WRITE_HOOK = "write:repo_hook";
+	public static final String AMIN_HOOK = "admin:repo_hook";
+	public static final String READ_ORG = "read:org";
+	public static final String WRITE_ORG = "write:org";
+	public static final String ADMIN_ORG = "admin:org";
+	public static final String READ_KEY = "read:public_key";
+	public static final String WRITE_KEY = "write:public_key";
+	public static final String ADMIN_KEY = "admin:public_key";
 
 	private GitHub root;
 	private int id;

src/main/java/org/kohsuke/github/GHCompare.java

@@ -68,9 +68,12 @@ public class GHCompare {
     public Commit[] getCommits() {
         return commits;
     }
+    
+    public GHCommit.File[] getFiles() {
+		return files;
+	}
 
-
+	public GHCompare wrap(GHRepository owner) {
-    public GHCompare wrap(GHRepository owner) {
         this.owner = owner;
         for (Commit commit : commits) {
             commit.wrapUp(owner);

src/main/java/org/kohsuke/github/GHIssue.java

@@ -129,7 +129,7 @@ public class GHIssue {
         return Enum.valueOf(GHIssueState.class, state.toUpperCase(Locale.ENGLISH));
     }
 
-    public Collection<Label> getLabels() {
+    public Collection<Label> getLabels() throws IOException {
         if(labels == null){
             return Collections.EMPTY_LIST;
         }
@@ -163,6 +163,10 @@ public class GHIssue {
         new Requester(root)._with(key, value).method("PATCH").to(getApiRoute());
     }
 
+    private void editIssue(String key, Object value) throws IOException {
+        new Requester(root)._with(key, value).method("PATCH").to(getIssuesApiRoute());
+    }
+
     /**
      * Closes this issue.
      */
@@ -186,11 +190,11 @@ public class GHIssue {
     }
 
     public void assignTo(GHUser user) throws IOException {
-        edit("assignee",user.getLogin());
+        editIssue("assignee",user.getLogin());
     }
 
     public void setLabels(String... labels) throws IOException {
-        edit("labels",labels);
+        editIssue("labels",labels);
     }
 
     /**
@@ -222,7 +226,7 @@ public class GHIssue {
         return getIssuesApiRoute();
     }
 
-    private String getIssuesApiRoute() {
+    protected String getIssuesApiRoute() {
         return "/repos/"+owner.getOwnerName()+"/"+owner.getName()+"/issues/"+number;
     }
 

src/main/java/org/kohsuke/github/GHPullRequest.java

@@ -52,6 +52,13 @@ public class GHPullRequest extends GHIssue {
    	private String mergeable_state;
    	private int changed_files;
 
+    /**
+     * GitHub doesn't return some properties of {@link GHIssue} when requesting the GET on the 'pulls' API
+     * route as opposed to 'issues' API route. This flag remembers whether we made the GET call on the 'issues' route
+     * on this object to fill in those missing details
+     */
+    private transient boolean fetchedIssueDetails;
+
 
 	GHPullRequest wrapUp(GHRepository owner) {
 		this.wrap(owner);
@@ -120,11 +127,12 @@ public class GHPullRequest extends GHIssue {
     }
 
 	@Override
-	public Collection<Label> getLabels() {
+	public Collection<Label> getLabels() throws IOException {
+        fetchIssue();
 		return super.getLabels();
 	}
 
-	@Override
+    @Override
 	public GHUser getClosedBy() {
 		return null;
 	}
@@ -218,4 +226,10 @@ public class GHPullRequest extends GHIssue {
         new Requester(root).method("PUT").with("commit_message",msg).to(getApiRoute()+"/merge");
     }
 
+    private void fetchIssue() throws IOException {
+        if (!fetchedIssueDetails) {
+            new Requester(root).to(getIssuesApiRoute(), this);
+            fetchedIssueDetails = true;
+        }
+    }
 }

src/main/java/org/kohsuke/github/GHRepository.java

@@ -514,7 +514,7 @@ public class GHRepository {
                     @Override
                     protected void wrapUp(GHPullRequest[] page) {
                         for (GHPullRequest pr : page)
-                            pr.wrap(GHRepository.this);
+                            pr.wrapUp(GHRepository.this);
                     }
                 };
             }

src/main/java/org/kohsuke/github/GHTeam.java

@@ -78,9 +78,13 @@ public class GHTeam {
 
     /**
      * Adds a member to the team.
+     *
+     * The user will be invited to the organization if required.
+     *
+     * @since 1.59
      */
     public void add(GHUser u) throws IOException {
-        org.root.retrieve().method("PUT").to(api("/members/" + u.getLogin()), null);
+        org.root.retrieve().method("PUT").to(api("/memberships/" + u.getLogin()), null);
     }
 
     /**

src/main/java/org/kohsuke/github/GitHub.java

@@ -26,8 +26,6 @@ package org.kohsuke.github;
 import static com.fasterxml.jackson.annotation.JsonAutoDetect.Visibility.ANY;
 import static com.fasterxml.jackson.annotation.JsonAutoDetect.Visibility.NONE;
 
-import java.io.File;
-import java.io.FileInputStream;
 import java.io.FileNotFoundException;
 import java.io.IOException;
 import java.io.Reader;
@@ -42,12 +40,10 @@ import java.util.HashMap;
 import java.util.HashSet;
 import java.util.List;
 import java.util.Map;
-import java.util.Properties;
 import java.util.Set;
 import java.util.TimeZone;
 
 import org.apache.commons.codec.binary.Base64;
-import org.apache.commons.io.IOUtils;
 
 import com.fasterxml.jackson.databind.DeserializationFeature;
 import com.fasterxml.jackson.databind.ObjectMapper;
@@ -74,13 +70,6 @@ public class GitHub {
 
     private HttpConnector connector = HttpConnector.DEFAULT;
 
-    /**
-     * Connects to GitHub.com
-     */
-    private GitHub(String login, String oauthAccessToken, String password) throws IOException {
-      this (GITHUB_URL, login, oauthAccessToken, password);
-    }
-
     /**
      * Creates a client API root object.
      *
@@ -114,10 +103,13 @@ public class GitHub {
      *      Secret OAuth token.
      * @param password
      *      User's password. Always used in conjunction with the {@code login} parameter
+     * @param connector
+     *      HttpConnector to use. Pass null to use default connector.
      */
-    private GitHub(String apiUrl, String login, String oauthAccessToken, String password) throws IOException {
+    /* package */ GitHub(String apiUrl, String login, String oauthAccessToken, String password, HttpConnector connector) throws IOException {
         if (apiUrl.endsWith("/")) apiUrl = apiUrl.substring(0, apiUrl.length()-1); // normalize
         this.apiUrl = apiUrl;
+        if (null != connector) this.connector = connector;
 
         if (oauthAccessToken!=null) {
             encodedAuthorization = "token "+oauthAccessToken;
@@ -136,18 +128,10 @@ public class GitHub {
     }
 
     /**
-     * Obtains the credential from "~/.github"
+     * Obtains the credential from "~/.github" or from the System Environment Properties.
      */
     public static GitHub connect() throws IOException {
-        Properties props = new Properties();
+        return GitHubBuilder.fromCredentials().build();
-        File homeDir = new File(System.getProperty("user.home"));
-        FileInputStream in = new FileInputStream(new File(homeDir, ".github"));
-        try {
-            props.load(in);
-        } finally {
-            IOUtils.closeQuietly(in);
-        }
-        return new GitHub(GITHUB_URL,props.getProperty("login"), props.getProperty("oauth"),props.getProperty("password"));
     }
 
     /**
@@ -159,15 +143,15 @@ public class GitHub {
      *      For historical reasons, this parameter still accepts the bare domain name, but that's considered deprecated.
      */
     public static GitHub connectToEnterprise(String apiUrl, String oauthAccessToken) throws IOException {
-        return connectUsingOAuth(apiUrl, oauthAccessToken);
+        return new GitHubBuilder().withEndpoint(apiUrl).withOAuthToken(oauthAccessToken).build();
     }
 
     public static GitHub connectToEnterprise(String apiUrl, String login, String password) throws IOException {
-        return new GitHub(apiUrl, login, null, password);
+        return new GitHubBuilder().withEndpoint(apiUrl).withPassword(login, password).build();
     }
 
     public static GitHub connect(String login, String oauthAccessToken) throws IOException {
-        return new GitHub(login,oauthAccessToken,null);
+        return new GitHubBuilder().withOAuthToken(oauthAccessToken, login).build();
     }
 
     /**
@@ -176,19 +160,19 @@ public class GitHub {
      *      Use {@link #connectUsingPassword(String, String)} or {@link #connectUsingOAuth(String)}.
      */
     public static GitHub connect(String login, String oauthAccessToken, String password) throws IOException {
-        return new GitHub(login,oauthAccessToken,password);
+        return new GitHubBuilder().withOAuthToken(oauthAccessToken, login).withPassword(login, password).build();
     }
 
     public static GitHub connectUsingPassword(String login, String password) throws IOException {
-        return new GitHub(login,null,password);
+        return new GitHubBuilder().withPassword(login, password).build();
     }
 
     public static GitHub connectUsingOAuth(String oauthAccessToken) throws IOException {
-    	return new GitHub(null, oauthAccessToken, null);
+        return new GitHubBuilder().withOAuthToken(oauthAccessToken).build();
     }
 
     public static GitHub connectUsingOAuth(String githubServer, String oauthAccessToken) throws IOException {
-    	return new GitHub(githubServer,null, oauthAccessToken,null);
+        return new GitHubBuilder().withEndpoint(githubServer).withOAuthToken(oauthAccessToken).build();
     }
     /**
      * Connects to GitHub anonymously.
@@ -196,7 +180,7 @@ public class GitHub {
      * All operations that requires authentication will fail.
      */
     public static GitHub connectAnonymously() throws IOException {
-        return new GitHub(null,null,null);
+        return new GitHubBuilder().build();
     }
 
     /**
@@ -475,5 +459,5 @@ public class GitHub {
         MAPPER.configure(DeserializationFeature.FAIL_ON_UNKNOWN_PROPERTIES, false);
     }
 
-    private static final String GITHUB_URL = "https://api.github.com";
+    /* package */ static final String GITHUB_URL = "https://api.github.com";
 }

src/main/java/org/kohsuke/github/GitHubBuilder.java

@@ -0,0 +1,159 @@
+package org.kohsuke.github;
+
+import org.apache.commons.io.IOUtils;
+
+import java.io.File;
+import java.io.FileInputStream;
+import java.io.FileNotFoundException;
+import java.io.IOException;
+import java.util.Map;
+import java.util.Properties;
+
+/**
+ * @since 1.59
+ */
+public class GitHubBuilder {
+    private String endpoint = GitHub.GITHUB_URL;
+    
+    // default scoped so unit tests can read them.
+    /* private */ String user;
+    /* private */ String password;
+    /* private */ String oauthToken;
+    
+    private HttpConnector connector;
+
+    public GitHubBuilder() {
+    }
+
+    /**
+     * First check if the credentials are configured using the ~/.github properties file.
+     * 
+     * If no user is specified it means there is no configuration present so check the environment instead.
+     * 
+     * If there is still no user it means there are no credentials defined and throw an IOException.
+     * 
+     * @return the configured Builder from credentials defined on the system or in the environment.
+     * 
+     * @throws IOException If there are no credentials defined in the ~/.github properties file or the process environment.
+     */
+    public static GitHubBuilder fromCredentials() throws IOException {
+    	
+    	GitHubBuilder builder;
+		try {
+			builder = fromPropertyFile();
+			
+			if (builder.user != null)
+	    		return builder;
+	    	else {
+	    		
+	    		// this is the case where the ~/.github file exists but has no content.
+	    		
+	    		builder = fromEnvironment();
+	    		
+	    		if (builder.user != null)
+	    			return builder;
+	    		else
+	    			throw new IOException("Failed to resolve credentials from ~/.github or the environment.");
+	    	}
+	    	
+		} catch (FileNotFoundException e) {
+			builder = fromEnvironment();
+			
+			if (builder.user != null)
+				return builder;
+			else
+				throw new IOException("Failed to resolve credentials from ~/.github or the environment.", e);
+		}
+    
+    }
+    
+    public static GitHubBuilder fromEnvironment(String loginVariableName, String passwordVariableName, String oauthVariableName) throws IOException {
+    	
+    	
+    	Properties env = new Properties();
+    	
+    	Object loginValue = System.getenv(loginVariableName);
+    	
+    	if (loginValue != null)
+    		env.put("login", loginValue);
+    	
+    	Object passwordValue = System.getenv(passwordVariableName);
+    	
+    	if (passwordValue != null)
+    		env.put("password", passwordValue);
+
+    	Object oauthValue = System.getenv(oauthVariableName);
+    	
+    	if (oauthValue != null)
+    		env.put("oauth", oauthValue);
+    	
+    	return fromProperties(env);
+
+    }
+    
+    public static GitHubBuilder fromEnvironment() throws IOException {
+    	
+    	Properties props = new Properties();
+    	
+    	Map<String, String> env = System.getenv();
+    	
+    	for (Map.Entry<String, String> element : env.entrySet()) {
+			
+    		props.put(element.getKey(), element.getValue());
+		}
+    	
+        return fromProperties(props);
+    }
+    
+    public static GitHubBuilder fromPropertyFile() throws IOException {
+        File homeDir = new File(System.getProperty("user.home"));
+        File propertyFile = new File(homeDir, ".github");
+        return fromPropertyFile(propertyFile.getPath());
+    }
+    
+    public static GitHubBuilder fromPropertyFile(String propertyFileName) throws IOException {
+        Properties props = new Properties();
+        FileInputStream in = null;
+        try {
+            in = new FileInputStream(propertyFileName);
+            props.load(in);
+        } finally {
+            IOUtils.closeQuietly(in);
+        }
+     
+        return fromProperties(props);
+    }
+    
+    public static GitHubBuilder fromProperties(Properties props) {
+        GitHubBuilder self = new GitHubBuilder();
+        self.withOAuthToken(props.getProperty("oauth"), props.getProperty("login"));
+        self.withPassword(props.getProperty("login"), props.getProperty("password"));
+        return self;
+    }
+
+    public GitHubBuilder withEndpoint(String endpoint) {
+        this.endpoint = endpoint;
+        return this;
+    }
+    public GitHubBuilder withPassword(String user, String password) {
+        this.user = user;
+        this.password = password;
+        return this;
+    }
+    public GitHubBuilder withOAuthToken(String oauthToken) {
+        return withOAuthToken(oauthToken, null);
+    }
+    public GitHubBuilder withOAuthToken(String oauthToken, String user) {
+        this.oauthToken = oauthToken;
+        this.user = user;
+        return this;
+    }
+    public GitHubBuilder withConnector(HttpConnector connector) {
+        this.connector = connector;
+        return this;
+    }
+
+    public GitHub build() throws IOException {
+        return new GitHub(endpoint, user, oauthToken, password, connector);
+    }
+}

src/test/java/org/kohsuke/github/GitHubTest.java

@@ -1,5 +1,12 @@
 package org.kohsuke.github;
 
+import java.io.IOException;
+import java.lang.reflect.Field;
+import java.util.Collections;
+import java.util.HashMap;
+import java.util.Map;
+import java.util.Properties;
+
 import junit.framework.TestCase;
 
 /**
@@ -21,4 +28,85 @@ public class GitHubTest extends TestCase {
         GitHub hub = GitHub.connectUsingPassword("kohsuke", "bogus");
         assertEquals("https://api.github.com/test", hub.getApiURL("/test").toString());
     }
+    
+    public void testGitHubBuilderFromEnvironment() throws IOException {
+    	
+    	Map<String, String>props = new HashMap<String, String>();
+    	
+    	props.put("login", "bogus");
+    	props.put("oauth", "bogus");
+    	props.put("password", "bogus");
+    	
+    	setupEnvironment(props);
+    	
+    	GitHubBuilder builder = GitHubBuilder.fromEnvironment();
+    	
+    	assertEquals("bogus", builder.user);
+    	assertEquals("bogus", builder.oauthToken);
+    	assertEquals("bogus", builder.password);
+    	
+    }
+    
+    /*
+     * Copied from StackOverflow: http://stackoverflow.com/a/7201825/2336755
+     * 
+     * This allows changing the in memory process environment.
+     * 
+     * Its used to wire in values for the github credentials to test that the GitHubBuilder works properly to resolve them.
+     */
+    private void setupEnvironment(Map<String, String> newenv) {
+    	  try
+    	    {
+    	        Class<?> processEnvironmentClass = Class.forName("java.lang.ProcessEnvironment");
+    	        Field theEnvironmentField = processEnvironmentClass.getDeclaredField("theEnvironment");
+    	        theEnvironmentField.setAccessible(true);
+    	        Map<String, String> env = (Map<String, String>) theEnvironmentField.get(null);
+    	        env.putAll(newenv);
+    	        Field theCaseInsensitiveEnvironmentField = processEnvironmentClass.getDeclaredField("theCaseInsensitiveEnvironment");
+    	        theCaseInsensitiveEnvironmentField.setAccessible(true);
+    	        Map<String, String> cienv = (Map<String, String>)     theCaseInsensitiveEnvironmentField.get(null);
+    	        cienv.putAll(newenv);
+    	    }
+    	    catch (NoSuchFieldException e)
+    	    {
+    	      try {
+    	        Class[] classes = Collections.class.getDeclaredClasses();
+    	        Map<String, String> env = System.getenv();
+    	        for(Class cl : classes) {
+    	            if("java.util.Collections$UnmodifiableMap".equals(cl.getName())) {
+    	                Field field = cl.getDeclaredField("m");
+    	                field.setAccessible(true);
+    	                Object obj = field.get(env);
+    	                Map<String, String> map = (Map<String, String>) obj;
+    	                map.clear();
+    	                map.putAll(newenv);
+    	            }
+    	        }
+    	      } catch (Exception e2) {
+    	        e2.printStackTrace();
+    	      }
+    	    } catch (Exception e1) {
+    	        e1.printStackTrace();
+    	    } 
+		
+	}
+
+	public void testGitHubBuilderFromCustomEnvironment() throws IOException {
+    	
+		Map<String, String>props = new HashMap<String, String>();
+    	
+    	props.put("customLogin", "bogusLogin");
+    	props.put("customOauth", "bogusOauth");
+    	props.put("customPassword", "bogusPassword");
+    	
+    	setupEnvironment(props);
+    	
+    	GitHubBuilder builder = GitHubBuilder.fromEnvironment("customLogin", "customPassword", "customOauth");
+    	
+    	assertEquals("bogusLogin", builder.user);
+    	assertEquals("bogusOauth", builder.oauthToken);
+    	assertEquals("bogusPassword", builder.password);
+    	
+    }
+    
 }

src/test/java/org/kohsuke/github/PullRequestTest.java

@@ -1,18 +1,51 @@
 package org.kohsuke.github;
 
+import org.junit.After;
 import org.junit.Test;
 
+import java.io.IOException;
+import java.util.Collection;
+
 /**
  * @author Kohsuke Kawaguchi
  */
 public class PullRequestTest extends AbstractGitHubApiTestBase {
     @Test
     public void createPullRequest() throws Exception {
-        GHRepository j = gitHub.getOrganization("github-api-test-org").getRepository("jenkins");
         String name = rnd.next();
-        GHPullRequest p = j.createPullRequest(name, "stable", "master", "## test");
+        GHPullRequest p = getRepository().createPullRequest(name, "stable", "master", "## test");
         System.out.println(p.getUrl());
         assertEquals(name, p.getTitle());
-        p.close();
+    }
+
+    @Test // Requires push access to the test repo to pass
+    public void setLabels() throws Exception {
+        GHPullRequest p = getRepository().createPullRequest(rnd.next(), "stable", "master", "## test");
+        String label = rnd.next();
+        p.setLabels(label);
+
+        Collection<GHIssue.Label> labels = getRepository().getPullRequest(p.getNumber()).getLabels();
+        assertEquals(1, labels.size());
+        assertEquals(label, labels.iterator().next().getName());
+    }
+
+    @Test // Requires push access to the test repo to pass
+    public void setAssignee() throws Exception {
+        GHPullRequest p = getRepository().createPullRequest(rnd.next(), "stable", "master", "## test");
+        GHMyself user = gitHub.getMyself();
+        p.assignTo(user);
+
+        assertEquals(user, getRepository().getPullRequest(p.getNumber()).getAssignee());
+    }
+
+    @After
+    public void cleanUp() throws Exception {
+        for (GHPullRequest pr : getRepository().getPullRequests(GHIssueState.OPEN)) {
+            pr.close();
+        }
+    }
+
+    private GHRepository getRepository() throws IOException {
+        return gitHub.getOrganization("github-api-test-org").getRepository("jenkins");
     }
 }