mirror of
https://github.com/jlengrand/github-api.git
synced 2026-04-27 08:21:23 +00:00
Allow pullRequest.getHead().getRepository().getCommit(headSha1) to work
The wrong .wrap method was used for pull requests initialized by state
(GHRepository.getPullReqests).
The wrong wrap call was introduced in 9fd34aec7f
This commit sets it back to the .wrapUp method which makes sure the pull request
substructure has the repo object set properly.
Without this change a NullPointerException is thrown on the last line of this
code because the repo object inside of the remoteRepository object is null:
GHRepository repo = github.getRepository(targetRepository);
List<GHPullRequest> openPullRequests = repo.getPullRequests(GHIssueState.OPEN);
for (GHPullRequest pullRequest : openPullRequests) {
GHCommitPointer head = pullRequest.getHead();
GHRepository remoteRepository = head.getRepository();
String commitId = head.getSha();
GHCommit headCommit = remoteRepository.getCommit(commitId);
This commit is contained in:
@@ -514,7 +514,7 @@ public class GHRepository {
|
||||
@Override
|
||||
protected void wrapUp(GHPullRequest[] page) {
|
||||
for (GHPullRequest pr : page)
|
||||
pr.wrap(GHRepository.this);
|
||||
pr.wrapUp(GHRepository.this);
|
||||
}
|
||||
};
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user