Liam Newman
d526b13d7d
Apply suggestions from code review
...
Co-authored-by: Guillaume Smet <guillaume.smet@gmail.com >
2021-04-28 13:33:13 -07:00
Liam Newman
fffe31220e
Make apache commons restrictions more accurate and legible
2021-04-27 15:19:46 -07:00
Liam Newman
ce17396ea6
Merge branch 'main' into upgrade-commons-io
2021-04-27 02:33:44 -07:00
Liam Newman
d18e81dc74
More informative message
2021-04-26 21:13:09 -07:00
Liam Newman
6ae5acba5d
Fix typo
2021-04-26 21:08:59 -07:00
Liam Newman
0a1c803f69
Test for approved Apache commons methods
...
This is an inaccurate way of verifying that we are calling only methods that are
compatible with older versions of commons, but it should be sufficient to deter
usage without careful consideration.
2021-04-26 20:39:27 -07:00
Liam Newman
fa0865b208
Fix assertThat arch test
2021-04-26 14:27:28 -07:00
Liam Newman
886887913c
Merge pull request #1126 from akashRindhe/refactor/1099
...
(refactor) Replace complex parsing logic from GHEvent.type to GHEvent with static mapping
2021-04-21 23:53:10 -07:00
Liam Newman
5c64fec032
Streamline with EnumUtils
2021-04-21 16:57:37 -07:00
Liam Newman
892f60ea16
[maven-release-plugin] prepare for next development iteration
2021-04-21 11:05:58 -07:00
Liam Newman
f28f966040
[maven-release-plugin] prepare release github-api-1.128
github-api-1.128
2021-04-21 11:05:43 -07:00
Liam Newman
0e9cc90d31
Merge pull request #1125 from gsmet/remove-jdk-16-workaround
...
Remove now unnecessary JDK 16 specific workaround
2021-04-21 08:11:51 -07:00
Akash Rindhe
72dc5c5d18
(refactor) Replace complex parsing logic from GHEvent.type to GHEvent with static mapping
...
[https://github.com/hub4j/github-api/issues/1099 ]
2021-04-21 20:07:10 +08:00
Guillaume Smet
02e02d39b0
Remove now unnecessary JDK 16 specific workaround
...
Now that we are not using reflection anymore to push unsupported HTTP
methods, we can remove this workaround.
2021-04-21 13:29:33 +02:00
Alexander Kjäll
e629a23bd4
upgrade commons-io due to CVE-2021-29425, it's a vulnerability in FileNameUtils.normalize that isn't used in this project
2021-04-21 11:37:38 +02:00
Liam Newman
f6e8a2c7c6
Merge pull request #1123 from bitwiseman/task/assertThat
...
Move to using assertThat() exclusively
2021-04-20 13:59:24 -07:00
Liam Newman
76bea5174f
Merge branch 'main' into task/assertThat
2021-04-20 13:43:04 -07:00
Liam Newman
2be27d1a41
Update maven-build.yml
2021-04-20 13:42:48 -07:00
Liam Newman
cd1454ac03
More assertThat matchers
2021-04-20 12:34:01 -07:00
Liam Newman
b550910f4c
Streamline assertThat calls using appropriate matchers
2021-04-20 12:16:55 -07:00
Liam Newman
d13e490be2
Enforce use of assertThat
...
Assert.assert* methods other than assertThat() produce less clear tests.
This change enforces using assertThat() for all verifications.
While more verbose they are generally more consistent and easier to understand.
2021-04-20 00:46:43 -07:00
Liam Newman
3d451526ef
Deprecate all asserts other than assertThat
2021-04-19 19:09:47 -07:00
Liam Newman
bd38897d48
Do not inherit from Assert
2021-04-19 15:58:33 -07:00
Liam Newman
63ccbaf064
Merge pull request #1116 from hub4j/dependabot/maven/spotbugs.version-4.2.3
...
Chore(deps): Bump spotbugs.version from 4.2.2 to 4.2.3
2021-04-19 13:44:18 -07:00
Liam Newman
2beb806b8a
Merge pull request #1120 from hub4j/dependabot/maven/com.fasterxml.jackson.core-jackson-databind-2.12.3
...
Chore(deps): Bump jackson-databind from 2.12.1 to 2.12.3
2021-04-19 13:44:02 -07:00
dependabot[bot]
552ba6693e
Chore(deps): Bump spotbugs.version from 4.2.2 to 4.2.3
...
Bumps `spotbugs.version` from 4.2.2 to 4.2.3.
Updates `spotbugs` from 4.2.2 to 4.2.3
- [Release notes](https://github.com/spotbugs/spotbugs/releases )
- [Changelog](https://github.com/spotbugs/spotbugs/blob/master/CHANGELOG.md )
- [Commits](https://github.com/spotbugs/spotbugs/compare/4.2.2...4.2.3 )
Updates `spotbugs-annotations` from 4.2.2 to 4.2.3
- [Release notes](https://github.com/spotbugs/spotbugs/releases )
- [Changelog](https://github.com/spotbugs/spotbugs/blob/master/CHANGELOG.md )
- [Commits](https://github.com/spotbugs/spotbugs/compare/4.2.2...4.2.3 )
Signed-off-by: dependabot[bot] <support@github.com >
2021-04-19 20:42:57 +00:00
dependabot[bot]
2452add4d7
Chore(deps): Bump jackson-databind from 2.12.1 to 2.12.3
...
Bumps [jackson-databind](https://github.com/FasterXML/jackson ) from 2.12.1 to 2.12.3.
- [Release notes](https://github.com/FasterXML/jackson/releases )
- [Commits](https://github.com/FasterXML/jackson/commits )
Signed-off-by: dependabot[bot] <support@github.com >
2021-04-19 20:42:56 +00:00
Liam Newman
0dc931ceed
Merge pull request #1115 from hub4j/dependabot/github_actions/actions/cache-v2.1.5
...
Chore(deps): Bump actions/cache from v2.1.4 to v2.1.5
2021-04-19 13:42:48 -07:00
Liam Newman
1dfedc6a58
Merge pull request #1117 from hub4j/dependabot/maven/com.diffplug.spotless-spotless-maven-plugin-2.10.1
...
Chore(deps): Bump spotless-maven-plugin from 2.9.0 to 2.10.1
2021-04-19 13:42:32 -07:00
dependabot[bot]
e33046a624
Chore(deps): Bump actions/cache from v2.1.4 to v2.1.5
...
Bumps [actions/cache](https://github.com/actions/cache ) from v2.1.4 to v2.1.5.
- [Release notes](https://github.com/actions/cache/releases )
- [Commits](https://github.com/actions/cache/compare/v2.1.4...1a9e2138d905efd099035b49d8b7a3888c653ca8 )
Signed-off-by: dependabot[bot] <support@github.com >
2021-04-19 20:42:30 +00:00
dependabot[bot]
002b3f03da
Chore(deps): Bump spotless-maven-plugin from 2.9.0 to 2.10.1
...
Bumps [spotless-maven-plugin](https://github.com/diffplug/project ) from 2.9.0 to 2.10.1.
- [Release notes](https://github.com/diffplug/project/releases )
- [Commits](https://github.com/diffplug/project/commits )
Signed-off-by: dependabot[bot] <support@github.com >
2021-04-19 20:42:26 +00:00
Liam Newman
fd1817d111
Merge pull request #1122 from hub4j/dependabot/maven/org.mockito-mockito-core-3.9.0
...
Chore(deps-dev): Bump mockito-core from 3.8.0 to 3.9.0
2021-04-19 13:42:20 -07:00
Liam Newman
7526b46f9d
Merge pull request #1121 from hub4j/dependabot/maven/org.kohsuke.stapler-stapler-1.263
...
Chore(deps-dev): Bump stapler from 1.262 to 1.263
2021-04-19 13:42:07 -07:00
dependabot[bot]
169fd18a54
Chore(deps-dev): Bump mockito-core from 3.8.0 to 3.9.0
...
Bumps [mockito-core](https://github.com/mockito/mockito ) from 3.8.0 to 3.9.0.
- [Release notes](https://github.com/mockito/mockito/releases )
- [Commits](https://github.com/mockito/mockito/compare/v3.8.0...v3.9.0 )
Signed-off-by: dependabot[bot] <support@github.com >
2021-04-19 20:41:49 +00:00
Liam Newman
0708812456
Merge pull request #1113 from hub4j/dependabot/maven/com.github.spotbugs-spotbugs-maven-plugin-4.2.3
...
Chore(deps): Bump spotbugs-maven-plugin from 4.2.0 to 4.2.3
2021-04-19 13:41:26 -07:00
dependabot[bot]
7d86070ac8
Chore(deps-dev): Bump stapler from 1.262 to 1.263
...
Bumps [stapler](https://github.com/stapler/stapler ) from 1.262 to 1.263.
- [Release notes](https://github.com/stapler/stapler/releases )
- [Changelog](https://github.com/stapler/stapler/blob/master/CHANGELOG.md )
- [Commits](https://github.com/stapler/stapler/compare/stapler-parent-1.262...stapler-parent-1.263 )
Signed-off-by: dependabot[bot] <support@github.com >
2021-04-19 20:41:24 +00:00
dependabot[bot]
713b85f9de
Chore(deps): Bump spotbugs-maven-plugin from 4.2.0 to 4.2.3
...
Bumps [spotbugs-maven-plugin](https://github.com/spotbugs/spotbugs-maven-plugin ) from 4.2.0 to 4.2.3.
- [Release notes](https://github.com/spotbugs/spotbugs-maven-plugin/releases )
- [Commits](https://github.com/spotbugs/spotbugs-maven-plugin/compare/spotbugs-maven-plugin-4.2.0...spotbugs-maven-plugin-4.2.3 )
Signed-off-by: dependabot[bot] <support@github.com >
2021-04-19 20:41:20 +00:00
Liam Newman
4fef5bb1fc
Merge pull request #1112 from hub4j/dependabot/github_actions/codecov/codecov-action-v1.4.0
...
Chore(deps): Bump codecov/codecov-action from v1.3.2 to v1.4.0
2021-04-19 13:41:14 -07:00
Liam Newman
f3eadcddb6
Merge pull request #1111 from hub4j/dependabot/maven/com.tngtech.archunit-archunit-0.18.0
...
Chore(deps-dev): Bump archunit from 0.17.0 to 0.18.0
2021-04-19 13:41:02 -07:00
Liam Newman
237171727d
Merge pull request #1118 from hub4j/dependabot/maven/org.kohsuke-wordnet-random-name-1.5
...
Chore(deps-dev): Bump wordnet-random-name from 1.3 to 1.5
2021-04-19 13:40:40 -07:00
Liam Newman
31212d33ae
Merge pull request #1119 from bitwiseman/task/main
...
Switch to 'main' as default branch
2021-04-19 13:40:13 -07:00
Liam Newman
8af66133d2
Switch to 'main' as default branch
2021-04-19 13:27:44 -07:00
dependabot[bot]
9578e027b1
Chore(deps-dev): Bump wordnet-random-name from 1.3 to 1.5
...
Bumps [wordnet-random-name](https://github.com/kohsuke/wordnet-random-name ) from 1.3 to 1.5.
- [Release notes](https://github.com/kohsuke/wordnet-random-name/releases )
- [Commits](https://github.com/kohsuke/wordnet-random-name/compare/wordnet-random-name-1.3...wordnet-random-name-1.5 )
Signed-off-by: dependabot[bot] <support@github.com >
2021-04-19 20:10:36 +00:00
dependabot[bot]
2c75b42b4e
Chore(deps): Bump codecov/codecov-action from v1.3.2 to v1.4.0
...
Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action ) from v1.3.2 to v1.4.0.
- [Release notes](https://github.com/codecov/codecov-action/releases )
- [Changelog](https://github.com/codecov/codecov-action/blob/master/CHANGELOG.md )
- [Commits](https://github.com/codecov/codecov-action/compare/v1.3.2...0e28ff86a50029a44d10df6ed4c308711925a6a8 )
Signed-off-by: dependabot[bot] <support@github.com >
2021-04-19 20:10:13 +00:00
dependabot[bot]
7854b30a76
Chore(deps-dev): Bump archunit from 0.17.0 to 0.18.0
...
Bumps [archunit](https://github.com/TNG/ArchUnit ) from 0.17.0 to 0.18.0.
- [Release notes](https://github.com/TNG/ArchUnit/releases )
- [Commits](https://github.com/TNG/ArchUnit/compare/v0.17.0...v0.18.0 )
Signed-off-by: dependabot[bot] <support@github.com >
2021-04-19 20:10:09 +00:00
Liam Newman
cf2571858c
Merge pull request #1107 from akashRindhe/feat/1076
...
(refactor) Rename gitHubBeforeAfter to nonRecordingGitHub #1076
2021-04-19 10:08:35 -07:00
Akash Rindhe
092815747a
(refactor) Rename gitHubBeforeAfter to nonRecordingGitHub #1076
...
[#1076 ]
2021-04-18 18:41:10 +08:00
Liam Newman
649d7ed87f
Merge pull request #1106 from bitwiseman/issue/1103
...
GHRepository#listLanguages returns correct Map type
2021-04-16 16:04:57 -07:00
Liam Newman
684560ef67
GHRepository#listLanguages returns correct Map type
...
This is a less than perfect solution, but it is sufficient to solve the current issue
without risking further side-effects.
Fixes #1103
2021-04-16 14:25:28 -07:00
Liam Newman
adf054ba5d
Merge pull request #1105 from akashRindhe/feature/1050
...
GHIssue.addLabels and removeLabels() should return List<GHLabel> not void [#1050 ]
2021-04-16 13:10:04 -07:00