Liam Newman
392dc2a040
Merge remote-tracking branch 'github-api/master' into BranchMissing
2019-11-15 15:36:24 -08:00
Liam Newman
da11702f68
Modify formatting to columnize
...
Turns out I do care about formatting a little. We have a lot of builders and chained methods.
I think it is easier to follow long chains when lined up veritcally.
2019-11-15 15:18:07 -08:00
Liam Newman
f262bf7cdb
Commit default format
2019-11-15 13:49:32 -08:00
Alex Taylor
78ab5ad156
Changed Exception Type
...
Changed Exception type and added a comment
2019-11-15 14:55:50 -05:00
Alex Taylor
6af796fc3b
Adjusted format
...
Adjusted format according to standard from repo
2019-11-15 14:35:32 -05:00
Liam Newman
c174be37b3
Merge pull request #614 from bitwiseman/task/requester-cleanup
...
Clean up Requester interface a bit
2019-11-15 08:40:45 -08:00
Alex Taylor
18aa067c44
Merge branch 'master' into BranchMissing
2019-11-15 10:59:15 -05:00
Alex Taylor
8d50b338f4
Added GHBranch creator
...
Added GHBranch creator and added a test to make sure it works
2019-11-15 10:54:32 -05:00
Liam Newman
37d7cfaaf2
Clean up Requester interface a bit
2019-11-14 18:16:56 -08:00
Liam Newman
d3564a9a4f
Merge pull request #613 from bitwiseman/javadoc-warning
...
Javadoc fail on warning during CI build
2019-11-14 15:53:50 -08:00
Liam Newman
39d6dd9916
Update PULL_REQUEST_TEMPLATE.md
2019-11-14 13:36:33 -08:00
Liam Newman
0152ebf062
Enable failOnWarning for JavaDoc
...
Continuing to ratchet up some base level code quality
2019-11-14 13:33:33 -08:00
Liam Newman
757b9b2118
Add JavaDocs
...
Do using IntelliJ JavaDocs plugin. Better to have something than nothing.
2019-11-14 13:24:28 -08:00
Liam Newman
f6a01551fd
Make PagedIterableWithConsumer package local for mocking
2019-11-14 13:15:34 -08:00
Liam Newman
1f619f3801
Merge pull request #611 from PauloMigAlmeida/master
...
Implement Meta endpoint
2019-11-14 13:06:43 -08:00
Liam Newman
fd436cf5b2
Fixes for build failures
2019-11-14 13:01:35 -08:00
Liam Newman
7e05ce38cf
Add examples of different ways to create data objects
2019-11-14 12:39:40 -08:00
Liam Newman
7d1e977ffe
Make GHMeta fields effectively final
2019-11-14 12:39:04 -08:00
Liam Newman
6c2ce83b45
Make GHMeta fields not externally settable
2019-11-14 10:29:40 -08:00
Liam Newman
d5ba0eebcb
Run code formatting
2019-11-14 09:12:28 -08:00
Liam Newman
432585cb75
Merge remote-tracking branch 'github-api/master' into ghmeta
2019-11-14 09:05:20 -08:00
Liam Newman
e41a341ce6
Merge pull request #609 from bitwiseman/task/style
...
Code style fixes
2019-11-14 08:47:47 -08:00
PauloMigAlmeida
6aad80904a
Implement Meta endpoint
...
Signed-off-by: PauloMigAlmeida <paulo.miguel.almeida.rodenas@gmail.com >
2019-11-14 15:52:43 +13:00
Liam Newman
20e796cef4
Create PULL_REQUEST_TEMPLATE.md
2019-11-13 15:47:55 -08:00
Liam Newman
a3b126282d
Remove package comments
2019-11-13 15:20:02 -08:00
Liam Newman
5f597379b5
JavaDoc warning fixes
2019-11-13 14:53:42 -08:00
Liam Newman
9d8460bb81
Enable automatic code formatter with CI validation
...
This may be controversial but it we're doing it. Having code formatting needs to be consistent
and a non-issue during code review. I'm willing modify the configuration if people see a strong
need, but formatting needs to be present and enforced.
2019-11-13 13:28:23 -08:00
Liam Newman
8943af9840
Cleanup tabs and whitespace
2019-11-13 12:47:19 -08:00
Liam Newman
d23c718036
Merge pull request #603 from madhephaestus/master
...
Add Functionality of OTP to support user 2fa
2019-11-13 12:43:23 -08:00
Alex Taylor
834c84c9ea
Added the test for Issue #607
...
Added a test so that we can prove when this issue is fixed
2019-11-13 15:07:06 -05:00
Liam Newman
adc436a3f5
Update issue templates
2019-11-13 09:48:25 -08:00
Kevin Harrington
e325bf7771
fixed for the sensitive javadoc parser
2019-11-13 00:38:51 -05:00
Kevin Harrington
feabd07a21
adding javadoc
2019-11-13 00:28:18 -05:00
Kevin Harrington
e138c6fd61
Switch interface to existing Supplier class
2019-11-13 00:26:20 -05:00
Kevin Harrington
d32299fde5
add testing of scopes in assigned token
2019-11-13 00:23:38 -05:00
Kevin Harrington
3d7d780e8f
only run test with moc date
2019-11-13 00:19:06 -05:00
Kevin Harrington
9f49854033
Comments for the path of OTP exception
2019-11-13 00:17:57 -05:00
Kevin Harrington
1fe820d463
instructions for reproducing the test data
2019-11-12 18:15:08 -05:00
Kevin Harrington
4a78690fde
Remove old function prototype and replace it with the lambda model.
2019-11-12 18:10:05 -05:00
Kevin Harrington
3dcaf5a9de
Unit test passing with Mock data
2019-11-12 18:05:39 -05:00
Kevin Harrington
ff788852d6
added the filter to the test to only run with mock data
2019-11-12 17:58:21 -05:00
Kevin Harrington
5ae062719e
re-run the data capture with the overloaded function
2019-11-12 17:56:25 -05:00
Kevin Harrington
421c0a11fb
Implement @PauloMigAlmeida suggested lambda style OTP workflow
2019-11-12 17:32:24 -05:00
Kevin Harrington
6ae586aeb7
Creating a receiver lambda for the PTM functionality
2019-11-12 17:28:23 -05:00
Liam Newman
7036423084
Merge pull request #595 from bitwiseman/issue/rate-limit
...
Adjust GHRateLimit to system time instead of depending on synchronization
2019-11-12 13:01:58 -08:00
Kevin Harrington
2f118a9cbe
Adding suggested exception from @PauloMigAlmeida
...
When the OTP code is requested, then the special GHOTPRequiredException
is raised instead of the generic IOException. This differentiates
between an OTP request and a failed password.
2019-11-12 15:44:45 -05:00
Kevin Harrington
2c50255b21
renaming
2019-11-12 15:35:55 -05:00
harrington
8cb7210c46
set the timestamp in the token name to match the test data
2019-11-12 15:01:14 -05:00
harrington
ad0a24ad2f
Make sure test is only run with stored mock data
2019-11-12 14:54:38 -05:00
harrington
df6c951830
Unit test passing with OTP data
2019-11-12 14:53:14 -05:00
