Kohsuke Kawaguchi
188245fa7f
[maven-release-plugin] prepare release github-api-1.91
2018-01-13 10:36:45 -08:00
Kohsuke Kawaguchi
e10b747d6a
Re-retried the object.
...
It looks like the format has changed a bit since this payload was
retrieved originally?
2018-01-13 10:30:48 -08:00
Kohsuke Kawaguchi
f2bb6a05a5
Merge pull request #384
2018-01-13 10:19:12 -08:00
Kohsuke Kawaguchi
f41da19db5
Further restoration of the compatibility
2018-01-13 09:54:14 -08:00
Kohsuke Kawaguchi
d0a56dbb21
Merge pull request #406
...
... with some further changes
2018-01-13 09:47:37 -08:00
Kohsuke Kawaguchi
acbf286e59
Massaged the changes
...
- Restored binary compatibility. The draft API has changed in some
significant way when it became public, and the PR took the liberty to
delete removed constants and method signatures. I brought them back so
that older clients can keep functioning.
- Introduced a builder pattern to create PR review
- replying to a review comment should be an instance method, not a
static method.
- GHPullRequestReview and GHPullRequestReviewDraft was not making sense
to me, since GitHub API doesn't differentiate them. It creates a
practical problem of not being able to submit a review comment unless
you created the review comment in the same JVM session. That said, I
don't understand the point of this two phase approach in the GitHub
API to begin with!
2018-01-13 09:43:44 -08:00
Kohsuke Kawaguchi
0f7c160409
Based on issue #399 , adjusting the behaviour.
...
This ends up changing the behaviour cloes to that of #394 .
2018-01-12 21:33:03 -08:00
Kohsuke Kawaguchi
5113aacb89
Issue #403 : Typo in method name
2018-01-12 21:28:37 -08:00
Kohsuke Kawaguchi
4e31636181
Allow the caller to wait for the mergeable state to change.
...
This approaches #394 differently. The problem with the original #394 is
that the supposed behaviour is only useful for people waiting for
`getMergeable()` to return non-null in a busy loop, yet it impacts all
the other methods of this object.
2018-01-12 21:25:30 -08:00
Kohsuke Kawaguchi
1e497d2c44
Merge branch 'master' into bridge-method-annotation
2018-01-12 21:13:49 -08:00
Kohsuke Kawaguchi
70bd4fa161
Merge pull request #379
2018-01-12 21:12:48 -08:00
Kohsuke Kawaguchi
65996050d5
Massaged changes to follow the convention
2018-01-12 21:12:40 -08:00
Kohsuke Kawaguchi
7f52031199
Merge branch 'master' of github.com:kohsuke/github-api
2018-01-12 21:07:11 -08:00
Kohsuke Kawaguchi
5430f3d33c
Merge pull request #391
2018-01-12 21:06:55 -08:00
Kohsuke Kawaguchi
43075faaf8
By convention we use "listXyz" method names
2018-01-12 21:06:47 -08:00
Kohsuke Kawaguchi
f3a1272e31
Merge pull request #397 from mizoguche/set-milestone
...
Add GHIssue#setMilestone
2018-01-12 21:04:18 -08:00
Kohsuke Kawaguchi
41c028d4d9
Merge pull request #401
2018-01-12 21:00:56 -08:00
Kohsuke Kawaguchi
a17ce04552
Adjustment to compensate
2018-01-12 21:00:25 -08:00
Björn Häuser
d0b4652dcd
Replace "new Error" with GHException
...
(rolled back some of the hunks from the original PR)
2018-01-12 19:44:25 -08:00
Kohsuke Kawaguchi
e66f71c76e
Merge pull request #407 from notsudo/GHCreateRepositoryBuilder_Add_Merge_Settings
...
Adding merge settings to GHCreateRepositoryBuilder
2018-01-12 19:39:03 -08:00
Kohsuke Kawaguchi
6effd4b846
Merge pull request #396 from Rechi/fixGHPersonNullPointer
...
[fix] GHPerson: check if root is null
2018-01-12 08:45:02 -08:00
Timothy McNally
df861f5403
Adding methods to GHCreateRepositoryBuilder to allow setting the allowed merge methods for pull requests.
2018-01-09 17:32:54 -08:00
Sébastien Lesaint
e74346fed6
support create PR review in single API call & remove @Preview
2018-01-09 14:13:25 +01:00
Sébastien Lesaint
6961c467a6
create review comment reply from GHPullRequest
2018-01-09 14:13:25 +01:00
Sébastien Lesaint
892d305165
add Requester#with override for long value
2018-01-09 14:13:25 +01:00
Sébastien Lesaint
fa16261d7a
position of pr comment can be null and original_position is not parsed
...
position of pr comment is null when comment is outdated (ie. not located in diff patch anymore)
2018-01-09 14:13:25 +01:00
Sébastien Lesaint
15991fd2f7
PullRequest review state and event do not have same values
...
this fixes parsing of response of WS call submitting a review to fail
when event of new review is REQUEST_CHANGES
also, specifying event when creating a pending PR review is useless and
providing it when submitting the review is enough
2018-01-09 14:13:25 +01:00
Michiaki Mizoguchi
c80b8f60f8
Add GHIssue#setMilestone
2017-11-16 12:42:52 +09:00
Rechi
ab6253cbd0
[fix] GHPerson: check if root is null
2017-11-09 22:41:49 +01:00
sg012265
35ba267115
Revert wildcard usage for imports
2017-10-30 15:38:19 -05:00
sg012265
ab24e6e1c1
Add get for all orgs
2017-10-30 15:32:25 -05:00
Kohsuke Kawaguchi
e25ae27a15
[maven-release-plugin] prepare for next development iteration
2017-10-28 15:54:44 -07:00
Kohsuke Kawaguchi
2b7c524908
[maven-release-plugin] prepare release github-api-1.90
2017-10-28 15:54:33 -07:00
Kohsuke Kawaguchi
0b069df9ce
Pick up the version that fixes int->long adaption
2017-10-28 15:48:26 -07:00
Kohsuke Kawaguchi
60c9ba88ae
Updated tests
2017-10-28 15:27:38 -07:00
Kohsuke Kawaguchi
cc2e60c84a
Merge pull request #388
2017-10-28 09:01:01 -07:00
Kohsuke Kawaguchi
83c2c4e92e
Fixed the broken design of how GHDeploymentStatus get exposed.
2017-10-28 08:59:41 -07:00
Kohsuke Kawaguchi
ab3d9e82ef
A little better version of the bridge method
2017-10-28 08:43:48 -07:00
Kohsuke Kawaguchi
b6063dd534
Restored binary compatibility
2017-10-28 08:42:27 -07:00
Kohsuke Kawaguchi
e6754354e4
Merge pull request #389
2017-10-28 07:54:47 -07:00
Kohsuke Kawaguchi
4849619d67
None of the connectToEnterprise methods are preferrable so document accordingly
2017-10-28 07:54:41 -07:00
Kohsuke Kawaguchi
9b0ace242a
Merge pull request #390
2017-10-28 07:45:14 -07:00
Kohsuke Kawaguchi
e94ba74058
Convention is to call these methods setXyz. Plus doc
2017-10-28 07:44:23 -07:00
Baptiste Mathus
569fa06d2d
Labels: add method to update color
2017-10-25 14:06:28 +02:00
iraleigh
46dce17abc
Fixed Typo
2017-10-24 14:53:23 -07:00
iraleigh
40d8f4a352
Fixed OAuth connection to enterprise API
2017-10-24 14:24:25 -07:00
Arne Burmeister
6415785220
boyscout: updated dependencies
2017-10-23 17:05:31 +02:00
Arne Burmeister
7735edeae8
extend id from int to long
2017-10-23 17:05:02 +02:00
Matt Nelson
0f81d1dbb3
Add support for pr review/review comment events
2017-10-05 18:14:15 -05:00
Anton Zagorskii
ae1ec8b558
Roles for team members
2017-09-20 13:22:30 +01:00
