jlengrand/error-prone-support
1
0
Fork 0
mirror of https://github.com/jlengrand/error-prone-support.git synced 2026-03-10 08:11:25 +00:00
Code Issues Packages Projects Releases Wiki Activity

Drop workaround for resolved Refaster bug (#974)

Browse Source 
Issue google/error-prone#2456 was fixed in Error Prone 2.22.0.
This commit is contained in:
Stephan Schroevers
2024-01-13 20:43:01 +01:00
committed by GitHub
parent b8eabff9bc
commit d126336742
1 changed files with 2 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
refaster-runner/src/main/java/tech/picnic/errorprone/refaster/runner/Refaster.java
View File

@@ -88,16 +88,8 @@ public final class Refaster extends BugChecker implements CompilationUnitTreeMat
public Description matchCompilationUnit(CompilationUnitTree tree, VisitorState state) {
/* First, collect all matches. */
List<Description> matches = new ArrayList<>();
try {
codeTransformer.apply(state.getPath(), new SubContext(state.context), matches::add);
} catch (LinkageError e) {
// XXX: This `try/catch` block handles the issue described and resolved in
// https://github.com/google/error-prone/pull/2456. Drop this block once that change is
// released.
// XXX: Find a way to identify that we're running Picnic's Error Prone fork and disable this
// fallback if so, as it might hide other bugs.
return Description.NO_MATCH;
}
codeTransformer.apply(state.getPath(), new SubContext(state.context), matches::add);
/* Then apply them. */
applyMatches(matches, ((JCCompilationUnit) tree).endPositions, state);