jlengrand/error-prone-support
1
0
Fork 0
mirror of https://github.com/jlengrand/error-prone-support.git synced 2026-03-10 08:11:25 +00:00
Code Issues Packages Projects Releases Wiki Activity

Have ReverseOrder rule flag Collections.reverseOrder(String::compareTo)

Browse Source
This commit is contained in:
Rick Ossendrijver
2022-12-08 09:00:50 +01:00
parent b1c815770b
commit cf38b37c8c
3 changed files with 6 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
error-prone-contrib/src/main/java/tech/picnic/errorprone/refasterrules/ComparatorRules.java
View File

@@ -58,6 +58,7 @@ final class ComparatorRules {
Comparator<T> before() { Comparator<T> before() {
return Refaster.anyOf( return Refaster.anyOf(
Collections.reverseOrder(), Collections.reverseOrder(),
Collections.reverseOrder(T::compareTo),
Collections.<T>reverseOrder(naturalOrder()), Collections.<T>reverseOrder(naturalOrder()),
Comparator.<T>naturalOrder().reversed()); Comparator.<T>naturalOrder().reversed());
} }

1
error-prone-contrib/src/test/resources/tech/picnic/errorprone/refasterrules/ComparatorRulesTestInput.java
View File

@@ -38,6 +38,7 @@ final class ComparatorRulesTest implements RefasterRuleCollectionTestCase {
ImmutableSet<Comparator<String>> testReverseOrder() { ImmutableSet<Comparator<String>> testReverseOrder() {
return ImmutableSet.of( return ImmutableSet.of(
Collections.reverseOrder(), Collections.reverseOrder(),
Collections.reverseOrder(String::compareTo),
Collections.<String>reverseOrder(naturalOrder()), Collections.<String>reverseOrder(naturalOrder()),
Comparator.<String>naturalOrder().reversed()); Comparator.<String>naturalOrder().reversed());
} }

5
error-prone-contrib/src/test/resources/tech/picnic/errorprone/refasterrules/ComparatorRulesTestOutput.java
View File

@@ -33,7 +33,10 @@ final class ComparatorRulesTest implements RefasterRuleCollectionTestCase {
ImmutableSet<Comparator<String>> testReverseOrder() { ImmutableSet<Comparator<String>> testReverseOrder() {
return ImmutableSet.of( return ImmutableSet.of(
Comparator.reverseOrder(), Comparator.reverseOrder(), Comparator.reverseOrder()); Comparator.reverseOrder(),
Comparator.reverseOrder(),
Comparator.reverseOrder(),
Comparator.reverseOrder());
} }
ImmutableSet<Comparator<String>> testCustomComparator() { ImmutableSet<Comparator<String>> testCustomComparator() {