diff --git a/error-prone-contrib/src/main/java/tech/picnic/errorprone/refasterrules/ComparatorRules.java b/error-prone-contrib/src/main/java/tech/picnic/errorprone/refasterrules/ComparatorRules.java index c15b466a..e6de2697 100644 --- a/error-prone-contrib/src/main/java/tech/picnic/errorprone/refasterrules/ComparatorRules.java +++ b/error-prone-contrib/src/main/java/tech/picnic/errorprone/refasterrules/ComparatorRules.java @@ -58,6 +58,7 @@ final class ComparatorRules { Comparator before() { return Refaster.anyOf( Collections.reverseOrder(), + Collections.reverseOrder(T::compareTo), Collections.reverseOrder(naturalOrder()), Comparator.naturalOrder().reversed()); } diff --git a/error-prone-contrib/src/test/resources/tech/picnic/errorprone/refasterrules/ComparatorRulesTestInput.java b/error-prone-contrib/src/test/resources/tech/picnic/errorprone/refasterrules/ComparatorRulesTestInput.java index 8fde9018..e8329f08 100644 --- a/error-prone-contrib/src/test/resources/tech/picnic/errorprone/refasterrules/ComparatorRulesTestInput.java +++ b/error-prone-contrib/src/test/resources/tech/picnic/errorprone/refasterrules/ComparatorRulesTestInput.java @@ -38,6 +38,7 @@ final class ComparatorRulesTest implements RefasterRuleCollectionTestCase { ImmutableSet> testReverseOrder() { return ImmutableSet.of( Collections.reverseOrder(), + Collections.reverseOrder(String::compareTo), Collections.reverseOrder(naturalOrder()), Comparator.naturalOrder().reversed()); } diff --git a/error-prone-contrib/src/test/resources/tech/picnic/errorprone/refasterrules/ComparatorRulesTestOutput.java b/error-prone-contrib/src/test/resources/tech/picnic/errorprone/refasterrules/ComparatorRulesTestOutput.java index 9c27527d..72a83b34 100644 --- a/error-prone-contrib/src/test/resources/tech/picnic/errorprone/refasterrules/ComparatorRulesTestOutput.java +++ b/error-prone-contrib/src/test/resources/tech/picnic/errorprone/refasterrules/ComparatorRulesTestOutput.java @@ -33,7 +33,10 @@ final class ComparatorRulesTest implements RefasterRuleCollectionTestCase { ImmutableSet> testReverseOrder() { return ImmutableSet.of( - Comparator.reverseOrder(), Comparator.reverseOrder(), Comparator.reverseOrder()); + Comparator.reverseOrder(), + Comparator.reverseOrder(), + Comparator.reverseOrder(), + Comparator.reverseOrder()); } ImmutableSet> testCustomComparator() {