jlengrand/error-prone-support
1
0
Fork 0
mirror of https://github.com/jlengrand/error-prone-support.git synced 2026-03-10 08:11:25 +00:00
Code Issues Packages Projects Releases Wiki Activity

Some tweaks before posting some code in a Github issue

Browse Source
This commit is contained in:
Stephan Schroevers
2021-01-09 11:17:16 +01:00
parent a53e497153
commit 9a9b5fdba5
1 changed files with 5 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
error-prone-contrib/src/main/java/tech/picnic/errorprone/bugpatterns/RefasterCheck.java
View File

@@ -104,9 +104,9 @@ public final class RefasterCheck extends BugChecker implements CompilationUnitTr
* Reports a subset of the given matches, such that no two reported matches suggest a replacement
* of the same part of the source code.
*
* <p>Generally all matches will be reported. In case of overlap the match which replaces the
* largest piece of source code is preferred. In case two matches wish to replace exactly the same
* piece of code, preference is given to the match which suggests the shortest replacement.
* <p>In the common case all matches will be reported. In case of overlap the match which replaces
* the largest piece of source code is preferred. In case two matches wish to replace exactly the
* same piece of code, preference is given to the match which suggests the shortest replacement.
*/
// XXX: This selection logic solves an issue described in
// https://github.com/google/error-prone/issues/559. Consider contributing it back upstream.
@@ -134,7 +134,7 @@ public final class RefasterCheck extends BugChecker implements CompilationUnitTr
return getReplacements(description, endPositions).mapToInt(Replacement::length).sum();
}
// XXX: Strictly speaking we should prefer the shortest replacement *post formatting*!
// XXX: It might be nicer to prefer the shortest replacement _post formatting_.
private static int getInsertedCodeSize(Description description, EndPosTable endPositions) {
return getReplacements(description, endPositions).mapToInt(r -> r.replaceWith().length()).sum();
}
@@ -148,9 +148,7 @@ public final class RefasterCheck extends BugChecker implements CompilationUnitTr
private static Stream<Replacement> getReplacements(
Description description, EndPosTable endPositions) {
return description.fixes.stream()
.limit(1)
.flatMap(fix -> fix.getReplacements(endPositions).stream());
return description.fixes.stream().flatMap(fix -> fix.getReplacements(endPositions).stream());
}
private static CodeTransformer createCompositeCodeTransformer(