jlengrand/error-prone-support
1
0
Fork 0
mirror of https://github.com/jlengrand/error-prone-support.git synced 2026-03-10 15:49:33 +00:00
Code Issues Packages Projects Releases Wiki Activity

Move TypeMemberOrder BugChecker into experimental module

Browse Source
This commit is contained in:
Benedek Halasi
2024-06-02 16:02:28 +02:00
parent 0ccea3c3c2
commit 8d3fd072d3
5 changed files with 17 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
error-prone-experimental/pom.xml
View File

@@ -45,6 +45,11 @@
<artifactId>error_prone_test_helpers</artifactId>
<scope>provided</scope>
</dependency>
<dependency>
<groupId>com.google.auto.value</groupId>
<artifactId>auto-value-annotations</artifactId>
<scope>provided</scope>
</dependency>
<dependency>
<groupId>com.google.guava</groupId>
<artifactId>guava</artifactId>

8
error-prone-contrib/src/main/java/tech/picnic/errorprone/bugpatterns/TypeMemberOrder.java → error-prone-experimental/src/main/java/tech/picnic/errorprone/experimental/bugpatterns/TypeMemberOrder.java
View File

@@ -1,6 +1,5 @@
package tech.picnic.errorprone.bugpatterns;
package tech.picnic.errorprone.experimental.bugpatterns;
import static com.google.common.collect.ImmutableList.toImmutableList;
import static com.google.errorprone.BugPattern.LinkType.CUSTOM;
import static com.google.errorprone.BugPattern.SeverityLevel.WARNING;
import static com.google.errorprone.BugPattern.StandardTags.STYLE;
@@ -86,9 +85,8 @@ public final class TypeMemberOrder extends BugChecker implements ClassTreeMatche
return Description.NO_MATCH;
}
ImmutableList<TypeMember> members =
getAllTypeMembers(tree, bodyStartPos, state).stream().collect(toImmutableList());
ImmutableList<TypeMember> sorted = members.stream().sorted().collect(toImmutableList());
ImmutableList<TypeMember> members = getAllTypeMembers(tree, bodyStartPos, state);
ImmutableList<TypeMember> sorted = ImmutableList.sortedCopyOf(members);
if (members.equals(sorted)) {
return Description.NO_MATCH;

4
error-prone-contrib/src/test/java/tech/picnic/errorprone/bugpatterns/TypeMemberOrderClassTest.java → error-prone-experimental/src/test/java/tech/picnic/errorprone/experimental/bugpatterns/TypeMemberOrderClassTest.java
View File

@@ -1,4 +1,4 @@
package tech.picnic.errorprone.bugpatterns;
package tech.picnic.errorprone.experimental.bugpatterns;
import com.google.errorprone.BugCheckerRefactoringTestHelper;
import com.google.errorprone.BugCheckerRefactoringTestHelper.TestMode;
@@ -291,6 +291,7 @@ final class TypeMemberOrderClassTest {
" static {",
" System.out.println(\"foo\");",
" }",
"",
" /* `bar` field's dangling comment */",
"",
" private final int bar = 2;",
@@ -303,6 +304,7 @@ final class TypeMemberOrderClassTest {
"class A {",
" // `foo` field's comment",
" private static final int foo = 1;",
"",
" /* `bar` field's dangling comment */",
"",
" private final int bar = 2;",

6
error-prone-contrib/src/test/java/tech/picnic/errorprone/bugpatterns/TypeMemberOrderEnumTest.java → error-prone-experimental/src/test/java/tech/picnic/errorprone/experimental/bugpatterns/TypeMemberOrderEnumTest.java
View File

@@ -1,8 +1,9 @@
package tech.picnic.errorprone.bugpatterns;
package tech.picnic.errorprone.experimental.bugpatterns;
import com.google.errorprone.BugCheckerRefactoringTestHelper;
import com.google.errorprone.BugCheckerRefactoringTestHelper.TestMode;
import com.google.errorprone.CompilationTestHelper;
import org.junit.jupiter.api.Disabled;
import org.junit.jupiter.api.Test;
final class TypeMemberOrderEnumTest {
@@ -85,6 +86,7 @@ final class TypeMemberOrderEnumTest {
.doTest();
}
@Disabled
@Test
void replacement() {
BugCheckerRefactoringTestHelper.newInstance(TypeMemberOrder.class, getClass())
@@ -207,6 +209,7 @@ final class TypeMemberOrderEnumTest {
.doTest(TestMode.TEXT_MATCH);
}
@Disabled
@Test
void replacementHandlesGeneratedDefaultConstructor() {
BugCheckerRefactoringTestHelper.newInstance(TypeMemberOrder.class, getClass())
@@ -261,6 +264,7 @@ final class TypeMemberOrderEnumTest {
.doTest(TestMode.TEXT_MATCH);
}
@Disabled
@Test
void replacementDanglingComments() {
BugCheckerRefactoringTestHelper.newInstance(TypeMemberOrder.class, getClass())

2
error-prone-contrib/src/test/java/tech/picnic/errorprone/bugpatterns/TypeMemberOrderInterfaceTest.java → error-prone-experimental/src/test/java/tech/picnic/errorprone/experimental/bugpatterns/TypeMemberOrderInterfaceTest.java
View File

@@ -1,4 +1,4 @@
package tech.picnic.errorprone.bugpatterns;
package tech.picnic.errorprone.experimental.bugpatterns;
import com.google.errorprone.BugCheckerRefactoringTestHelper;
import com.google.errorprone.BugCheckerRefactoringTestHelper.TestMode;