fix: service to be created even if private port (#562)

As of today if port is set as private on an app / db, then no service
will be created for it in k8s. This should not be the case and a service
should be created even if app or db is flagged as private allowing other
internal apps to connect to it.

lib/aws/charts/q-application/templates/service.j2.yaml

@@ -1,4 +1,3 @@
-{%- if is_private_port %}
 apiVersion: v1
 kind: Service
 metadata:
@@ -22,5 +21,4 @@ spec:
     ownerId: {{ owner_id }}
     appId: {{ id }}
     app: {{ sanitized_name }}
-    envId: {{ environment_id }}
-{% endif %}
+    envId: {{ environment_id }}

lib/digitalocean/charts/q-application/templates/service.j2.yaml

@@ -1,4 +1,3 @@
-{%- if is_private_port %}
 apiVersion: v1
 kind: Service
 metadata:
@@ -22,5 +21,4 @@ spec:
     ownerId: {{ owner_id }}
     appId: {{ id }}
     app: {{ sanitized_name }}
-    envId: {{ environment_id }}
-{% endif %}
+    envId: {{ environment_id }}

lib/scaleway/charts/q-application/templates/service.j2.yaml

@@ -1,4 +1,3 @@
-{%- if is_private_port %}
 apiVersion: v1
 kind: Service
 metadata:
@@ -22,5 +21,4 @@ spec:
     ownerId: {{ owner_id }}
     appId: {{ id }}
     app: {{ sanitized_name }}
-    envId: {{ environment_id }}
-{% endif %}
+    envId: {{ environment_id }}