jlengrand/engine
1
0
Fork 0
mirror of https://github.com/jlengrand/engine.git synced 2026-03-10 08:11:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix deployment flow (#584)

Browse Source 
- Multiple stateful services trigger the on_create_check()
    before service are deployed every time

  - stateless services were check mulitples times also
This commit is contained in:
Erèbe - Romain Gerard
2022-02-07 11:27:27 +01:00
committed by GitHub
parent f02e08a52b
commit 65be37693f
1 changed files with 13 additions and 31 deletions
Download Patch File Download Diff File Expand all files Collapse all files

44
src/cloud_provider/kubernetes.rs
View File

@@ -408,18 +408,17 @@ pub fn deploy_environment(
"deployment",
CheckAction::Deploy,
)?;
// check all deployed services
for service in &environment.stateful_services {
let _ = service::check_kubernetes_service_error(
service.on_create_check(),
kubernetes,
service,
&stateful_deployment_target,
&listeners_helper,
"check deployment",
CheckAction::Deploy,
)?;
}
let _ = service::check_kubernetes_service_error(
service.on_create_check(),
kubernetes,
service,
&stateful_deployment_target,
&listeners_helper,
"check deployment",
CheckAction::Deploy,
)?;
}
// Quick fix: adding 100 ms delay to avoid race condition on service status update
@@ -442,13 +441,11 @@ pub fn deploy_environment(
"deployment",
CheckAction::Deploy,
)?;
}
// Quick fix: adding 100 ms delay to avoid race condition on service status update
thread::sleep(std::time::Duration::from_millis(100));
// Quick fix: adding 100 ms delay to avoid race condition on service status update
thread::sleep(std::time::Duration::from_millis(100));
// check all deployed services
for service in &environment.stateful_services {
// check all deployed services
let _ = service::check_kubernetes_service_error(
service.on_create_check(),
kubernetes,
@@ -460,21 +457,6 @@ pub fn deploy_environment(
)?;
}
// Quick fix: adding 100 ms delay to avoid race condition on service status update
thread::sleep(std::time::Duration::from_millis(100));
for service in &environment.stateless_services {
let _ = service::check_kubernetes_service_error(
service.on_create_check(),
kubernetes,
service,
&stateless_deployment_target,
&listeners_helper,
"check deployment",
CheckAction::Deploy,
)?;
}
Ok(())
}