mirror of
https://github.com/jlengrand/detekt.git
synced 2026-03-10 08:11:23 +00:00
Update MagicNumber rule to exclude .kts files (#4877)
* Update MagicNumber rule to exclude .kts files The MagicNumber rule should not be enforced in script files, because you cannot have constants in these files. Closes #4863 * Adapt Exclusion.kt for MagicNumber rule
This commit is contained in:
@@ -543,7 +543,7 @@ style:
|
||||
maxJumpCount: 1
|
||||
MagicNumber:
|
||||
active: true
|
||||
excludes: ['**/test/**', '**/androidTest/**', '**/commonTest/**', '**/jvmTest/**', '**/jsTest/**', '**/iosTest/**']
|
||||
excludes: ['**/test/**', '**/androidTest/**', '**/commonTest/**', '**/jvmTest/**', '**/jsTest/**', '**/iosTest/**', '**/*.kts']
|
||||
ignoreNumbers:
|
||||
- '-1'
|
||||
- '0'
|
||||
|
||||
@@ -5,7 +5,7 @@ import io.gitlab.arturbosch.detekt.generator.collection.Rule
|
||||
/**
|
||||
* Holds a list of extra exclusions for rules and rule sets.
|
||||
*/
|
||||
val exclusions = arrayOf(TestExclusions, KotlinScriptExclusions, LibraryExclusions)
|
||||
val exclusions = arrayOf(TestExclusions, KotlinScriptExclusions, KotlinScriptAndTestExclusions, LibraryExclusions)
|
||||
|
||||
/**
|
||||
* Tracks rules and rule sets which needs an extra `excludes: $pattern` property
|
||||
@@ -28,7 +28,6 @@ private object TestExclusions : Exclusions() {
|
||||
override val rules = setOf(
|
||||
"FunctionNaming",
|
||||
"WildcardImport",
|
||||
"MagicNumber",
|
||||
"LateinitUsage",
|
||||
"StringLiteralDuplication",
|
||||
"SpreadOperator",
|
||||
@@ -51,6 +50,14 @@ private object KotlinScriptExclusions : Exclusions() {
|
||||
override val rules = setOf("MissingPackageDeclaration")
|
||||
}
|
||||
|
||||
private object KotlinScriptAndTestExclusions : Exclusions() {
|
||||
|
||||
override val pattern =
|
||||
"['**/test/**', '**/androidTest/**', '**/commonTest/**', '**/jvmTest/**', '**/jsTest/**', '**/iosTest/**', " +
|
||||
"'**/*.kts']"
|
||||
override val rules = setOf("MagicNumber")
|
||||
}
|
||||
|
||||
private object LibraryExclusions : Exclusions() {
|
||||
|
||||
override val pattern = "['**']"
|
||||
|
||||
Reference in New Issue
Block a user