jlengrand/bugsink
1
0
Fork 0
mirror of https://github.com/jlengrand/bugsink.git synced 2026-03-10 08:01:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix tests for UnclosableBytesIO

Browse Source 
i.e. fix tests for 391e22bcf0

(the changes in the present commit in `ingest/tests.py` are not strictly necessary
but they are principly right)
This commit is contained in:
Klaas van Schelven
2025-11-05 08:39:40 +01:00
parent 391e22bcf0
commit de9a37aab6
2 changed files with 10 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
ingest/parsers.py
View File

@@ -1,7 +1,7 @@
import json
import io
from bugsink.streams import MaxDataWriter
from bugsink.streams import MaxDataWriter, UnclosableBytesIO
from .exceptions import ParseError
from .header_validators import filter_valid_envelope_headers, filter_valid_item_headers
@@ -195,5 +195,5 @@ class StreamingEnvelopeParser:
def get_items_directly(self):
# this method is just convenience for testing
for item_headers, output_stream in self.get_items(lambda item_headers: io.BytesIO()):
for item_headers, output_stream in self.get_items(lambda item_headers: UnclosableBytesIO()):
yield item_headers, output_stream.getvalue()

15
ingest/tests.py
View File

@@ -25,6 +25,7 @@ from issues.factories import get_or_create_issue
from issues.models import IssueStateManager, Issue, TurningPoint, TurningPointKind
from issues.utils import get_values
from bugsink.app_settings import override_settings
from bugsink.streams import UnclosableBytesIO
from compat.timestamp import format_timestamp
from compat.dsn import get_header_value
from bsmain.management.commands.send_json import Command as SendJsonCommand
@@ -631,7 +632,7 @@ class TestParser(RegularTestCase):
initial_chunk = b"line 0\nline 1\n"
input_stream.seek(0)
output_stream = io.BytesIO()
output_stream = UnclosableBytesIO()
remainder, at_eof = readuntil(input_stream, initial_chunk, NewlineFinder(), output_stream, 3)
self.assertFalse(at_eof)
@@ -644,7 +645,7 @@ class TestParser(RegularTestCase):
initial_chunk = b"lin"
input_stream.seek(0)
output_stream = io.BytesIO()
output_stream = UnclosableBytesIO()
remainder, at_eof = readuntil(input_stream, initial_chunk, NewlineFinder(), output_stream, 3)
self.assertFalse(at_eof)
@@ -657,7 +658,7 @@ class TestParser(RegularTestCase):
initial_chunk = b""
input_stream.seek(0)
output_stream = io.BytesIO()
output_stream = UnclosableBytesIO()
remainder, at_eof = readuntil(input_stream, initial_chunk, NewlineFinder(), output_stream, 3)
self.assertFalse(at_eof)
@@ -670,7 +671,7 @@ class TestParser(RegularTestCase):
initial_chunk = b""
input_stream.seek(0)
output_stream = io.BytesIO()
output_stream = UnclosableBytesIO()
remainder, at_eof = readuntil(input_stream, initial_chunk, NewlineFinder(), output_stream, 3)
self.assertTrue(at_eof)
@@ -683,7 +684,7 @@ class TestParser(RegularTestCase):
initial_chunk = b"lin"
input_stream.seek(0)
output_stream = io.BytesIO()
output_stream = UnclosableBytesIO()
remainder, at_eof = readuntil(input_stream, initial_chunk, NewlineFinder(), output_stream, 1024)
self.assertFalse(at_eof)
@@ -696,7 +697,7 @@ class TestParser(RegularTestCase):
initial_chunk = b"lin"
input_stream.seek(0)
output_stream = io.BytesIO()
output_stream = UnclosableBytesIO()
remainder, at_eof = readuntil(input_stream, initial_chunk, LengthFinder(10, "eof not ok"), output_stream, 3)
self.assertFalse(at_eof)
@@ -709,7 +710,7 @@ class TestParser(RegularTestCase):
initial_chunk = b"lin"
input_stream.seek(0)
output_stream = io.BytesIO()
output_stream = UnclosableBytesIO()
with self.assertRaises(ParseError):
remainder, at_eof = readuntil(input_stream, initial_chunk, LengthFinder(100, "EOF"), output_stream, 1000)