jlengrand/bugsink
1
0
Fork 0
mirror of https://github.com/jlengrand/bugsink.git synced 2026-03-10 08:01:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

File-upload: chunk-size of 2MiB

Browse Source 
as per the comment

Fix #147
This commit is contained in:
Klaas van Schelven
2025-07-16 15:31:41 +02:00
parent 4c4a4f6fd6
commit d35327fe80
1 changed files with 6 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
files/views.py
View File

@@ -43,12 +43,13 @@ def get_chunk_upload_settings(request, organization_slug):
return JsonResponse({
"url": url,
# For now, staying close to the default MAX_ENVELOPE_COMPRESSED_SIZE, which is 20MiB;
# I _think_ I saw a note somewhere on (one of) these values having to be a power of 2; hence rounding down to
# 16 to stay under any proxy-side limits that might mirror the envelope's 20MiB.
# We pick a "somewhat arbitrary" value between 1MiB and 16MiB to balance between "works reliably" and "lower
# overhead", erring on the "works reliably" side of that spectrum. There's really no lower bound technically,
# I've played with 32-byte requests.
# note: sentry-cli <= v2.39.1 requires a power of 2 here.
# chunkSize == maxRequestSize per the comments on `chunksPerRequest: 1`.
"chunkSize": 16 * _MEBIBYTE,
"maxRequestSize": 16 * _MEBIBYTE,
"chunkSize": 2 * _MEBIBYTE,
"maxRequestSize": 2 * _MEBIBYTE,
# The limit here is _actually storing this_. For now "just picking a high limit" assuming that we'll have decent
# storage (#151) for the files eventually.