jlengrand/bugsink
1
0
Fork 0
mirror of https://github.com/jlengrand/bugsink.git synced 2026-03-10 08:01:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

Show 'no version' on a button when this applies

Browse Source
This commit is contained in:
Klaas van Schelven
2024-09-30 21:22:34 +02:00
parent 10f63830ba
commit 8ee526776e
2 changed files with 9 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
projects/models.py
View File

@@ -80,7 +80,7 @@ class Project(models.Model):
def get_latest_release(self):
from releases.models import ordered_releases
if not hasattr(self, "_latest_release"):
if not hasattr(self, "_latest_release"): # per-instance cache
self._latest_release = list(ordered_releases(project=self))[-1]
return self._latest_release

8
releases/models.py
View File

@@ -84,6 +84,14 @@ class Release(models.Model):
unique_together = ("project", "version")
def get_short_version(self):
if self.version == "":
# the reason for this little hack is to have something show up in the UI for this case. I 'assume' (mother
# of all ...) that in most reasonable cases we actually don't show releases if there's an empty release
# (i.e. for the single empty release we really shouldn't, because then project.has_releases should be false)
# but I've seen at least one case where you still have to show something even for the empty release: when
# switching back to "no release". (that's why I say "most reasonable cases"). (observed in testing, because
# test-events generally wildly vary in the release info they carry).
return "«no version»"
if self.is_semver:
return self.version
return self.version[:12]