mirror of
https://github.com/jlengrand/bugsink.git
synced 2026-03-10 08:01:17 +00:00
Remove the concept of 'culprit' from the grouping code
This has been deprecated in Sentry in 2016; no reason for us to support it. It is noted that despite the deprecation (in favor of `transaction`) an explicitly provided culprit actually took a higher precedence than an explicitly provided transaction in the now-removed code.
This commit is contained in:
Klaas van Schelven
@@ -5,21 +5,21 @@ from sentry.eventtypes.base import DefaultEvent
|
||||
from sentry.eventtypes.error import ErrorEvent
|
||||
|
||||
|
||||
def default_issue_grouper(title: str, culprit: str, type_) -> str:
|
||||
return title + " ⋄ " + culprit + " ⋄ " + type_
|
||||
def default_issue_grouper(title: str, transaction: str, type_) -> str:
|
||||
return title + " ⋄ " + transaction + " ⋄ " + type_
|
||||
|
||||
|
||||
def generate_issue_grouper(title: str, culprit: str, type_, extra: Optional[List[str]] = None) -> str:
|
||||
def generate_issue_grouper(title: str, transaction: str, type_, extra: Optional[List[str]] = None) -> str:
|
||||
if extra:
|
||||
return "".join(
|
||||
[
|
||||
default_issue_grouper(title, culprit, type_)
|
||||
default_issue_grouper(title, transaction, type_)
|
||||
if part == "{{ default }}"
|
||||
else part
|
||||
for part in extra
|
||||
]
|
||||
)
|
||||
return default_issue_grouper(title, culprit, type_)
|
||||
return default_issue_grouper(title, transaction, type_)
|
||||
|
||||
|
||||
def get_issue_grouper_for_data(data):
|
||||
@@ -31,8 +31,8 @@ def get_issue_grouper_for_data(data):
|
||||
metadata = eventtype.get_metadata(data)
|
||||
|
||||
title = eventtype.get_title(metadata)
|
||||
culprit = eventtype.get_location(data)
|
||||
return generate_issue_grouper(title, culprit, type(eventtype).__name__, data.get("fingerprint"))
|
||||
transaction = eventtype.get_location(data)
|
||||
return generate_issue_grouper(title, transaction, type(eventtype).__name__, data.get("fingerprint"))
|
||||
|
||||
|
||||
def get_hash_for_data(data):
|
||||
|
||||
@@ -1,493 +0,0 @@
|
||||
"""
|
||||
These settings act as the default (base) settings for the Sentry-provided
|
||||
web-server
|
||||
"""
|
||||
|
||||
|
||||
import logging
|
||||
import os.path
|
||||
from collections import OrderedDict, namedtuple
|
||||
from datetime import timedelta
|
||||
|
||||
from django.utils.translation import gettext_lazy as _
|
||||
|
||||
# from sentry.utils.integrationdocs import load_doc
|
||||
# from sentry.utils.geo import rust_geoip
|
||||
|
||||
# import semaphore
|
||||
|
||||
|
||||
def get_all_languages():
|
||||
results = []
|
||||
for path in os.listdir(os.path.join(MODULE_ROOT, "locale")):
|
||||
if path.startswith("."):
|
||||
continue
|
||||
if "_" in path:
|
||||
pre, post = path.split("_", 1)
|
||||
path = "{}-{}".format(pre, post.lower())
|
||||
results.append(path)
|
||||
return results
|
||||
|
||||
|
||||
MODULE_ROOT = os.path.dirname(__import__("sentry").__file__)
|
||||
DATA_ROOT = os.path.join(MODULE_ROOT, "data")
|
||||
|
||||
BAD_RELEASE_CHARS = "\n\f\t/"
|
||||
MAX_VERSION_LENGTH = 200
|
||||
MAX_COMMIT_LENGTH = 64
|
||||
COMMIT_RANGE_DELIMITER = ".."
|
||||
|
||||
SORT_OPTIONS = OrderedDict(
|
||||
(
|
||||
("priority", _("Priority")),
|
||||
("date", _("Last Seen")),
|
||||
("new", _("First Seen")),
|
||||
("freq", _("Frequency")),
|
||||
)
|
||||
)
|
||||
|
||||
SEARCH_SORT_OPTIONS = OrderedDict(
|
||||
(("score", _("Score")), ("date", _("Last Seen")), ("new", _("First Seen")))
|
||||
)
|
||||
|
||||
# XXX: Deprecated: use GroupStatus instead
|
||||
STATUS_UNRESOLVED = 0
|
||||
STATUS_RESOLVED = 1
|
||||
STATUS_IGNORED = 2
|
||||
|
||||
STATUS_CHOICES = {
|
||||
"resolved": STATUS_RESOLVED,
|
||||
"unresolved": STATUS_UNRESOLVED,
|
||||
"ignored": STATUS_IGNORED,
|
||||
# TODO(dcramer): remove in 9.0
|
||||
"muted": STATUS_IGNORED,
|
||||
}
|
||||
|
||||
# Normalize counts to the 15 minute marker. This value MUST be less than 60. A
|
||||
# value of 0 would store counts for every minute, and is the lowest level of
|
||||
# accuracy provided.
|
||||
MINUTE_NORMALIZATION = 15
|
||||
|
||||
MAX_TAG_KEY_LENGTH = 32
|
||||
MAX_TAG_VALUE_LENGTH = 200
|
||||
MAX_CULPRIT_LENGTH = 200
|
||||
MAX_EMAIL_FIELD_LENGTH = 75
|
||||
|
||||
ENVIRONMENT_NAME_PATTERN = r"^[^\n\r\f\/]*$"
|
||||
ENVIRONMENT_NAME_MAX_LENGTH = 64
|
||||
|
||||
SENTRY_APP_SLUG_MAX_LENGTH = 64
|
||||
|
||||
# Team slugs which may not be used. Generally these are top level URL patterns
|
||||
# which we don't want to worry about conflicts on.
|
||||
RESERVED_ORGANIZATION_SLUGS = frozenset(
|
||||
(
|
||||
"admin",
|
||||
"manage",
|
||||
"login",
|
||||
"account",
|
||||
"register",
|
||||
"api",
|
||||
"accept",
|
||||
"organizations",
|
||||
"teams",
|
||||
"projects",
|
||||
"help",
|
||||
"docs",
|
||||
"logout",
|
||||
"404",
|
||||
"500",
|
||||
"_static",
|
||||
"out",
|
||||
"debug",
|
||||
"remote",
|
||||
"get-cli",
|
||||
"blog",
|
||||
"welcome",
|
||||
"features",
|
||||
"customers",
|
||||
"integrations",
|
||||
"signup",
|
||||
"pricing",
|
||||
"subscribe",
|
||||
"enterprise",
|
||||
"about",
|
||||
"jobs",
|
||||
"thanks",
|
||||
"guide",
|
||||
"privacy",
|
||||
"security",
|
||||
"terms",
|
||||
"from",
|
||||
"sponsorship",
|
||||
"for",
|
||||
"at",
|
||||
"platforms",
|
||||
"branding",
|
||||
"vs",
|
||||
"answers",
|
||||
"_admin",
|
||||
"support",
|
||||
"contact",
|
||||
"onboarding",
|
||||
"ext",
|
||||
"extension",
|
||||
"extensions",
|
||||
"plugins",
|
||||
"themonitor",
|
||||
"settings",
|
||||
"legal",
|
||||
"avatar",
|
||||
"organization-avatar",
|
||||
"project-avatar",
|
||||
"team-avatar",
|
||||
"careers",
|
||||
"_experiment",
|
||||
"sentry-apps",
|
||||
)
|
||||
)
|
||||
|
||||
RESERVED_PROJECT_SLUGS = frozenset(
|
||||
(
|
||||
"api-keys",
|
||||
"audit-log",
|
||||
"auth",
|
||||
"members",
|
||||
"projects",
|
||||
"rate-limits",
|
||||
"repos",
|
||||
"settings",
|
||||
"teams",
|
||||
"billing",
|
||||
"payments",
|
||||
"legal",
|
||||
"subscription",
|
||||
"support",
|
||||
"integrations",
|
||||
"developer-settings",
|
||||
"usage",
|
||||
)
|
||||
)
|
||||
|
||||
LOG_LEVELS = {
|
||||
logging.NOTSET: "sample",
|
||||
logging.DEBUG: "debug",
|
||||
logging.INFO: "info",
|
||||
logging.WARNING: "warning",
|
||||
logging.ERROR: "error",
|
||||
logging.FATAL: "fatal",
|
||||
}
|
||||
DEFAULT_LOG_LEVEL = "error"
|
||||
DEFAULT_LOGGER_NAME = ""
|
||||
LOG_LEVELS_MAP = {v: k for k, v in LOG_LEVELS.items()}
|
||||
|
||||
# Default alerting threshold values
|
||||
DEFAULT_ALERT_PROJECT_THRESHOLD = (500, 25) # 500%, 25 events
|
||||
DEFAULT_ALERT_GROUP_THRESHOLD = (1000, 25) # 1000%, 25 events
|
||||
|
||||
# Default sort option for the group stream
|
||||
DEFAULT_SORT_OPTION = "date"
|
||||
|
||||
# Setup languages for only available locales
|
||||
# _language_map = dict(settings.LANGUAGES)
|
||||
# LANGUAGES = [(k, _language_map[k]) for k in get_all_languages() if k in _language_map]
|
||||
# del _language_map
|
||||
|
||||
# TODO(dcramer): We eventually want to make this user-editable
|
||||
TAG_LABELS = {
|
||||
"exc_type": "Exception Type",
|
||||
"sentry:user": "User",
|
||||
"sentry:release": "Release",
|
||||
"sentry:dist": "Distribution",
|
||||
"os": "OS",
|
||||
"url": "URL",
|
||||
"server_name": "Server",
|
||||
}
|
||||
|
||||
PROTECTED_TAG_KEYS = frozenset(["environment", "release", "sentry:release"])
|
||||
|
||||
# TODO(dcramer): once this is more flushed out we want this to be extendable
|
||||
SENTRY_RULES = (
|
||||
"sentry.rules.actions.notify_event.NotifyEventAction",
|
||||
"sentry.rules.actions.notify_event_service.NotifyEventServiceAction",
|
||||
"sentry.rules.conditions.every_event.EveryEventCondition",
|
||||
"sentry.rules.conditions.first_seen_event.FirstSeenEventCondition",
|
||||
"sentry.rules.conditions.regression_event.RegressionEventCondition",
|
||||
"sentry.rules.conditions.reappeared_event.ReappearedEventCondition",
|
||||
"sentry.rules.conditions.tagged_event.TaggedEventCondition",
|
||||
"sentry.rules.conditions.event_frequency.EventFrequencyCondition",
|
||||
"sentry.rules.conditions.event_frequency.EventUniqueUserFrequencyCondition",
|
||||
"sentry.rules.conditions.event_attribute.EventAttributeCondition",
|
||||
"sentry.rules.conditions.level.LevelCondition",
|
||||
)
|
||||
|
||||
# methods as defined by http://www.w3.org/Protocols/rfc2616/rfc2616-sec9.html + PATCH
|
||||
HTTP_METHODS = (
|
||||
"GET",
|
||||
"POST",
|
||||
"PUT",
|
||||
"OPTIONS",
|
||||
"HEAD",
|
||||
"DELETE",
|
||||
"TRACE",
|
||||
"CONNECT",
|
||||
"PATCH",
|
||||
)
|
||||
|
||||
# See https://github.com/getsentry/semaphore/blob/master/general/src/protocol/constants.rs
|
||||
# VALID_PLATFORMS = semaphore.VALID_PLATFORMS
|
||||
VALID_PLATFORMS = [
|
||||
"as3",
|
||||
"c",
|
||||
"cfml",
|
||||
"cocoa",
|
||||
"csharp",
|
||||
"elixir",
|
||||
"go",
|
||||
"groovy",
|
||||
"haskell",
|
||||
"java",
|
||||
"javascript",
|
||||
"native",
|
||||
"node",
|
||||
"objc",
|
||||
"other",
|
||||
"perl",
|
||||
"php",
|
||||
"python",
|
||||
"ruby",
|
||||
]
|
||||
|
||||
OK_PLUGIN_ENABLED = _("The {name} integration has been enabled.")
|
||||
|
||||
OK_PLUGIN_DISABLED = _("The {name} integration has been disabled.")
|
||||
|
||||
OK_PLUGIN_SAVED = _("Configuration for the {name} integration has been saved.")
|
||||
|
||||
WARN_SESSION_EXPIRED = "Your session has expired." # TODO: translate this
|
||||
|
||||
# Maximum length of a symbol
|
||||
MAX_SYM = 256
|
||||
|
||||
# Known debug information file mimetypes
|
||||
KNOWN_DIF_FORMATS = {
|
||||
"text/x-breakpad": "breakpad",
|
||||
"application/x-mach-binary": "macho",
|
||||
"application/x-elf-binary": "elf",
|
||||
"application/x-dosexec": "pe",
|
||||
"application/x-ms-pdb": "pdb",
|
||||
"text/x-proguard+plain": "proguard",
|
||||
"application/x-sentry-bundle+zip": "sourcebundle",
|
||||
}
|
||||
|
||||
NATIVE_UNKNOWN_STRING = "<unknown>"
|
||||
|
||||
# Maximum number of release files that can be "skipped" (i.e., maximum paginator offset)
|
||||
# inside release files API endpoints.
|
||||
# If this number is too large, it may cause problems because of inefficient
|
||||
# LIMIT-OFFSET database queries.
|
||||
# These problems should be solved after we implement artifact bundles workflow.
|
||||
MAX_RELEASE_FILES_OFFSET = 20000
|
||||
|
||||
# to go from an integration id (in _platforms.json) to the platform
|
||||
# data, such as documentation url or humanized name.
|
||||
# example: java-logback -> {"type": "framework",
|
||||
# "link": "https://docs.getsentry.com/hosted/clients/java/modules/logback/",
|
||||
# "id": "java-logback",
|
||||
# "name": "Logback"}
|
||||
INTEGRATION_ID_TO_PLATFORM_DATA = {}
|
||||
|
||||
|
||||
# def _load_platform_data():
|
||||
# INTEGRATION_ID_TO_PLATFORM_DATA.clear()
|
||||
# data = load_doc("_platforms")
|
||||
|
||||
# if not data:
|
||||
# return
|
||||
|
||||
# for platform in data["platforms"]:
|
||||
# integrations = platform.pop("integrations")
|
||||
# if integrations:
|
||||
# for integration in integrations:
|
||||
# integration_id = integration.pop("id")
|
||||
# if integration["type"] != "language":
|
||||
# integration["language"] = platform["id"]
|
||||
# INTEGRATION_ID_TO_PLATFORM_DATA[integration_id] = integration
|
||||
|
||||
|
||||
# _load_platform_data()
|
||||
|
||||
# special cases where the marketing slug differs from the integration id
|
||||
# (in _platforms.json). missing values (for example: "java") should assume
|
||||
# the marketing slug is the same as the integration id:
|
||||
# javascript, node, python, php, ruby, go, swift, objc, java, perl, elixir
|
||||
MARKETING_SLUG_TO_INTEGRATION_ID = {
|
||||
"kotlin": "java",
|
||||
"scala": "java",
|
||||
"spring": "java",
|
||||
"android": "java-android",
|
||||
"react": "javascript-react",
|
||||
"angular": "javascript-angular",
|
||||
"angular2": "javascript-angular2",
|
||||
"ember": "javascript-ember",
|
||||
"backbone": "javascript-backbone",
|
||||
"vue": "javascript-vue",
|
||||
"express": "node-express",
|
||||
"koa": "node-koa",
|
||||
"django": "python-django",
|
||||
"flask": "python-flask",
|
||||
"sanic": "python-sanic",
|
||||
"tornado": "python-tornado",
|
||||
"celery": "python-celery",
|
||||
"rq": "python-rq",
|
||||
"bottle": "python-bottle",
|
||||
"pythonawslambda": "python-awslambda",
|
||||
"pyramid": "python-pyramid",
|
||||
"pylons": "python-pylons",
|
||||
"laravel": "php-laravel",
|
||||
"symfony": "php-symfony2",
|
||||
"rails": "ruby-rails",
|
||||
"sinatra": "ruby-sinatra",
|
||||
"dotnet": "csharp",
|
||||
}
|
||||
|
||||
|
||||
# to go from a marketing page slug like /for/android/ to the integration id
|
||||
# (in _platforms.json), for looking up documentation urls, etc.
|
||||
def get_integration_id_for_marketing_slug(slug):
|
||||
if slug in MARKETING_SLUG_TO_INTEGRATION_ID:
|
||||
return MARKETING_SLUG_TO_INTEGRATION_ID[slug]
|
||||
|
||||
if slug in INTEGRATION_ID_TO_PLATFORM_DATA:
|
||||
return slug
|
||||
|
||||
|
||||
# special cases where the integration sent with the SDK differ from
|
||||
# the integration id (in _platforms.json)
|
||||
# {PLATFORM: {INTEGRATION_SENT: integration_id, ...}, ...}
|
||||
PLATFORM_INTEGRATION_TO_INTEGRATION_ID = {
|
||||
"java": {"java.util.logging": "java-logging"},
|
||||
# TODO: add more special cases...
|
||||
}
|
||||
|
||||
|
||||
# to go from event data to the integration id (in _platforms.json),
|
||||
# for example an event like:
|
||||
# {"platform": "java",
|
||||
# "sdk": {"name": "sentry-java",
|
||||
# "integrations": ["java.util.logging"]}} -> java-logging
|
||||
def get_integration_id_for_event(platform, sdk_name, integrations):
|
||||
if integrations:
|
||||
for integration in integrations:
|
||||
# check special cases
|
||||
if (
|
||||
platform in PLATFORM_INTEGRATION_TO_INTEGRATION_ID
|
||||
and integration in PLATFORM_INTEGRATION_TO_INTEGRATION_ID[platform]
|
||||
):
|
||||
return PLATFORM_INTEGRATION_TO_INTEGRATION_ID[platform][integration]
|
||||
|
||||
# try <platform>-<integration>, for example "java-log4j"
|
||||
integration_id = "%s-%s" % (platform, integration)
|
||||
if integration_id in INTEGRATION_ID_TO_PLATFORM_DATA:
|
||||
return integration_id
|
||||
|
||||
# try sdk name, for example "sentry-java" -> "java" or "raven-java:log4j" -> "java-log4j"
|
||||
sdk_name = (
|
||||
sdk_name.lower().replace("sentry-", "").replace("raven-", "").replace(":", "-")
|
||||
)
|
||||
if sdk_name in INTEGRATION_ID_TO_PLATFORM_DATA:
|
||||
return sdk_name
|
||||
|
||||
# try platform name, for example "java"
|
||||
if platform in INTEGRATION_ID_TO_PLATFORM_DATA:
|
||||
return platform
|
||||
|
||||
|
||||
class ObjectStatus(object):
|
||||
VISIBLE = 0
|
||||
HIDDEN = 1
|
||||
PENDING_DELETION = 2
|
||||
DELETION_IN_PROGRESS = 3
|
||||
|
||||
ACTIVE = 0
|
||||
DISABLED = 1
|
||||
|
||||
@classmethod
|
||||
def as_choices(cls):
|
||||
return (
|
||||
(cls.ACTIVE, "active"),
|
||||
(cls.DISABLED, "disabled"),
|
||||
(cls.PENDING_DELETION, "pending_deletion"),
|
||||
(cls.DELETION_IN_PROGRESS, "deletion_in_progress"),
|
||||
)
|
||||
|
||||
|
||||
class SentryAppStatus(object):
|
||||
UNPUBLISHED = 0
|
||||
PUBLISHED = 1
|
||||
INTERNAL = 2
|
||||
UNPUBLISHED_STR = "unpublished"
|
||||
PUBLISHED_STR = "published"
|
||||
INTERNAL_STR = "internal"
|
||||
|
||||
@classmethod
|
||||
def as_choices(cls):
|
||||
return (
|
||||
(cls.UNPUBLISHED, cls.UNPUBLISHED_STR),
|
||||
(cls.PUBLISHED, cls.PUBLISHED_STR),
|
||||
(cls.INTERNAL, cls.INTERNAL_STR),
|
||||
)
|
||||
|
||||
@classmethod
|
||||
def as_str(cls, status):
|
||||
if status == cls.UNPUBLISHED:
|
||||
return cls.UNPUBLISHED_STR
|
||||
elif status == cls.PUBLISHED:
|
||||
return cls.PUBLISHED_STR
|
||||
elif status == cls.INTERNAL:
|
||||
return cls.INTERNAL_STR
|
||||
|
||||
|
||||
class SentryAppInstallationStatus(object):
|
||||
PENDING = 0
|
||||
INSTALLED = 1
|
||||
PENDING_STR = "pending"
|
||||
INSTALLED_STR = "installed"
|
||||
|
||||
@classmethod
|
||||
def as_choices(cls):
|
||||
return ((cls.PENDING, cls.PENDING_STR), (cls.INSTALLED, cls.INSTALLED_STR))
|
||||
|
||||
@classmethod
|
||||
def as_str(cls, status):
|
||||
if status == cls.PENDING:
|
||||
return cls.PENDING_STR
|
||||
elif status == cls.INSTALLED:
|
||||
return cls.INSTALLED_STR
|
||||
|
||||
|
||||
StatsPeriod = namedtuple("StatsPeriod", ("segments", "interval"))
|
||||
|
||||
LEGACY_RATE_LIMIT_OPTIONS = frozenset(
|
||||
("sentry:project-rate-limit", "sentry:account-rate-limit")
|
||||
)
|
||||
|
||||
|
||||
# We need to limit the range of valid timestamps of an event because that
|
||||
# timestamp is used to control data retention.
|
||||
MAX_SECS_IN_FUTURE = 60
|
||||
MAX_SECS_IN_PAST = 2592000 # 30 days
|
||||
ALLOWED_FUTURE_DELTA = timedelta(seconds=MAX_SECS_IN_FUTURE)
|
||||
|
||||
# DEFAULT_STORE_NORMALIZER_ARGS = dict(
|
||||
# geoip_lookup=rust_geoip,
|
||||
# stacktrace_frames_hard_limit=settings.SENTRY_STACKTRACE_FRAMES_HARD_LIMIT,
|
||||
# max_stacktrace_frames=settings.SENTRY_MAX_STACKTRACE_FRAMES,
|
||||
# max_secs_in_future=MAX_SECS_IN_FUTURE,
|
||||
# max_secs_in_past=MAX_SECS_IN_PAST,
|
||||
# enable_trimming=True,
|
||||
# )
|
||||
|
||||
INTERNAL_INTEGRATION_TOKEN_COUNT_MAX = 20
|
||||
|
||||
ALL_ACCESS_PROJECTS = {-1}
|
||||
@@ -1,74 +0,0 @@
|
||||
"""
|
||||
This file implements the legacy culprit system. The culprit at this point is
|
||||
just used as a fallback if no transaction is set. When a transaction is set
|
||||
the culprit is overridden by the transaction value.
|
||||
|
||||
Over time we want to fully phase out the culprit. Until then this is the
|
||||
code that generates it.
|
||||
"""
|
||||
|
||||
|
||||
from sentry.constants import MAX_CULPRIT_LENGTH
|
||||
from sentry.utils.safe import get_path
|
||||
from sentry.utils.strings import truncatechars
|
||||
|
||||
|
||||
def generate_culprit(data):
|
||||
platform = data.get("platform")
|
||||
exceptions = get_path(data, "exception", "values", filter=True)
|
||||
if exceptions:
|
||||
# Synthetic events no longer get a culprit
|
||||
last_exception = get_path(exceptions, -1)
|
||||
if get_path(last_exception, "mechanism", "synthetic"):
|
||||
return ""
|
||||
|
||||
stacktraces = [
|
||||
e["stacktrace"] for e in exceptions if get_path(e, "stacktrace", "frames")
|
||||
]
|
||||
else:
|
||||
stacktrace = data.get("stacktrace")
|
||||
if stacktrace and stacktrace.get("frames"):
|
||||
stacktraces = [stacktrace]
|
||||
else:
|
||||
stacktraces = None
|
||||
|
||||
culprit = None
|
||||
|
||||
if not culprit and stacktraces:
|
||||
culprit = get_stacktrace_culprit(get_path(stacktraces, -1), platform=platform)
|
||||
|
||||
if not culprit and data.get("request"):
|
||||
culprit = get_path(data, "request", "url")
|
||||
|
||||
return truncatechars(culprit or "", MAX_CULPRIT_LENGTH)
|
||||
|
||||
|
||||
def get_stacktrace_culprit(stacktrace, platform):
|
||||
default = None
|
||||
for frame in reversed(stacktrace["frames"]):
|
||||
if not frame:
|
||||
continue
|
||||
if frame.get("in_app"):
|
||||
culprit = get_frame_culprit(frame, platform=platform)
|
||||
if culprit:
|
||||
return culprit
|
||||
elif default is None:
|
||||
default = get_frame_culprit(frame, platform=platform)
|
||||
return default
|
||||
|
||||
|
||||
def get_frame_culprit(frame, platform):
|
||||
# If this frame has a platform, we use it instead of the one that
|
||||
# was passed in (as that one comes from the exception which might
|
||||
# not necessarily be the same platform).
|
||||
platform = frame.get("platform") or platform
|
||||
if platform in ("objc", "cocoa", "native"):
|
||||
return frame.get("function") or "?"
|
||||
fileloc = frame.get("module") or frame.get("filename")
|
||||
if not fileloc:
|
||||
return ""
|
||||
elif platform in ("javascript", "node"):
|
||||
# function and fileloc might be unicode here, so let it coerce
|
||||
# to a unicode string if needed.
|
||||
return "%s(%s)" % (frame.get("function") or "?", fileloc)
|
||||
return "%s in %s" % (fileloc, frame.get("function") or "?")
|
||||
@@ -1,6 +1,5 @@
|
||||
from django.utils.encoding import force_str
|
||||
|
||||
from sentry.culprit import generate_culprit
|
||||
from sentry.utils.safe import get_path
|
||||
from sentry.utils.strings import strip, truncatechars
|
||||
|
||||
@@ -38,9 +37,4 @@ class DefaultEvent(BaseEvent):
|
||||
return metadata.get("title") or "<untitled>"
|
||||
|
||||
def get_location(self, data):
|
||||
return force_str(
|
||||
data.get("culprit")
|
||||
or data.get("transaction")
|
||||
or generate_culprit(data)
|
||||
or ""
|
||||
)
|
||||
return force_str(data.get("transaction") or "")
|
||||
|
||||
@@ -1,6 +1,5 @@
|
||||
from django.utils.encoding import force_str
|
||||
|
||||
from sentry.culprit import generate_culprit
|
||||
from sentry.stacktraces.functions import get_function_name_for_frame
|
||||
from sentry.stacktraces.processing import get_crash_frame_from_event_data
|
||||
from sentry.utils.safe import get_path, trim, truncatechars
|
||||
@@ -63,9 +62,4 @@ class ErrorEvent(BaseEvent):
|
||||
return "{}: {}".format(ty, str(metadata["value"]))
|
||||
|
||||
def get_location(self, data):
|
||||
return force_str(
|
||||
data.get("culprit")
|
||||
or data.get("transaction")
|
||||
or generate_culprit(data)
|
||||
or ""
|
||||
)
|
||||
return force_str(data.get("transaction") or "")
|
||||
|
||||
Reference in New Issue
Block a user