Remove 'debug view' as per comment in the view

bugsink/decorators.py

@@ -16,13 +16,13 @@ def login_exempt(view):
 def project_membership_required(function):
     @wraps(function)
     def wrapper(request, *args, **kwargs):
-        if request.user.is_superuser:
-            return function(request, *args, **kwargs)
         if "project_pk" not in kwargs:
             raise TypeError("project_pk must be passed as a keyword argument")
         project_pk = kwargs.pop("project_pk")
         project = get_object_or_404(Project, pk=project_pk)
         kwargs["project"] = project
+        if request.user.is_superuser:
+            return function(request, *args, **kwargs)
         if project.users.filter(pk=request.user.pk).exists():
             return function(request, *args, **kwargs)
 
@@ -34,13 +34,13 @@ def project_membership_required(function):
 def issue_membership_required(function):
     @wraps(function)
     def wrapper(request, *args, **kwargs):
-        if request.user.is_superuser:
-            return function(request, *args, **kwargs)
         if "issue_pk" not in kwargs:
             raise TypeError("issue_pk must be passed as a keyword argument")
         issue_pk = kwargs.pop("issue_pk")
         issue = get_object_or_404(Issue, pk=issue_pk)
         kwargs["issue"] = issue
+        if request.user.is_superuser:
+            return function(request, *args, **kwargs)
         if issue.project.users.filter(pk=request.user.pk).exists():
             return function(request, *args, **kwargs)
 
@@ -52,13 +52,13 @@ def issue_membership_required(function):
 def event_membership_required(function):
     @wraps(function)
     def wrapper(request, *args, **kwargs):
-        if request.user.is_superuser:
-            return function(request, *args, **kwargs)
         if "event_pk" not in kwargs:
             raise TypeError("event_pk must be passed as a keyword argument")
         event_pk = kwargs.pop("event_pk")
         event = get_object_or_404(Event, pk=event_pk)
         kwargs["event"] = event
+        if request.user.is_superuser:
+            return function(request, *args, **kwargs)
         if event.project.users.filter(pk=request.user.pk).exists():
             return function(request, *args, **kwargs)
 

events/urls.py

@@ -1,11 +1,10 @@
 from django.urls import path
 
-from .views import event_download, debug_get_hash
+from .views import event_download
 
 
 urlpatterns = [
     # path('event/<uuid:pk>/', event_detail),  perhaps should become a redirect to issue/.../event now?
     path('event/<uuid:event_pk>/raw/', event_download, kwargs={"as_attachment": False}),
     path('event/<uuid:event_pk>/download/', event_download, kwargs={"as_attachment": True}),
-    path('debug_get_hash/<uuid:event_pk>/', debug_get_hash),
 ]

events/views.py

@@ -1,12 +1,6 @@
-import json
-
-from django.shortcuts import get_object_or_404
 from django.http import HttpResponse
 from django.utils.http import content_disposition_header
 
-from issues.utils import get_hash_for_data
-
-from .models import Event
 from bugsink.decorators import event_membership_required
 
 
@@ -16,13 +10,3 @@ def event_download(request, event, as_attachment=False):
     result["Content-Disposition"] = content_disposition_header(
         as_attachment=as_attachment, filename=event.id.hex + ".json")
     return result
-
-
-def debug_get_hash(request, event_pk):
-    # debug view; not for eternity
-
-    obj = get_object_or_404(Event, pk=event_pk)
-
-    parsed_data = json.loads(obj.data)
-
-    print(get_hash_for_data(parsed_data))