jlengrand/adyen-node-api-library
1
0
Fork 0
mirror of https://github.com/jlengrand/adyen-node-api-library.git synced 2026-03-10 08:01:20 +00:00
Code Issues Packages Projects Releases Wiki Activity

added any back to catch clauses

Browse Source
This commit is contained in:
zaid
2022-06-03 11:23:49 +02:00
parent 32adeb6dc0
commit 65b2ed0875
9 changed files with 58 additions and 60 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/__tests__/binLookup.spec.ts
View File

@@ -79,7 +79,7 @@ describe("Bin Lookup", function (): void {
try {
await binLookup.get3dsAvailability(threeDSAvailabilityRequest as unknown as IBinLookup.ThreeDSAvailabilityRequest);
fail("Expected request to fail");
} catch (e) {
} catch (e: any) {
expect(e instanceof HttpClientException).toBeTruthy();
}
});

6
src/__tests__/checkout.spec.ts
View File

@@ -190,7 +190,7 @@ describe("Checkout", (): void => {
const paymentsRequest: PaymentRequest = createPaymentsCheckoutRequest();
await checkout.payments(paymentsRequest);
} catch (e) {
} catch (e: any) {
expect(e instanceof HttpClientException).toBeTruthy();
}
});
@@ -284,10 +284,8 @@ describe("Checkout", (): void => {
try {
new Checkout(client);
fail();
} catch (e) {
if (e instanceof Error) {
} catch (e: any) {
expect(e.message).toEqual("Please provide your unique live url prefix on the setEnvironment() call on the Client or provide checkoutEndpoint in your config object.");
}
}
});

2
src/__tests__/hmacValidator.spec.ts
View File

@@ -101,7 +101,7 @@ describe("HMAC Validator", function (): void {
};
try {
hmacValidator.validateHMAC(notificationRequestItemNoAdditionalData, key);
} catch(error) {
} catch(error: any) {
expect(error.message).toEqual(`Missing ${ApiConstants.HMAC_SIGNATURE}`);
}
});

6
src/__tests__/httpClient.spec.ts
View File

@@ -43,10 +43,10 @@ const getResponse = async ({apiKey , environment }: { apiKey: string; environmen
try {
await checkout.payments(createPaymentsCheckoutRequest());
fail("request should fail");
} catch (e) {
} catch (e: any) {
expect(e instanceof ErrorException).toBeTruthy();
if (errorMessageEquals && e.message) expect(e.message).toEqual(errorMessageEquals);
if (errorMessageContains && e.message) expect(e.message.toLowerCase()).toContain(errorMessageContains);
if (errorMessageEquals) expect(e.message).toEqual(errorMessageEquals);
if (errorMessageContains) expect(e.message.toLowerCase()).toContain(errorMessageContains);
}
};

42
src/__tests__/modification.spec.ts
View File

@@ -196,7 +196,7 @@ describe("Modification", (): void => {
try {
const result = await modification.amountUpdates(paymentPspReference, request);
expect(result).toBeTruthy();
} catch (e) {
} catch (e: any) {
if(e.message) fail(e.message);
}
});
@@ -210,9 +210,9 @@ describe("Modification", (): void => {
try {
await modification.amountUpdates(invalidPaymentPspReference, request);
} catch (e) {
if(e.statusCode) expect(e.statusCode).toBe(422);
if(e.message) expect(e.message).toContain("Original pspReference required for this operation");
} catch (e: any) {
expect(e.statusCode).toBe(422);
expect(e.message).toContain("Original pspReference required for this operation");
}
});
@@ -224,8 +224,8 @@ describe("Modification", (): void => {
try {
const result = await modification.cancels(paymentPspReference, request);
expect(result).toBeTruthy();
} catch (e) {
if(e.message) fail(e.message);
} catch (e: any) {
fail(e.message);
}
});
@@ -237,9 +237,9 @@ describe("Modification", (): void => {
.reply(422, invalidModificationResult);
try {
await modification.cancels(invalidPaymentPspReference, request);
} catch (e) {
if(e.statusCode) expect(e.statusCode).toBe(422);
if(e.message) expect(e.message).toContain("Original pspReference required for this operation");
} catch (e: any) {
expect(e.statusCode).toBe(422);
expect(e.message).toContain("Original pspReference required for this operation");
}
});
@@ -251,8 +251,8 @@ describe("Modification", (): void => {
try {
const result = await modification.cancelsStandalone(request);
expect(result).toBeTruthy();
} catch (e) {
if(e.message) fail(e.message);
} catch (e: any) {
fail(e.message);
}
});
@@ -264,8 +264,8 @@ describe("Modification", (): void => {
try {
const result = await modification.captures(paymentPspReference, request);
expect(result).toBeTruthy();
} catch (e) {
if(e.message) fail(e.message);
} catch (e: any) {
fail(e.message);
}
});
@@ -277,7 +277,7 @@ describe("Modification", (): void => {
.reply(422, invalidModificationResult);
try {
await modification.captures(invalidPaymentPspReference, request);
} catch (e) {
} catch (e: any) {
if(e.statusCode) expect(e.statusCode).toBe(422);
if(e.message) expect(e.message).toContain("Original pspReference required for this operation");
}
@@ -291,7 +291,7 @@ describe("Modification", (): void => {
try {
const result = await modification.refunds(paymentPspReference, request);
expect(result).toBeTruthy();
} catch (e) {
} catch (e: any) {
if(e.message) fail(e.message);
}
});
@@ -304,9 +304,9 @@ describe("Modification", (): void => {
.reply(422, invalidModificationResult);
try {
await modification.refunds(invalidPaymentPspReference, request);
} catch (e) {
} catch (e: any) {
if(e.statusCode) expect(e.statusCode).toBe(422);
if(e.message) expect(e.message).toContain("Original pspReference required for this operation");
expect(e.message).toContain("Original pspReference required for this operation");
}
});
@@ -318,8 +318,8 @@ describe("Modification", (): void => {
try {
const result = await modification.reversals(paymentPspReference, request);
expect(result).toBeTruthy();
} catch (e) {
if(e.message) fail(e.message);
} catch (e: any) {
fail(e.message);
}
});
@@ -331,9 +331,9 @@ describe("Modification", (): void => {
.reply(422, invalidModificationResult);
try {
await modification.reversals(invalidPaymentPspReference, request);
} catch (e) {
} catch (e: any) {
if(e.statusCode) expect(e.statusCode).toBe(422);
if(e.message) expect(e.message).toContain("Original pspReference required for this operation");
expect(e.message).toContain("Original pspReference required for this operation");
}
});
});

42
src/__tests__/platforms.spec.ts
View File

@@ -244,7 +244,7 @@ describe.skip("Platforms Test E2E", function(): void {
nock.restore();
try {
expect(accountHolder.pspReference).toBeDefined();
} catch (e) {
} catch (e: any) {
assertError(e);
}
});
@@ -255,7 +255,7 @@ describe.skip("Platforms Test E2E", function(): void {
accountHolderCode: accountHolder.accountHolderCode,
});
expect(result.accountHolderDetails.email).toEqual("random_email@example.com");
} catch (e) {
} catch (e: any) {
assertError(e);
}
});
@@ -273,7 +273,7 @@ describe.skip("Platforms Test E2E", function(): void {
}
});
expect(result.accountHolderDetails!.address?.country).toEqual("BE");
} catch (e) {
} catch (e: any) {
assertError(e);
}
});
@@ -287,7 +287,7 @@ describe.skip("Platforms Test E2E", function(): void {
tier: 2
});
expect(result.resultCode).toEqual("Success");
} catch (e) {
} catch (e: any) {
assertError(e);
}
});
@@ -296,7 +296,7 @@ describe.skip("Platforms Test E2E", function(): void {
nock.restore();
try {
expect(account.pspReference).toBeDefined();
} catch (e) {
} catch (e: any) {
assertError(e);
}
});
@@ -314,7 +314,7 @@ describe.skip("Platforms Test E2E", function(): void {
}
});
expect(result.pspReference).toBeDefined();
} catch (e) {
} catch (e: any) {
assertError(e);
}
});
@@ -335,7 +335,7 @@ describe.skip("Platforms Test E2E", function(): void {
accountHolderCode: account.accountHolderCode,
});
expect(result.documentDetails![0].filename).toEqual("IDCardFront.png");
} catch (e) {
} catch (e: any) {
assertError(e);
}
});
@@ -347,7 +347,7 @@ describe.skip("Platforms Test E2E", function(): void {
accountCode: accountToClose.accountCode
});
expect(result.status).toEqual("Closed");
} catch (e) {
} catch (e: any) {
assertError(e);
}
});
@@ -359,7 +359,7 @@ describe.skip("Platforms Test E2E", function(): void {
accountHolderCode: accountHolderToSuspend.accountHolderCode,
});
expect(result.pspReference).toBeDefined();
} catch (e) {
} catch (e: any) {
assertError(e);
}
});
@@ -369,7 +369,7 @@ describe.skip("Platforms Test E2E", function(): void {
try {
const result = await platforms.Account.unSuspendAccountHolder({ accountHolderCode: accountHolderToUnSuspend.accountHolderCode });
expect(result.pspReference).toBeDefined();
} catch (e) {
} catch (e: any) {
assertError(e);
}
});
@@ -383,7 +383,7 @@ describe.skip("Platforms Test E2E", function(): void {
stateType: A.UpdateAccountHolderStateRequest.StateTypeEnum.Payout
});
expect(result.pspReference).toBeDefined();
} catch (e) {
} catch (e: any) {
assertError(e);
}
});
@@ -395,7 +395,7 @@ describe.skip("Platforms Test E2E", function(): void {
accountHolderCode: accountHolderToClose.accountHolderCode
});
expect(result.pspReference).toBeDefined();
} catch (e) {
} catch (e: any) {
assertError(e);
}
});
@@ -409,7 +409,7 @@ describe.skip("Platforms Test E2E", function(): void {
year: 2020
});
expect(result.content).toBeDefined();
} catch (e) {
} catch (e: any) {
assertError(e);
}
});
@@ -423,7 +423,7 @@ describe.skip("Platforms Test E2E", function(): void {
accountHolderCode: generateRandomCode()
});
expect(result.balancePerAccount![0].detailBalance).toBeDefined();
} catch (e) {
} catch (e: any) {
assertError(e);
}
});
@@ -435,7 +435,7 @@ describe.skip("Platforms Test E2E", function(): void {
accountHolderCode: generateRandomCode()
});
expect(result.accountTransactionLists![0].transactions).toBeDefined();
} catch (e) {
} catch (e: any) {
assertError(e);
}
});
@@ -453,7 +453,7 @@ describe.skip("Platforms Test E2E", function(): void {
transferCode: "SUBSCRIPTION"
});
expect(result.pspReference).toBeDefined();
} catch (e) {
} catch (e: any) {
assertError(e);
}
});
@@ -468,7 +468,7 @@ describe.skip("Platforms Test E2E", function(): void {
const result = await platforms.NotificationConfiguration.getNotificationConfigurationList({});
const resultStr = JSON.stringify(result);
expect(resultStr.includes("pspReference")).toBeTruthy();
} catch (e) {
} catch (e: any) {
assertError(e);
}
});
@@ -483,7 +483,7 @@ describe.skip("Platforms Test E2E", function(): void {
}
});
expect(result.configurationDetails.active).toBeTruthy();
} catch (e) {
} catch (e: any) {
assertError(e);
}
});
@@ -496,7 +496,7 @@ describe.skip("Platforms Test E2E", function(): void {
notificationId: configurationID
});
expect(result.configurationDetails.notifyURL).toEqual("https://www.adyen.com/notification-handler");
} catch (e) {
} catch (e: any) {
assertError(e);
}
});
@@ -522,7 +522,7 @@ describe.skip("Platforms Test E2E", function(): void {
});
const accountHolderVerification = result.configurationDetails.eventConfigs.filter(event => event.eventType === "ACCOUNT_HOLDER_VERIFICATION")[0];
expect(accountHolderVerification.includeMode).toEqual("EXCLUDE");
} catch (e) {
} catch (e: any) {
assertError(e);
}
});
@@ -534,7 +534,7 @@ describe.skip("Platforms Test E2E", function(): void {
try {
const result = await platforms.NotificationConfiguration.deleteNotificationConfigurations({notificationIds});
expect(result.pspReference).toBeDefined();
} catch (e) {
} catch (e: any) {
assertError(e);
}
});

12
src/__tests__/recurring.spec.ts
View File

@@ -97,8 +97,8 @@ describe("Recurring", (): void => {
try {
const result = await recurring.disable(request);
expect(result).toBeTruthy();
} catch (e) {
if(e.message) fail(e.message);
} catch (e: any) {
fail(e.message);
}
});
@@ -123,8 +123,8 @@ describe("Recurring", (): void => {
try {
const result = await recurring.notifyShopper(notifyShopperRequest);
expect(result).toBeTruthy();
} catch (e) {
if(e.message) fail(e.message);
} catch (e: any) {
fail(e.message);
}
});
@@ -154,8 +154,8 @@ describe("Recurring", (): void => {
try {
const result = await recurring.scheduleAccountUpdater(request);
expect(result).toBeTruthy();
} catch (e) {
if(e.message) fail(e.message);
} catch (e: any) {
fail(e.message);
}
});
});

4
src/__tests__/terminalLocalAPI.spec.ts
View File

@@ -79,9 +79,9 @@ describe("Terminal Local API", (): void => {
try {
await terminalLocalAPI.request(terminalAPIPaymentRequest, securityKey);
} catch (e) {
} catch (e: any) {
expect(e instanceof NexoCryptoException);
if(e.message) expect(e.message).toEqual("Hmac validation failed");
expect(e.message).toEqual("Hmac validation failed");
}
});
});

2
src/httpClient/httpURLConnectionClient.ts
View File

@@ -195,7 +195,7 @@ class HttpURLConnectionClient implements ClientInterface {
checkServerIdentity,
};
} catch (e) {
} catch (e: any) {
return Promise.reject(new HttpClientException({ message: `Error loading certificate from path: ${e.message}` }));
}