Update notification tests to clearly document and verify that:
- Custom notification commands have NO whitelist and NO validation
- ANY executable path, binary name, or arguments are allowed
- Shell pipelines with redirects and pipes are fully supported
Also rename TTS terminology to generic notification terminology:
- resetTtsState → resetNotificationState
- getTtsQueueLength → getNotificationQueueLength
- getActiveTtsCount → getActiveNotificationCount
- clearTtsQueue → clearNotificationQueue
- getTtsMaxQueueSize → getNotificationMaxQueueSize
- Add onCommandCompleted alongside deprecated onTtsCompleted
This ensures the feature remains open-ended for user flexibility.
Without preventing default on both dragover and drop at the document level,
Electron/Chromium can reject subsequent drag-and-drop operations after the
first drop. This adds document-level handlers that call preventDefault() on
both events, ensuring the drop zone remains valid across multiple operations.
- Remove TTS command whitelist validation - users can now configure any
command for custom notifications (e.g., fabric piped to 11s)
- Enable shell mode for spawn to support pipes and command chains
- Add visual feedback to Test button (running/success/error states)
- Remove speech bubble from AI response messages in TerminalOutput
- Rename internal TTS terminology to more generic "notification command"
- Update tests to reflect new behavior
Fixes overlay not covering sidebar and file panel by rendering the
modal via React portal to document.body, ensuring proper z-index
stacking across all UI layers.
Stats DB initialization failures were only logged locally, providing no
visibility into production issues. This change adds Sentry reporting for:
- Database corruption detection (integrity check failures)
- Native module loading failures (architecture mismatches)
- Database creation failures
- General initialization failures
Created reusable Sentry utilities in src/main/utils/sentry.ts that
lazily load @sentry/electron to avoid module initialization issues.
Add comprehensive crash detection for renderer process failures that
Sentry in the renderer cannot capture (because the process is dead,
broken, or failed before Sentry initialized):
- render-process-gone: captures crash, kill, OOM, launch-failed
- unresponsive/responsive: tracks frozen window states
- crashed: handles page-level crashes
- did-fail-load: captures page load failures (network, invalid URLs)
- preload-error: captures preload script failures before app loads
- console-message: forwards critical renderer errors (TypeError, etc.)
Reports to Sentry from main process with detailed context.
Auto-reloads renderer after non-intentional crashes.
When users select "All" for Max Output Lines, Infinity is stored but
JSON.stringify(Infinity) produces null. On app restart, this null value
was being loaded directly, causing:
- null * 1.5 = 0 for maxHeight calculation
- All AI responses appearing fully collapsed (only "Show all X lines")
Now we detect null values for maxOutputLines and restore them as
Infinity, matching the user's original "All" selection.
Root cause: JSON cannot represent Infinity, so it becomes null during
serialization to electron-store.
Fixes the regression where maxOutputLines setting was lost on restart.
Add a save icon to the action buttons at the bottom of AI responses
that opens a modal allowing users to save the markdown content to a
file. The modal includes:
- Folder path input with a browse button for filesystem navigation
- Filename input with automatic .md extension handling
- Error handling and validation
- Remove "Pencil" and "Image" labels to show icon-only for those controls
- Update Thinking description to "toggles display of agent thinking"
- Make label prop optional in TourIcon component
- Convert tourSteps.ts to tourSteps.tsx to support JSX content
- Add descriptionContent/descriptionContentGeneric fields to TourStepConfig
for rendering JSX after the text description
- Create TourIcon component that renders actual Lucide icons inline
- Update input area step to show PenLine, ImageIcon, History, Eye, Brain,
and Keyboard icons matching the actual UI controls
- Widen tooltip to 480px when step has extra JSX content
- Restore original description text, move icon explanations to JSX content
When loading remote content (e.g., README.md from SSH), the loading
indicator now takes over the entire main panel instead of showing
alongside the terminal output. This prevents the awkward half-filled
appearance.
Apply the same fix from the marketplace handlers to Symphony:
- getRegistry: Falls back to expired cache when GitHub fetch fails
- getIssues: Falls back to expired cache when GitHub fetch fails
This prevents showing empty data when the network is unavailable
but valid (though expired) cache data exists.
When the Playbook Exchange modal opens and the manifest cache is expired,
we attempt to fetch fresh data from GitHub. Previously, if this fetch
failed (network error, timeout, etc.), we would return an empty manifest
showing "No playbooks available" - a confusing UX.
Now we fall back to the expired cache data if available, which is better
than showing nothing. This ensures users can still browse playbooks even
when GitHub is temporarily unreachable.
Changes:
- getManifest: Fall back to expired cache when fresh fetch fails
- refreshManifest: Fall back to existing cache when refresh fails
- Added tests for new fallback behavior
Add hints across implementation-focused prompts to encourage searching
for existing code patterns before creating new implementations. This
addresses the issue of duplicate code being generated by guiding agents
to reuse and extend existing utilities, helpers, and patterns.
Updated prompts:
- autorun-default.md: Task implementation now searches for existing code first
- maestro-system-prompt.md: New "Code Reuse and Refactoring" section
- wizard-document-generation.md: Tasks should be reuse-aware, phases include guidance
- speckit.tasks.md: New "Code Reuse Principle" section before task generation
- speckit.implement.md: Task guidelines include reuse-awareness
- openspec.implement.md: Task guidelines include reuse-awareness
Update input area tour step to describe each icon with visual hints that
match the actual Lucide icons used in the input area. Also update
TourStep component to properly render newlines as line breaks so the
bulleted list of icons displays correctly.
Icons now described:
- Pencil (✎) for expanded prompt editor
- Image (🖼) for file attachments
- History (⏱) for session history toggle
- Eye (👁) for read-only mode
- Brain (🧠) for extended thinking
- Keyboard (⌨) for submit hotkey toggle
Add comprehensive description of input area features during introductory
tour including expanded prompt editor (pencil icon), image attachments,
and toggle buttons for History, Read-Only, and Thinking modes. Also
mention the submission hotkey option and link to Settings for defaults.
Use flexbox layout with flex-shrink-0 on header and sash elements to
prevent them from being clipped. The scrollable entries section now
uses flex-1 min-h-0 to take remaining space while allowing proper
overflow scrolling.
When the computer goes to sleep and wakes up, some settings like
MAX OUTPUT LINES PER RESPONSE were resetting to default values.
This adds Electron's powerMonitor to detect system resume events and
notify the renderer to reload settings from persistent storage:
- Add powerMonitor.on('resume') listener in main process
- Add onSystemResume IPC handler in preload API
- Refactor loadSettings to useCallback for reuse
- Register system resume listener in useSettings hook
Closes#269
Claude Code reliably emits tool execution events in stream-json format,
but Codex and OpenCode may not emit parseable tool events or may answer
from context without using tools.
Updated the 'should emit tool execution events' and 'should track tool
execution state transitions' tests to only assert tool event requirements
for Claude Code, while keeping informational logging for other providers.
The tests still verify the core functionality (correct response) for all
providers, but tool event parsing is now provider-specific.
Fixes integration test failure for Codex tool execution events.
Some git clients produce malformed URLs that mix HTTPS and SSH formats
(e.g., `https://git@github.com:user/repo`). These URLs would cause
window.open() to fail with an invalid URL error.
Added handling to convert these hybrid URLs to proper HTTPS format.
Fixes MAESTRO-43
Move React DevTools profiling instructions from CLAUDE-PERFORMANCE.md
to CONTRIBUTING.md under the Profiling section:
- Full installation and launch commands
- Components and Profiler tab descriptions
- Step-by-step profiler workflow
- Chrome DevTools Performance tab guidance
CLAUDE-PERFORMANCE.md now references CONTRIBUTING.md for profiling
workflow (keeping it focused on code patterns for AI).
Claude ID: 286ae250-379b-4b74-a24e-b23e907dba0b
Maestro ID: b9bc0d08-5be2-4fdf-93cd-5618a8d53b35
Document the standalone React DevTools app for render profiling:
- Installation and launch commands
- Auto-connection via script in src/renderer/index.html
- Components and Profiler tab descriptions
- Basic profiler workflow for identifying render issues
Claude ID: 286ae250-379b-4b74-a24e-b23e907dba0b
Maestro ID: b9bc0d08-5be2-4fdf-93cd-5618a8d53b35
Document how to use the standalone React DevTools app for component
inspection and render profiling. The connection script already exists
in src/renderer/index.html but wasn't documented.
Claude ID: 286ae250-379b-4b74-a24e-b23e907dba0b
Maestro ID: b9bc0d08-5be2-4fdf-93cd-5618a8d53b35
- Test button is inline within Ungrouped Agents header when ungrouped sessions exist
- Test button is standalone (full-width) when no ungrouped sessions exist
- Prevents regression of button placement behavior
## Windows Command Line Length Fix
Resolved 'Die Befehlszeile ist zu lang' (command line too long) error on Windows by:
- Modified inline document generation to use sendPromptViaStdin on Windows
- Passes prompt via stdin instead of as command line argument
- Bypasses Windows cmd.exe ~8KB command line length limit
- Matches approach already used for SSH remote execution
- Added --input-format stream-json when using stdin with stream-json compatible agents
- Added logging for prompt length and stdin usage for debugging
## OpenCode Agent Support
Extended inline wizard to support OpenCode agent alongside Claude Code and Codex:
- Added 'opencode' to supported wizard agents list in useInlineWizard hook
- OpenCode batch mode args handling already present in buildArgsForAgent functions
- Added SSH-aware availability checking in both conversation and document generation phases
## SSH Remote Configuration
Improved SSH remote session handling:
- Added sessionSshRemoteConfig to DocumentGenerationConfig interface
- Added sendPromptViaStdin and sendPromptViaStdinRaw to renderer ProcessConfig
- Pass sessionSshRemoteConfig through entire wizard lifecycle (conversation → document generation)
- Skip local agent availability checks when executing on remote hosts
- Use agent type as command fallback for remote-only agents
- Added logging to distinguish remote execution from local
## Remote Agent Availability Fix
Fixed critical bug preventing remote SSH agents from being used:
- Split agent availability checks to allow null agents for remote sessions
- For remote sessions: skip both null-check AND availability-check
- For local sessions: enforce both checks as before
- Allows remote-only agents (like SSH-configured OpenCode) to work for both conversation and document generation
## Test Updates
- Fixed useInlineWizard.test.ts by adding window.maestro.agents.get mock
- Mock returns agent info needed for availability checks
- Added comprehensive test coverage for remote agent scenarios
- Move Top and Bottom navigation buttons outside the scrollable section
- Add distinct background styling with accent color tint
- Add border separators for visual hierarchy (border-b for Top, border-t for Bottom)
- Reduce scrollable section height to account for fixed sash buttons
- Add data-testid attributes for testing
- Add test coverage for sash button visibility and functionality
- When ungrouped agents exist: inline button in header (like Group Chats)
- When no ungrouped agents: standalone full-width button (folder hidden)
- When no groups exist (flat list): standalone full-width button below sessions
- Added “View Git Log” action right inside GitStatusWidget tooltip 🧭
- Wired MainPanel to open Git Log directly from the widget 🪟
- Expanded GitStatusWidget API with optional `onViewLog` callback 🧩
- Improved test coverage for Git log tooltip interactions and rendering 🧪
- Cleaned repo by removing auto-generated CLAUDE.md memory context files 🧹
- Enhanced release notes frontmatter with a new newspaper icon 🗞️
- Preview panel now supports back/forward history with arrow-key navigation 🧭
- Added slick chevron buttons for preview back/forward with disabled states 🔙
- Wiki-link resolution now scans *all* markdown files, not just graphed ones 🗂️
- Graph data builder now pre-scans markdown paths for faster preview linking 🔎
- Stats dashboards gained a new “This Quarter” time range everywhere 📆
- Activity heatmap adds quarter support with richer 4-hour block granularity 🧱
- Brand-new Agent Efficiency chart compares average response time per agent ⏱️
- New Weekday vs Weekend comparison chart highlights productivity patterns 🗓️
- New “Tasks by Time of Day” chart surfaces Auto Run hourly hotspots 🌙
- Modal PR link is now keyboard-accessible and opens externally safely ♿
When sendPromptViaStdin or sendPromptViaStdinRaw is set, the prompt
will be sent via stdin as stream-json data. The ChildProcessSpawner
was incorrectly ALSO adding the prompt to the command line args,
causing shell escaping issues with zsh on remote hosts.
This fix skips adding the prompt to args when it will be sent via
stdin, preventing:
- "zsh:35: parse error near 'do'" from multi-line prompts
- "zsh:3: no matches found: **Summary:**" from glob-like patterns
The prompt still gets sent correctly via stdin in the isStreamJsonMode
block at line 389+.
When zsh/bash parse errors are detected, log the pattern source,
matched text, and line preview to help diagnose where the error
is coming from. Also log detailed stderr/stdout info before
SSH error pattern matching at process exit.
Embedding prompts in the SSH command line caused persistent failures
with "zsh:35: parse error" on remote hosts using zsh. The issue was
that prompts with newlines create multi-line bash -c arguments that
zsh parses incorrectly before bash can interpret them.
This fix removes the 4000-char threshold and always sends prompts via
stdin (using --input-format stream-json) for SSH remote execution.
This completely bypasses all shell escaping issues:
- No more quote escaping through multiple shell layers
- No more issues with embedded newlines in prompts
- No more problems with special characters like $, !, etc.
The root cause of the persistent "zsh:35: parse error" was that SSH passes
the command to the remote's login shell (zsh) which parses it before bash
runs. Double quotes allowed zsh to interpret $, `, \, etc. within the command.
Solution: Wrap the entire bash -c argument in single quotes. Single quotes
are parsed literally by zsh - it passes the content to bash unchanged.
Changes:
- Use shellEscape() to wrap the bash command in single quotes
- Remove shellEscapeForDoubleQuotes (no longer needed)
- Update pathSetup to use unescaped double quotes (they're inside single quotes)
- Update tests to expect new escaping format
This works because:
1. SSH sends: /bin/bash --norc --noprofile -c 'export PATH=... && cmd'
2. zsh sees single quotes, doesn't parse the content, executes /bin/bash
3. bash receives the literal content and executes it
The pathPrefix string contained unescaped double quotes which broke the
outer -c "..." wrapper when SSH passed the command to zsh on the remote.
The quotes are now escaped as \" so they survive the shell parsing layers.
Before: export PATH="$HOME/..." (breaks outer double-quote context)
After: export PATH=\"$HOME/...\" (properly nested)
Updated the prompt escaping test to match the actual output format when
prompts go through both shellEscape and shellEscapeForDoubleQuotes layers:
- $PATH becomes \$PATH (to prevent variable expansion)
- Single quotes become '\\'' (backslash escaping within double-quoted context)
SSH passes commands to the remote's login shell (zsh on this system)
which parses them. Using just 'bash' still causes zsh to source its
profile files while resolving the command path, triggering the
"zsh:35: parse error" from .zshrc.
Using /bin/bash directly bypasses this - zsh executes the absolute
path without sourcing any profile files first.
- Add error pattern for zsh/bash parse errors that occur when remote
profile files have incompatible syntax (e.g., "zsh:35: parse error")
- Improve SSH error detection to check BOTH stdout and stderr, since
shell errors often appear in stdout
- Log SSH failures at INFO/WARN level with stdout/stderr previews
for better debugging visibility
- Add fallback logging for SSH failures that don't match known patterns
Profile files (bash_profile, profile) often chain to zsh or contain
syntax incompatible with -c embedding, causing "zsh:35: parse error"
or command-not-found errors.
New approach uses `bash --norc --noprofile -c` with explicit PATH setup:
- ~/.local/bin (Claude Code, pip --user)
- ~/bin (user scripts)
- /usr/local/bin (Homebrew Intel, manual installs)
- /opt/homebrew/bin (Homebrew Apple Silicon)
- ~/.cargo/bin (Rust tools)
This completely avoids sourcing any profile files while ensuring
agent binaries are found in common installation locations.
The previous fix removed the shell wrapper entirely, which broke PATH
resolution for user-installed binaries like 'claude' in ~/.local/bin.
Exit code 127 (command not found) occurred because SSH's non-login
execution doesn't load profile files.
Now using "bash -lc" instead of "$SHELL -lc":
- bash is universally available on macOS/Linux
- bash -l sources /etc/profile, ~/.bash_profile, ~/.profile for PATH
- bash profile files rarely have syntax incompatible with -c embedding
- Avoids zsh profile issues (loops/conditionals that break -c embedding)
The double-quote escaping ensures $ variables in the inner command are
passed literally and evaluated by bash, not by SSH's outer shell.
Remove the $SHELL -ilc wrapper from SSH command building. This fixes
the "zsh:35: parse error near 'do'" error that occurred when user
profile files (.zshrc, .zprofile) contained syntax that couldn't be
embedded in a -c command string.
SSH executes commands through the remote's login shell by default,
which provides PATH from /etc/profile. The direct command approach
is simpler and more reliable across different shell configurations.
Also:
- Update tests to reflect that $ escaping is no longer needed (single
quotes already prevent variable expansion)
- Improve logging from debug to info level for visibility
