jlengrand/Maestro
1
0
Fork 0
mirror of https://github.com/jlengrand/Maestro.git synced 2026-03-10 08:31:19 +00:00
Code Issues Packages Projects Releases Wiki Activity

MAESTRO: Add comprehensive middle-click tests for file tabs

Browse Source 
- Verified FileTab's handleMouseDown correctly handles button === 1 (middle-click)
- Added test: left-click does NOT close file tab
- Added test: right-click does NOT close file tab
- Added test: middle-click on AI tab still works in unified mode
- All 115 TabBar tests pass
This commit is contained in:
Pedram Amini
2026-02-02 04:11:51 -06:00
parent f414bf4dd9
commit e7960ad3b2
1 changed files with 81 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

81
src/__tests__/renderer/components/TabBar.test.tsx
View File

@@ -3545,6 +3545,87 @@ describe('Unified tabs drag and drop', () => {
expect(mockOnFileTabClose).toHaveBeenCalledWith('file-tab-1');
});
it('left-click does NOT close file tab', () => {
render(
<TabBar
tabs={aiTabs}
activeTabId="ai-tab-1"
theme={mockTheme}
onTabSelect={vi.fn()}
onTabClose={vi.fn()}
onNewTab={vi.fn()}
onUnifiedTabReorder={mockOnUnifiedTabReorder}
unifiedTabs={unifiedTabs}
activeFileTabId={null}
onFileTabSelect={mockOnFileTabSelect}
onFileTabClose={mockOnFileTabClose}
/>
);
const fileTabElement = screen.getByText('file1').closest('[data-tab-id]')!;
// Left-click on file tab (button: 0)
fireEvent.mouseDown(fileTabElement, { button: 0 });
// Should NOT close the tab
expect(mockOnFileTabClose).not.toHaveBeenCalled();
});
it('right-click does NOT close file tab', () => {
render(
<TabBar
tabs={aiTabs}
activeTabId="ai-tab-1"
theme={mockTheme}
onTabSelect={vi.fn()}
onTabClose={vi.fn()}
onNewTab={vi.fn()}
onUnifiedTabReorder={mockOnUnifiedTabReorder}
unifiedTabs={unifiedTabs}
activeFileTabId={null}
onFileTabSelect={mockOnFileTabSelect}
onFileTabClose={mockOnFileTabClose}
/>
);
const fileTabElement = screen.getByText('file1').closest('[data-tab-id]')!;
// Right-click on file tab (button: 2)
fireEvent.mouseDown(fileTabElement, { button: 2 });
// Should NOT close the tab
expect(mockOnFileTabClose).not.toHaveBeenCalled();
});
it('middle-click on AI tab still works in unified mode', () => {
const mockOnAiTabClose = vi.fn();
render(
<TabBar
tabs={aiTabs}
activeTabId="ai-tab-1"
theme={mockTheme}
onTabSelect={vi.fn()}
onTabClose={mockOnAiTabClose}
onNewTab={vi.fn()}
onUnifiedTabReorder={mockOnUnifiedTabReorder}
unifiedTabs={unifiedTabs}
activeFileTabId={null}
onFileTabSelect={mockOnFileTabSelect}
onFileTabClose={mockOnFileTabClose}
/>
);
const aiTabElement = screen.getByText('AI Tab 1').closest('[data-tab-id]')!;
// Middle-click on AI tab
fireEvent.mouseDown(aiTabElement, { button: 1 });
// Should call the AI tab close handler, not file tab close handler
expect(mockOnAiTabClose).toHaveBeenCalledWith('ai-tab-1');
expect(mockOnFileTabClose).not.toHaveBeenCalled();
});
});
describe('Unified active tab styling consistency', () => {