jlengrand/Maestro
1
0
Fork 0
mirror of https://github.com/jlengrand/Maestro.git synced 2026-03-10 08:31:19 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: TTS command now properly parses arguments

Browse Source 
The TTS command field was only using the first word as the command,
ignoring any arguments. Now properly parses the full command string
to extract the command and its arguments (e.g., "11s --voice xyz").
This commit is contained in:
Pedram Amini
2025-11-26 17:29:55 -06:00
parent c526e2a77b
commit bb27b4cb7b
1 changed files with 9 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/main/index.ts
View File

@@ -1336,11 +1336,17 @@ function setupIpcHandlers() {
ipcMain.handle('notification:speak', async (_event, text: string, command?: string) => {
try {
const { spawn } = await import('child_process');
const ttsCommand = command || 'say'; // Default to macOS 'say' command
const fullCommand = command || 'say'; // Default to macOS 'say' command
// Parse command string to extract command and arguments
// Handles paths with spaces if quoted, and preserves arguments
const parts = fullCommand.match(/(?:[^\s"]+|"[^"]*")+/g) || [fullCommand];
const ttsCommand = parts[0].replace(/^"|"$/g, ''); // Remove surrounding quotes if present
const ttsArgs = parts.slice(1).map(arg => arg.replace(/^"|"$/g, '')); // Remove quotes from args
// Spawn the TTS process without waiting for it to complete (non-blocking)
// This runs in the background and won't block the main process
const child = spawn(ttsCommand, [], {
const child = spawn(ttsCommand, ttsArgs, {
stdio: ['pipe', 'ignore', 'ignore'],
detached: true, // Run independently
});
@@ -1352,7 +1358,7 @@ function setupIpcHandlers() {
// Unref to allow the parent to exit independently
child.unref();
logger.debug('Started audio feedback', 'Notification', { command: ttsCommand, textLength: text.length });
logger.debug('Started audio feedback', 'Notification', { command: ttsCommand, args: ttsArgs, textLength: text.length });
return { success: true };
} catch (error) {
logger.error('Error starting audio feedback', 'Notification', error);