mirror of
https://github.com/jlengrand/Maestro.git
synced 2026-03-10 00:21:21 +00:00
chore: address PR review feedback
- Add troubleshooting section for pre-commit hooks in CONTRIBUTING.md - Make prepare script resilient for CI/Docker: husky || true - Update .prettierignore to exclude coverage/ and *.min.js
This commit is contained in:
@@ -1,4 +1,5 @@
|
||||
dist/
|
||||
release/
|
||||
node_modules/
|
||||
*.md
|
||||
coverage/
|
||||
*.min.js
|
||||
|
||||
@@ -213,6 +213,11 @@ git commit --no-verify -m "emergency fix"
|
||||
npx lint-staged
|
||||
```
|
||||
|
||||
**Troubleshooting:**
|
||||
- **Hooks not running** — Check if `.husky/pre-commit` has executable permissions: `chmod +x .husky/pre-commit`
|
||||
- **Wrong tool version** — Ensure `npx` is using local `node_modules`: delete `node_modules` and run `npm install`
|
||||
- **Hook fails in CI/Docker** — The `prepare` script uses `husky || true` to gracefully skip in environments without `.git`
|
||||
|
||||
### Manual Linting
|
||||
|
||||
Run TypeScript type checking and ESLint to catch errors before building:
|
||||
|
||||
@@ -35,7 +35,7 @@
|
||||
"package:linux": "node scripts/set-version.mjs npm run build && node scripts/set-version.mjs electron-builder --linux",
|
||||
"start": "electron .",
|
||||
"clean": "rm -rf dist release node_modules/.vite",
|
||||
"prepare": "husky",
|
||||
"prepare": "husky || true",
|
||||
"postinstall": "electron-rebuild -f -w node-pty,better-sqlite3",
|
||||
"lint": "tsc -p tsconfig.lint.json && tsc -p tsconfig.main.json --noEmit && tsc -p tsconfig.cli.json --noEmit",
|
||||
"lint:eslint": "eslint src/",
|
||||
|
||||
Reference in New Issue
Block a user