From 491cef67fa143caae2d8bd44f45daf07d71d30bf Mon Sep 17 00:00:00 2001 From: Raza Rauf Date: Tue, 20 Jan 2026 00:11:22 +0500 Subject: [PATCH] chore: address PR review feedback - Add troubleshooting section for pre-commit hooks in CONTRIBUTING.md - Make prepare script resilient for CI/Docker: husky || true - Update .prettierignore to exclude coverage/ and *.min.js --- .prettierignore | 3 ++- CONTRIBUTING.md | 5 +++++ package.json | 2 +- 3 files changed, 8 insertions(+), 2 deletions(-) diff --git a/.prettierignore b/.prettierignore index 7965bf9e..0396659b 100644 --- a/.prettierignore +++ b/.prettierignore @@ -1,4 +1,5 @@ dist/ release/ node_modules/ -*.md +coverage/ +*.min.js diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index fa8eb068..fc6f442f 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -213,6 +213,11 @@ git commit --no-verify -m "emergency fix" npx lint-staged ``` +**Troubleshooting:** +- **Hooks not running** — Check if `.husky/pre-commit` has executable permissions: `chmod +x .husky/pre-commit` +- **Wrong tool version** — Ensure `npx` is using local `node_modules`: delete `node_modules` and run `npm install` +- **Hook fails in CI/Docker** — The `prepare` script uses `husky || true` to gracefully skip in environments without `.git` + ### Manual Linting Run TypeScript type checking and ESLint to catch errors before building: diff --git a/package.json b/package.json index fc30d758..a2a0df30 100644 --- a/package.json +++ b/package.json @@ -35,7 +35,7 @@ "package:linux": "node scripts/set-version.mjs npm run build && node scripts/set-version.mjs electron-builder --linux", "start": "electron .", "clean": "rm -rf dist release node_modules/.vite", - "prepare": "husky", + "prepare": "husky || true", "postinstall": "electron-rebuild -f -w node-pty,better-sqlite3", "lint": "tsc -p tsconfig.lint.json && tsc -p tsconfig.main.json --noEmit && tsc -p tsconfig.cli.json --noEmit", "lint:eslint": "eslint src/",