jlengrand/Maestro
1
0
Fork 0
mirror of https://github.com/jlengrand/Maestro.git synced 2026-03-10 08:31:19 +00:00
Code Issues Packages Projects Releases Wiki Activity

chore: address PR review feedback

Browse Source 
- Add troubleshooting section for pre-commit hooks in CONTRIBUTING.md
- Make prepare script resilient for CI/Docker: husky || true
- Update .prettierignore to exclude coverage/ and *.min.js
This commit is contained in:
Raza Rauf
2026-01-20 00:11:22 +05:00
parent 5773691dbe
commit 491cef67fa
3 changed files with 8 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
.prettierignore
View File

@@ -1,4 +1,5 @@
dist/ dist/
release/ release/
node_modules/ node_modules/
*.md coverage/
*.min.js

5
CONTRIBUTING.md
View File

@@ -213,6 +213,11 @@ git commit --no-verify -m "emergency fix"
npx lint-staged npx lint-staged
``` ```
**Troubleshooting:**
- **Hooks not running** — Check if `.husky/pre-commit` has executable permissions: `chmod +x .husky/pre-commit`
- **Wrong tool version** — Ensure `npx` is using local `node_modules`: delete `node_modules` and run `npm install`
- **Hook fails in CI/Docker** — The `prepare` script uses `husky || true` to gracefully skip in environments without `.git`
### Manual Linting ### Manual Linting
Run TypeScript type checking and ESLint to catch errors before building: Run TypeScript type checking and ESLint to catch errors before building:

2
package.json
View File

@@ -35,7 +35,7 @@
"package:linux": "node scripts/set-version.mjs npm run build && node scripts/set-version.mjs electron-builder --linux", "package:linux": "node scripts/set-version.mjs npm run build && node scripts/set-version.mjs electron-builder --linux",
"start": "electron .", "start": "electron .",
"clean": "rm -rf dist release node_modules/.vite", "clean": "rm -rf dist release node_modules/.vite",
"prepare": "husky", "prepare": "husky || true",
"postinstall": "electron-rebuild -f -w node-pty,better-sqlite3", "postinstall": "electron-rebuild -f -w node-pty,better-sqlite3",
"lint": "tsc -p tsconfig.lint.json && tsc -p tsconfig.main.json --noEmit && tsc -p tsconfig.cli.json --noEmit", "lint": "tsc -p tsconfig.lint.json && tsc -p tsconfig.main.json --noEmit && tsc -p tsconfig.cli.json --noEmit",
"lint:eslint": "eslint src/", "lint:eslint": "eslint src/",