Fix entity update by spring-transaction (#272)

spring-transaction/src/main/kotlin/org/jetbrains/exposed/spring/SpringTransactionManager.kt

@@ -9,6 +9,7 @@ import org.springframework.jdbc.datasource.ConnectionHolder
 import org.springframework.jdbc.datasource.DataSourceTransactionManager
 import org.springframework.transaction.TransactionDefinition
 import org.springframework.transaction.support.DefaultTransactionDefinition
+import org.springframework.transaction.support.DefaultTransactionStatus
 import org.springframework.transaction.support.TransactionSynchronizationManager
 import java.sql.Connection
 import javax.sql.DataSource
@@ -41,6 +42,10 @@ class SpringTransactionManager(dataSource: DataSource,
         return super.doSuspend(transaction)
     }
 
+    override fun doCommit(status: DefaultTransactionStatus?) {
+        currentOrNull()?.commit()
+    }
+
     override fun newTransaction(isolation: Int): Transaction {
         val tDefinition = if (dataSource.connection.transactionIsolation != isolation) {
             DefaultTransactionDefinition().apply { isolationLevel = isolation }

spring-transaction/src/test/kotlin/org.jetbrains.exposed.spring/EntityUpdateTest.kt

@@ -0,0 +1,59 @@
+package org.jetbrains.exposed.spring
+
+import org.jetbrains.exposed.dao.EntityID
+import org.jetbrains.exposed.dao.IntEntity
+import org.jetbrains.exposed.dao.IntEntityClass
+import org.jetbrains.exposed.dao.IntIdTable
+import org.jetbrains.exposed.sql.SchemaUtils
+import org.jetbrains.exposed.sql.insert
+import org.junit.Assert
+import org.junit.FixMethodOrder
+import org.junit.Test
+import org.junit.runner.RunWith
+import org.junit.runners.MethodSorters
+import org.springframework.test.annotation.Commit
+import org.springframework.test.context.ContextConfiguration
+import org.springframework.test.context.junit4.SpringJUnit4ClassRunner
+import org.springframework.transaction.annotation.Transactional
+import kotlin.test.fail
+
+@RunWith(SpringJUnit4ClassRunner::class)
+@ContextConfiguration(classes = [TestConfig::class])
+@FixMethodOrder(MethodSorters.NAME_ASCENDING)
+@Transactional
+open class EntityUpdateTest {
+
+    object t1 : IntIdTable() {
+        val c1 = varchar("c1", Int.MIN_VALUE.toString().length)
+    }
+
+    class dao(id: EntityID<Int>) : IntEntity(id) {
+        companion object : IntEntityClass<dao>(t1)
+        var c1 by t1.c1
+    }
+
+    @Test
+    @Commit
+    fun test1() {
+        SchemaUtils.create(t1)
+        t1.insert {
+            it[t1.c1] = "new"
+        }
+        Assert.assertEquals("new", dao.findById(1)?.c1)
+    }
+
+    @Test
+    @Commit
+    fun test2() {
+        val entity = dao.findById(1) ?: fail()
+        entity.c1 = "updated"
+        Assert.assertEquals("updated", dao.findById(1)?.c1)
+    }
+
+    @Test
+    fun test3() {
+        val entity = dao.findById(1) ?: fail()
+        Assert.assertEquals("updated", entity.c1)
+        SchemaUtils.drop(t1)
+    }
+}