jlengrand/5GUIs-1
1
0
Fork 0
mirror of https://github.com/jlengrand/5GUIs-1.git synced 2026-03-10 08:01:25 +00:00
Code Issues Packages Projects Releases Wiki Activity

Do not launch objdump in shell

Browse Source 
... no point, just produces escaping issues.
This commit is contained in:
Helge Heß
2020-10-02 15:21:31 +02:00
parent aa3141ef3b
commit 232bb7bfce
1 changed files with 7 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
Sources/5GUIs/Utilities/OTool.swift
View File

@@ -116,9 +116,14 @@ private func run(objdump: String, against url: URL,
private func run(objdump: String, against url: URL) throws -> [ String ] {
// bash escaping
let result = Process.launch(at: objdump,
with: [ "-macho", "--dylibs-used", "'\(url.path)'" ])
with: [ "-macho", "--dylibs-used", url.path ],
using: .none /* no shell */)
guard result.status == 0 else {
print("ERROR: objdump result:", result)
// status is 4 on signing errors (illegal instruction)
// status is 127 for bash errors
print("ERROR: objdump result:", result,
"\n path:", objdump,
"\n error:\n", result.stderr)
throw OToolError.invocationFailed(status: result.status)
}