From 9622a3b366a459221b4fd7dac84721ced0451b67 Mon Sep 17 00:00:00 2001 From: julien Lengrand-Lambert Date: Sun, 3 Jul 2022 20:15:55 +0000 Subject: [PATCH] Create branch for commonjs --- README.md | 36 +++++++++++++++++++++ package-lock.json | 81 +++++++++++++++++++++++++++++++++++++++++++++++ package.json | 1 + rollup.config.js | 2 ++ 4 files changed, 120 insertions(+) diff --git a/README.md b/README.md index aaa98f6..f9e66b8 100644 --- a/README.md +++ b/README.md @@ -16,3 +16,39 @@ node_modules/@supabase/realtime-js/dist/module/RealtimeSubscription.js -> node_m https://rollupjs.org/guide/en/#error-name-is-not-exported-by-module ``` + +## And when trying to install and apply the rollup common js plugin + +[![Open in Gitpod](https://gitpod.io/button/open-in-gitpod.svg)](https://gitpod.io/#https://github.com/jlengrand/supabase-fail) + +or run `$npm install && npm run build` + + +Here is the error that I get + +``` +(!) `this` has been rewritten to `undefined` +https://rollupjs.org/guide/en/#error-this-is-undefined +node_modules/@supabase/supabase-js/dist/module/SupabaseClient.js +1: var __awaiter = this && this.__awaiter || function (thisArg, _arguments, P, generator) { + ^ +2: function adopt(value) { +3: return value instanceof P ? value : new P(function (resolve) { +...and 1 other occurrence +node_modules/@supabase/functions-js/dist/module/index.js +1: var __awaiter = this && this.__awaiter || function (thisArg, _arguments, P, generator) { + ^ +2: function adopt(value) { +3: return value instanceof P ? value : new P(function (resolve) { +...and 1 other occurrence +node_modules/@supabase/gotrue-js/dist/module/GoTrueApi.js +1: var __awaiter = this && this.__awaiter || function (thisArg, _arguments, P, generator) { + ^ +2: function adopt(value) { +3: return value instanceof P ? value : new P(function (resolve) { +...and 1 other occurrence + +...and 8 other files +[!] (plugin commonjs--resolver) SyntaxError: Unexpected token (2:8) +node_modules/websocket/index.js (2:8) +``` diff --git a/package-lock.json b/package-lock.json index 2aeab6c..33ddaa7 100644 --- a/package-lock.json +++ b/package-lock.json @@ -18,6 +18,7 @@ "@open-wc/building-rollup": "^2.0.1", "@open-wc/eslint-config": "^4.3.0", "@rollup/plugin-babel": "^5.3.0", + "@rollup/plugin-commonjs": "^22.0.1", "@rollup/plugin-node-resolve": "^13.0.6", "@web/dev-server": "^0.1.28", "@web/rollup-plugin-html": "^1.10.1", @@ -2048,6 +2049,33 @@ } } }, + "node_modules/@rollup/plugin-commonjs": { + "version": "22.0.1", + "resolved": "https://registry.npmjs.org/@rollup/plugin-commonjs/-/plugin-commonjs-22.0.1.tgz", + "integrity": "sha512-dGfEZvdjDHObBiP5IvwTKMVeq/tBZGMBHZFMdIV1ClMM/YoWS34xrHFGfag9SN2ZtMgNZRFruqvxZQEa70O6nQ==", + "dev": true, + "dependencies": { + "@rollup/pluginutils": "^3.1.0", + "commondir": "^1.0.1", + "estree-walker": "^2.0.1", + "glob": "^7.1.6", + "is-reference": "^1.2.1", + "magic-string": "^0.25.7", + "resolve": "^1.17.0" + }, + "engines": { + "node": ">= 12.0.0" + }, + "peerDependencies": { + "rollup": "^2.68.0" + } + }, + "node_modules/@rollup/plugin-commonjs/node_modules/estree-walker": { + "version": "2.0.2", + "resolved": "https://registry.npmjs.org/estree-walker/-/estree-walker-2.0.2.tgz", + "integrity": "sha512-Rfkk/Mp/DL7JVje3u18FxFujQlTNR2q6QfMSMB7AvCBx91NGj/ba3kCfza0f6dVDbw7YlRf/nDrn7pQrCCyQ/w==", + "dev": true + }, "node_modules/@rollup/plugin-node-resolve": { "version": "13.3.0", "resolved": "https://registry.npmjs.org/@rollup/plugin-node-resolve/-/plugin-node-resolve-13.3.0.tgz", @@ -3498,6 +3526,12 @@ "node": ">=4.0.0" } }, + "node_modules/commondir": { + "version": "1.0.1", + "resolved": "https://registry.npmjs.org/commondir/-/commondir-1.0.1.tgz", + "integrity": "sha512-W9pAhw0ja1Edb5GVdIF1mjZw/ASI0AlShXM83UUGe2DVr5TdAPEA1OA8m/g8zWp9x6On7gqufY+FatDbC3MDQg==", + "dev": true + }, "node_modules/compare-versions": { "version": "3.6.0", "resolved": "https://registry.npmjs.org/compare-versions/-/compare-versions-3.6.0.tgz", @@ -5737,6 +5771,15 @@ "integrity": "sha512-bCYeRA2rVibKZd+s2625gGnGF/t7DSqDs4dP7CrLA1m7jKWz6pps0LpYLJN8Q64HtmPKJ1hrN3nzPNKFEKOUiQ==", "dev": true }, + "node_modules/is-reference": { + "version": "1.2.1", + "resolved": "https://registry.npmjs.org/is-reference/-/is-reference-1.2.1.tgz", + "integrity": "sha512-U82MsXXiFIrjCK4otLT+o2NA2Cd2g5MLoOVXUZjIOhLurrRxpEXzI8O0KZHr3IjLvlAH1kTPYSuqer5T9ZVBKQ==", + "dev": true, + "dependencies": { + "@types/estree": "*" + } + }, "node_modules/is-regex": { "version": "1.1.4", "resolved": "https://registry.npmjs.org/is-regex/-/is-regex-1.1.4.tgz", @@ -10644,6 +10687,29 @@ "@rollup/pluginutils": "^3.1.0" } }, + "@rollup/plugin-commonjs": { + "version": "22.0.1", + "resolved": "https://registry.npmjs.org/@rollup/plugin-commonjs/-/plugin-commonjs-22.0.1.tgz", + "integrity": "sha512-dGfEZvdjDHObBiP5IvwTKMVeq/tBZGMBHZFMdIV1ClMM/YoWS34xrHFGfag9SN2ZtMgNZRFruqvxZQEa70O6nQ==", + "dev": true, + "requires": { + "@rollup/pluginutils": "^3.1.0", + "commondir": "^1.0.1", + "estree-walker": "^2.0.1", + "glob": "^7.1.6", + "is-reference": "^1.2.1", + "magic-string": "^0.25.7", + "resolve": "^1.17.0" + }, + "dependencies": { + "estree-walker": { + "version": "2.0.2", + "resolved": "https://registry.npmjs.org/estree-walker/-/estree-walker-2.0.2.tgz", + "integrity": "sha512-Rfkk/Mp/DL7JVje3u18FxFujQlTNR2q6QfMSMB7AvCBx91NGj/ba3kCfza0f6dVDbw7YlRf/nDrn7pQrCCyQ/w==", + "dev": true + } + } + }, "@rollup/plugin-node-resolve": { "version": "13.3.0", "resolved": "https://registry.npmjs.org/@rollup/plugin-node-resolve/-/plugin-node-resolve-13.3.0.tgz", @@ -11811,6 +11877,12 @@ "integrity": "sha512-gk/Z852D2Wtb//0I+kRFNKKE9dIIVirjoqPoA1wJU+XePVXZfGeBpk45+A1rKO4Q43prqWBNY/MiIeRLbPWUaA==", "dev": true }, + "commondir": { + "version": "1.0.1", + "resolved": "https://registry.npmjs.org/commondir/-/commondir-1.0.1.tgz", + "integrity": "sha512-W9pAhw0ja1Edb5GVdIF1mjZw/ASI0AlShXM83UUGe2DVr5TdAPEA1OA8m/g8zWp9x6On7gqufY+FatDbC3MDQg==", + "dev": true + }, "compare-versions": { "version": "3.6.0", "resolved": "https://registry.npmjs.org/compare-versions/-/compare-versions-3.6.0.tgz", @@ -13509,6 +13581,15 @@ "integrity": "sha512-bCYeRA2rVibKZd+s2625gGnGF/t7DSqDs4dP7CrLA1m7jKWz6pps0LpYLJN8Q64HtmPKJ1hrN3nzPNKFEKOUiQ==", "dev": true }, + "is-reference": { + "version": "1.2.1", + "resolved": "https://registry.npmjs.org/is-reference/-/is-reference-1.2.1.tgz", + "integrity": "sha512-U82MsXXiFIrjCK4otLT+o2NA2Cd2g5MLoOVXUZjIOhLurrRxpEXzI8O0KZHr3IjLvlAH1kTPYSuqer5T9ZVBKQ==", + "dev": true, + "requires": { + "@types/estree": "*" + } + }, "is-regex": { "version": "1.1.4", "resolved": "https://registry.npmjs.org/is-regex/-/is-regex-1.1.4.tgz", diff --git a/package.json b/package.json index 85e7423..7bdc672 100644 --- a/package.json +++ b/package.json @@ -22,6 +22,7 @@ "@open-wc/building-rollup": "^2.0.1", "@open-wc/eslint-config": "^4.3.0", "@rollup/plugin-babel": "^5.3.0", + "@rollup/plugin-commonjs": "^22.0.1", "@rollup/plugin-node-resolve": "^13.0.6", "@web/dev-server": "^0.1.28", "@web/rollup-plugin-html": "^1.10.1", diff --git a/rollup.config.js b/rollup.config.js index 759b224..fca8cd2 100644 --- a/rollup.config.js +++ b/rollup.config.js @@ -5,6 +5,7 @@ import { importMetaAssets } from '@web/rollup-plugin-import-meta-assets'; import { terser } from 'rollup-plugin-terser'; import { generateSW } from 'rollup-plugin-workbox'; import path from 'path'; +import commonjs from '@rollup/plugin-commonjs'; export default { input: 'index.html', @@ -18,6 +19,7 @@ export default { preserveEntrySignatures: false, plugins: [ + commonjs(), /** Enable using HTML as rollup entrypoint */ html({ minify: true,