From 4c4388e3c8ee14409215ebaf4c51fe396ce44e92 Mon Sep 17 00:00:00 2001 From: rubiniselvaraj Date: Wed, 13 Dec 2023 10:26:02 +0530 Subject: [PATCH] Fix for handling error in resttemplate (#17381) * Fix with handling error * Fix with handling error --- .../resources/Java/libraries/resttemplate/ApiClient.mustache | 4 ++++ .../src/main/java/org/openapitools/client/ApiClient.java | 4 ++++ .../src/main/java/org/openapitools/client/ApiClient.java | 4 ++++ .../src/main/java/org/openapitools/client/ApiClient.java | 4 ++++ .../src/main/java/org/openapitools/client/ApiClient.java | 4 ++++ .../src/main/java/org/openapitools/client/ApiClient.java | 4 ++++ .../src/main/java/org/openapitools/client/ApiClient.java | 4 ++++ .../src/main/java/org/openapitools/client/ApiClient.java | 4 ++++ 8 files changed, 32 insertions(+) diff --git a/modules/openapi-generator/src/main/resources/Java/libraries/resttemplate/ApiClient.mustache b/modules/openapi-generator/src/main/resources/Java/libraries/resttemplate/ApiClient.mustache index f641d8e16d..26e1493e03 100644 --- a/modules/openapi-generator/src/main/resources/Java/libraries/resttemplate/ApiClient.mustache +++ b/modules/openapi-generator/src/main/resources/Java/libraries/resttemplate/ApiClient.mustache @@ -784,6 +784,10 @@ public class ApiClient{{#jsr310}} extends JavaTimeFormatter{{/jsr310}} { } } + if (responseEntity == null) { + throw new RestClientException("API returned HttpServerErrorException"); + } + if (responseEntity.getStatusCode().is2xxSuccessful()) { return responseEntity; } else { diff --git a/samples/client/echo_api/java/resttemplate/src/main/java/org/openapitools/client/ApiClient.java b/samples/client/echo_api/java/resttemplate/src/main/java/org/openapitools/client/ApiClient.java index cd4196b5c2..15a1b9c79b 100644 --- a/samples/client/echo_api/java/resttemplate/src/main/java/org/openapitools/client/ApiClient.java +++ b/samples/client/echo_api/java/resttemplate/src/main/java/org/openapitools/client/ApiClient.java @@ -700,6 +700,10 @@ public class ApiClient extends JavaTimeFormatter { } } + if (responseEntity == null) { + throw new RestClientException("API returned HttpServerErrorException"); + } + if (responseEntity.getStatusCode().is2xxSuccessful()) { return responseEntity; } else { diff --git a/samples/client/others/java/resttemplate-useAbstractionForFiles/src/main/java/org/openapitools/client/ApiClient.java b/samples/client/others/java/resttemplate-useAbstractionForFiles/src/main/java/org/openapitools/client/ApiClient.java index 14e600e644..0d9f0d1498 100644 --- a/samples/client/others/java/resttemplate-useAbstractionForFiles/src/main/java/org/openapitools/client/ApiClient.java +++ b/samples/client/others/java/resttemplate-useAbstractionForFiles/src/main/java/org/openapitools/client/ApiClient.java @@ -643,6 +643,10 @@ public class ApiClient extends JavaTimeFormatter { } } + if (responseEntity == null) { + throw new RestClientException("API returned HttpServerErrorException"); + } + if (responseEntity.getStatusCode().is2xxSuccessful()) { return responseEntity; } else { diff --git a/samples/client/petstore/java/resttemplate-jakarta/src/main/java/org/openapitools/client/ApiClient.java b/samples/client/petstore/java/resttemplate-jakarta/src/main/java/org/openapitools/client/ApiClient.java index 6d065b370a..313b5ae129 100644 --- a/samples/client/petstore/java/resttemplate-jakarta/src/main/java/org/openapitools/client/ApiClient.java +++ b/samples/client/petstore/java/resttemplate-jakarta/src/main/java/org/openapitools/client/ApiClient.java @@ -692,6 +692,10 @@ public class ApiClient extends JavaTimeFormatter { } } + if (responseEntity == null) { + throw new RestClientException("API returned HttpServerErrorException"); + } + if (responseEntity.getStatusCode().is2xxSuccessful()) { return responseEntity; } else { diff --git a/samples/client/petstore/java/resttemplate-swagger1/src/main/java/org/openapitools/client/ApiClient.java b/samples/client/petstore/java/resttemplate-swagger1/src/main/java/org/openapitools/client/ApiClient.java index 446c2c721a..da9e4a41e7 100644 --- a/samples/client/petstore/java/resttemplate-swagger1/src/main/java/org/openapitools/client/ApiClient.java +++ b/samples/client/petstore/java/resttemplate-swagger1/src/main/java/org/openapitools/client/ApiClient.java @@ -692,6 +692,10 @@ public class ApiClient extends JavaTimeFormatter { } } + if (responseEntity == null) { + throw new RestClientException("API returned HttpServerErrorException"); + } + if (responseEntity.getStatusCode().is2xxSuccessful()) { return responseEntity; } else { diff --git a/samples/client/petstore/java/resttemplate-swagger2/src/main/java/org/openapitools/client/ApiClient.java b/samples/client/petstore/java/resttemplate-swagger2/src/main/java/org/openapitools/client/ApiClient.java index 446c2c721a..da9e4a41e7 100644 --- a/samples/client/petstore/java/resttemplate-swagger2/src/main/java/org/openapitools/client/ApiClient.java +++ b/samples/client/petstore/java/resttemplate-swagger2/src/main/java/org/openapitools/client/ApiClient.java @@ -692,6 +692,10 @@ public class ApiClient extends JavaTimeFormatter { } } + if (responseEntity == null) { + throw new RestClientException("API returned HttpServerErrorException"); + } + if (responseEntity.getStatusCode().is2xxSuccessful()) { return responseEntity; } else { diff --git a/samples/client/petstore/java/resttemplate-withXml/src/main/java/org/openapitools/client/ApiClient.java b/samples/client/petstore/java/resttemplate-withXml/src/main/java/org/openapitools/client/ApiClient.java index 72282e7042..9e0aacc576 100644 --- a/samples/client/petstore/java/resttemplate-withXml/src/main/java/org/openapitools/client/ApiClient.java +++ b/samples/client/petstore/java/resttemplate-withXml/src/main/java/org/openapitools/client/ApiClient.java @@ -755,6 +755,10 @@ public class ApiClient extends JavaTimeFormatter { } } + if (responseEntity == null) { + throw new RestClientException("API returned HttpServerErrorException"); + } + if (responseEntity.getStatusCode().is2xxSuccessful()) { return responseEntity; } else { diff --git a/samples/client/petstore/java/resttemplate/src/main/java/org/openapitools/client/ApiClient.java b/samples/client/petstore/java/resttemplate/src/main/java/org/openapitools/client/ApiClient.java index f20fc5eb7c..1f71044281 100644 --- a/samples/client/petstore/java/resttemplate/src/main/java/org/openapitools/client/ApiClient.java +++ b/samples/client/petstore/java/resttemplate/src/main/java/org/openapitools/client/ApiClient.java @@ -750,6 +750,10 @@ public class ApiClient extends JavaTimeFormatter { } } + if (responseEntity == null) { + throw new RestClientException("API returned HttpServerErrorException"); + } + if (responseEntity.getStatusCode().is2xxSuccessful()) { return responseEntity; } else {