From 8ea2e85ae372aa349a841a099c788160686b4b42 Mon Sep 17 00:00:00 2001
From: Lars den Bakker <larsdenbakker@gmail.com>
Date: Mon, 25 May 2020 17:05:08 +0200
Subject: [PATCH] feat(testing-karma): don't load axe as a script

---
 packages/chai-a11y-axe/package.json           |  8 +++---
 packages/testing-karma/package.json           |  2 +-
 .../src/create-default-config.js              |  3 +-
 yarn.lock                                     | 28 ++++++++++++++++++-
 4 files changed, 33 insertions(+), 8 deletions(-)

diff --git a/packages/chai-a11y-axe/package.json b/packages/chai-a11y-axe/package.json
index 89dd5955..edd463bb 100644
--- a/packages/chai-a11y-axe/package.json
+++ b/packages/chai-a11y-axe/package.json
@@ -28,10 +28,10 @@
     "A11Y",
     "testing"
   ],
-  "contributors": [
-    "Pawel Psztyc"
-  ],
   "dependencies": {
     "axe-core": "^3.5.3"
-  }
+  },
+  "contributors": [
+    "Pawel Psztyc"
+  ]
 }
diff --git a/packages/testing-karma/package.json b/packages/testing-karma/package.json
index 25fde75d..8bace4bf 100644
--- a/packages/testing-karma/package.json
+++ b/packages/testing-karma/package.json
@@ -33,7 +33,7 @@
     "@types/karma-coverage-istanbul-reporter": "^2.1.0",
     "@types/karma-mocha": "^1.3.0",
     "@types/karma-mocha-reporter": "^2.2.0",
-    "axe-core": "^3.3.1",
+    "axe-core": "^3.5.3",
     "karma": "^4.1.0",
     "karma-chrome-launcher": "^3.1.0",
     "karma-coverage-istanbul-reporter": "^2.0.0",
diff --git a/packages/testing-karma/src/create-default-config.js b/packages/testing-karma/src/create-default-config.js
index 2d7474fe..f00f7436 100644
--- a/packages/testing-karma/src/create-default-config.js
+++ b/packages/testing-karma/src/create-default-config.js
@@ -30,7 +30,6 @@ module.exports = config => ({
       // specify it, so force snapshot files to be js type to avoid karma complaints
       type: 'js',
     },
-    require.resolve('axe-core/axe.min.js'),
   ],
 
   customLaunchers: {
@@ -70,7 +69,7 @@ module.exports = config => ({
       '**/node_modules/core-js-bundle/**/*',
     ],
     // sinon is not completely es5...
-    babelModernExclude: ['**/node_modules/sinon/**/*'],
+    babelModernExclude: ['**/node_modules/sinon/**/*', '**/node_modules/axe-core/**/*'],
     // prevent compiling non-module libs
     babelModuleExclude: ['**/node_modules/mocha/**/*', '**/node_modules/core-js-bundle/**/*'],
     exclude: ['**/__snapshots__/**/*'],
diff --git a/yarn.lock b/yarn.lock
index f84a2462..c7416654 100644
--- a/yarn.lock
+++ b/yarn.lock
@@ -2383,6 +2383,32 @@
   resolved "https://registry.yarnpkg.com/@open-wc/semantic-dom-diff/-/semantic-dom-diff-0.13.21.tgz#718b9ec5f9a98935fc775e577ad094ae8d8b7dea"
   integrity sha512-BONpjHcGX2zFa9mfnwBCLEmlDsOHzT+j6Qt1yfK3MzFXFtAykfzFjAgaxPetu0YbBlCfXuMlfxI4vlRGCGMvFg==
 
+"@open-wc/testing-karma-bs@file:./packages/testing-karma-bs":
+  version "1.3.74"
+  dependencies:
+    "@open-wc/testing-karma" "^3.3.31"
+    "@types/node" "^11.13.0"
+    karma-browserstack-launcher "^1.0.0"
+
+"@open-wc/testing-karma@file:./packages/testing-karma":
+  version "3.3.31"
+  dependencies:
+    "@open-wc/karma-esm" "^2.16.9"
+    "@types/karma" "^5.0.0"
+    "@types/karma-coverage-istanbul-reporter" "^2.1.0"
+    "@types/karma-mocha" "^1.3.0"
+    "@types/karma-mocha-reporter" "^2.2.0"
+    axe-core "^3.5.3"
+    karma "^4.1.0"
+    karma-chrome-launcher "^3.1.0"
+    karma-coverage-istanbul-reporter "^2.0.0"
+    karma-mocha "^1.0.0"
+    karma-mocha-reporter "^2.0.0"
+    karma-mocha-snapshot "^0.2.1"
+    karma-snapshot "^0.6.0"
+    karma-source-map-support "^1.3.0"
+    mocha "^6.2.2"
+
 "@reach/router@^1.2.1":
   version "1.3.3"
   resolved "https://registry.yarnpkg.com/@reach/router/-/router-1.3.3.tgz#58162860dce6c9449d49be86b0561b5ef46d80db"
@@ -4528,7 +4554,7 @@ aws4@^1.8.0:
   resolved "https://registry.yarnpkg.com/aws4/-/aws4-1.9.1.tgz#7e33d8f7d449b3f673cd72deb9abdc552dbe528e"
   integrity sha512-wMHVg2EOHaMRxbzgFJ9gtjOOCrI80OHLG14rxi28XwOW8ux6IiEbRCGGGqCtdAIg4FQCbW20k9RsT4y3gJlFug==
 
-axe-core@^3.3.1, axe-core@^3.3.2, axe-core@^3.5.3:
+axe-core@^3.3.2, axe-core@^3.5.3:
   version "3.5.3"
   resolved "https://registry.yarnpkg.com/axe-core/-/axe-core-3.5.3.tgz#5b7c0ee7c5197d546bd3a07c3ef701896f5773e9"
   integrity sha512-HZpLE7xu05+8AbpqXITGdxp1Xwk8ysAXrg7MiKRY27py3DAyEJpoJQo1727pWF3F+O79V3r+cTWhOzfB49P89w==