From 66f523d7a71153e4aa3a552fe40dc8b2609b19ed Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Abdo=CC=81n=20Rodri=CC=81guez=20Davila?= Date: Mon, 21 Sep 2020 08:55:30 +0200 Subject: [PATCH] chore(rollup-plugin-html): update html-minifier to html-minifier-terser --- packages/rollup-plugin-html/package.json | 5 ++--- packages/rollup-plugin-html/src/minifyHtml.js | 6 ++---- packages/rollup-plugin-html/test/src/getOutputHtml.test.js | 2 +- 3 files changed, 5 insertions(+), 8 deletions(-) diff --git a/packages/rollup-plugin-html/package.json b/packages/rollup-plugin-html/package.json index da871c92..8fe0932d 100644 --- a/packages/rollup-plugin-html/package.json +++ b/packages/rollup-plugin-html/package.json @@ -48,8 +48,7 @@ "@types/html-minifier": "^3.5.3", "fs-extra": "^8.1.0", "glob": "^7.1.3", - "html-minifier": "^4.0.0", - "parse5": "^5.1.1", - "terser": "^4.6.7" + "html-minifier-terser": "^5.1.1", + "parse5": "^5.1.1" } } diff --git a/packages/rollup-plugin-html/src/minifyHtml.js b/packages/rollup-plugin-html/src/minifyHtml.js index 7c29b34c..0ab401a0 100644 --- a/packages/rollup-plugin-html/src/minifyHtml.js +++ b/packages/rollup-plugin-html/src/minifyHtml.js @@ -1,5 +1,4 @@ -const Terser = require('terser'); -const htmlMinifier = require('html-minifier'); +const htmlMinifier = require('html-minifier-terser'); const defaultMinifyHTMLConfig = { collapseWhitespace: true, @@ -9,8 +8,7 @@ const defaultMinifyHTMLConfig = { removeStyleLinkTypeAttributes: true, useShortDoctype: true, minifyCSS: true, - /** @param {string} code */ - minifyJS: code => Terser.minify(code).code, + minifyJS: true, }; /** diff --git a/packages/rollup-plugin-html/test/src/getOutputHtml.test.js b/packages/rollup-plugin-html/test/src/getOutputHtml.test.js index c816ba9f..783f8357 100644 --- a/packages/rollup-plugin-html/test/src/getOutputHtml.test.js +++ b/packages/rollup-plugin-html/test/src/getOutputHtml.test.js @@ -269,7 +269,7 @@ describe('getOutputHtml()', () => { }, }); - expect(output).to.equal(''); + expect(output).to.equal(''); }); it('default minify minifies inline css', async () => {