From 6484c1bf91f3b1ed18b60d8e139644f9fea652e2 Mon Sep 17 00:00:00 2001 From: Andres Almiray Date: Sun, 4 Jul 2021 18:35:14 +0200 Subject: [PATCH] [release] username is no longer required for connecting to GitHub. Resolves #262 --- .../src/main/java/org/jreleaser/sdk/github/Github.java | 10 ++++------ .../java/org/jreleaser/sdk/github/GithubReleaser.java | 1 - 2 files changed, 4 insertions(+), 7 deletions(-) diff --git a/sdks/github-java-sdk/src/main/java/org/jreleaser/sdk/github/Github.java b/sdks/github-java-sdk/src/main/java/org/jreleaser/sdk/github/Github.java index 12aceb0e..af94ddde 100644 --- a/sdks/github-java-sdk/src/main/java/org/jreleaser/sdk/github/Github.java +++ b/sdks/github-java-sdk/src/main/java/org/jreleaser/sdk/github/Github.java @@ -62,17 +62,15 @@ class Github { private final GitHub github; Github(JReleaserLogger logger, - String username, - String password, + String token, int connectTimeout, int readTimeout) throws IOException { - this(logger, ENDPOINT, username, password, connectTimeout, readTimeout); + this(logger, ENDPOINT, token, connectTimeout, readTimeout); } Github(JReleaserLogger logger, String endpoint, - String username, - String password, + String token, int connectTimeout, int readTimeout) throws IOException { this.logger = logger; @@ -84,7 +82,7 @@ class Github { github = new GitHubBuilder() .withConnector(new JReleaserHttpConnector(connectTimeout, readTimeout)) .withEndpoint(endpoint) - .withOAuthToken(password, username) + .withOAuthToken(token) .build(); } diff --git a/sdks/github-java-sdk/src/main/java/org/jreleaser/sdk/github/GithubReleaser.java b/sdks/github-java-sdk/src/main/java/org/jreleaser/sdk/github/GithubReleaser.java index d6f79ef5..c609cf74 100644 --- a/sdks/github-java-sdk/src/main/java/org/jreleaser/sdk/github/GithubReleaser.java +++ b/sdks/github-java-sdk/src/main/java/org/jreleaser/sdk/github/GithubReleaser.java @@ -57,7 +57,6 @@ public class GithubReleaser implements Releaser { String changelog = context.getChangelog(); Github api = new Github(context.getLogger(), - github.getResolvedUsername(), github.getResolvedToken(), github.getConnectTimeout(), github.getReadTimeout());