From 0e7d43104ce2c60734b99e3fc6da16fcbb921deb Mon Sep 17 00:00:00 2001 From: Paul Parkinson Date: Sat, 14 Nov 2020 20:43:16 -0500 Subject: [PATCH] add tags before span start in jersey ClientTracingFilter #1942 (#2512) --- .../jersey/client/ClientTracingFilter.java | 18 ++++++------------ 1 file changed, 6 insertions(+), 12 deletions(-) diff --git a/tracing/jersey-client/src/main/java/io/helidon/tracing/jersey/client/ClientTracingFilter.java b/tracing/jersey-client/src/main/java/io/helidon/tracing/jersey/client/ClientTracingFilter.java index 586790335..57fae34b0 100644 --- a/tracing/jersey-client/src/main/java/io/helidon/tracing/jersey/client/ClientTracingFilter.java +++ b/tracing/jersey-client/src/main/java/io/helidon/tracing/jersey/client/ClientTracingFilter.java @@ -327,19 +327,13 @@ public class ClientTracingFilter implements ClientRequestFilter, ClientResponseF Tracer tracer, Optional parentSpan, String spanName) { - - Tracer.SpanBuilder spanBuilder = tracer.buildSpan(spanName); - + Tracer.SpanBuilder spanBuilder = tracer.buildSpan(spanName) + .withTag(Tags.SPAN_KIND.getKey(), Tags.SPAN_KIND_CLIENT) + .withTag(Tags.HTTP_METHOD.getKey(), requestContext.getMethod()) + .withTag(Tags.HTTP_URL.getKey(), url(requestContext.getUri())) + .withTag(Tags.COMPONENT.getKey(), "jaxrs"); parentSpan.ifPresent(spanBuilder::asChildOf); - - Span span = spanBuilder.start(); - - Tags.COMPONENT.set(span, "jaxrs"); - Tags.HTTP_METHOD.set(span, requestContext.getMethod()); - Tags.HTTP_URL.set(span, url(requestContext.getUri())); - Tags.SPAN_KIND.set(span, Tags.SPAN_KIND_CLIENT); - - return span; + return spanBuilder.start(); } private String url(URI uri) {