Liam Newman
614c5578b0
Fix code coverage and GHRepositoryTraffic test
2020-02-21 15:35:45 -08:00
Liam Newman
a68fe3b39d
More javadoc because words are hard
2020-02-21 12:04:25 -08:00
Liam Newman
1904c82941
PR feedback
2020-02-21 10:52:28 -08:00
Roel van Dijk
6fc9dd4b30
Add support for rocket and eyes reactions.
2020-02-21 10:59:17 +01:00
Liam Newman
158a31e924
Added javadocs and other cleanup
...
Whenever I submit a PR and then start looking at it as a reviewer, I immediately find a bunch of things that need changing.
2020-02-20 18:53:13 -08:00
Liam Newman
b70b924db4
Inital implmentation of RateLimitChecker
...
This is a stripped down rate limit checking implmentation that handles the infrastructure
of deciding how to get rate limit information and leaves it to other implementers to
decided what kind of checks they want to do and how long they want to wait.
The implmentation supports checkers that sleep less than the full time until the
rate limit is expected to reset, allowing for polling and notifying clients of why their query
is not returning.
A basic checker which sleeps until the rate limit is expected to reset is included as working example..
2020-02-20 16:03:46 -08:00
Liam Newman
1db4fca9db
Comment tweaks
2020-02-18 09:02:52 -08:00
Liam Newman
bd0e0cdfa4
Revert synchronization in iterators
...
These were not synchronized before we should leave them fix this in a future change
2020-02-17 20:08:52 -08:00
Liam Newman
acc5a89dff
Class clean up
...
We don't need two layers of PageIterator just to get the final response.
Also made iterators thread-safe.
And added more detailed comments.
2020-02-17 12:55:44 -08:00
sunghyo-jung
d34881aa25
Add updated mapping files
2020-02-17 18:43:59 +09:00
sunghyo-jung
b8ad48997b
Rollback field name, add mapping files
...
`delete_branch_on_merge` is field of github repository,
So use it as same literal (ref. https://developer.github.com/v3/repos/ )
Use `getRepository` instead of `getTempRepository` at GHRepositoryTest
2020-02-17 18:42:30 +09:00
sunghyo-jung
77754b7246
Merge branch 'feature/delete_branch_automatically' of https://github.com/nobe0716/github-api into feature/delete_branch_automatically
2020-02-17 17:05:19 +09:00
sunghyo-jung
6d5bf49a51
Apply CamelCase on field delete_branch_on_merge
2020-02-17 17:03:43 +09:00
Liam Newman
b7af635a9a
Address PR feedback
2020-02-16 21:33:19 -08:00
Noah J
f53b4e959c
Merge branch 'master' into feature/delete_branch_automatically
2020-02-14 01:44:39 +09:00
nobe0716
6716d156bb
Apply changes
2020-02-14 01:44:04 +09:00
Liam Newman
dc33e28452
Create GitHubHttpUrlConnectionClient to encapsulate interactions with HttpUrlConnection
2020-02-13 08:37:07 -08:00
Liam Newman
9da4781759
Update src/main/java/org/kohsuke/github/GitHub.java
2020-02-12 23:59:15 -08:00
Liam Newman
0c6959cb4a
Merge remote-tracking branch 'github-api/master' into tast/response-info
2020-02-12 23:52:45 -08:00
Liam Newman
ff3136df70
Move a few static helpers to GitHubClient
2020-02-12 23:48:33 -08:00
Liam Newman
90489e4392
JavaDocs and refactoring
2020-02-12 22:42:12 -08:00
Liam Newman
ad45a74f87
Further clean up of refactored classes
2020-02-12 22:42:12 -08:00
Liam Newman
60c045a713
Delete mocking test that is just too brittle to live
2020-02-12 22:42:12 -08:00
Liam Newman
f6c75e1f99
More refactoring
2020-02-12 22:42:12 -08:00
Liam Newman
dd9245f6f2
Progress commit on moving to Client/Request/Response refactor
2020-02-12 22:42:12 -08:00
Liam Newman
7310a70743
Disable two tests due to spurious mocking failures
2020-02-12 22:42:12 -08:00
Liam Newman
82276837ac
Created Client/Request/Response classes
2020-02-12 22:42:12 -08:00
Liam Newman
bd68252b44
Test cleanup
2020-02-12 22:42:12 -08:00
Liam Newman
6b1258e33a
Major rewrite of Requester
2020-02-12 22:42:12 -08:00
Liam Newman
ab965969dd
Merge branch 'master' into collaborator-permissions
2020-02-12 22:31:03 -08:00
sunghyo-jung
d7bb171c1e
Add automatic deletion of branches that merged by PR
...
Add method to Toggle `delete_branch_on_merge`
Locate new fields below to merge options
2020-02-12 19:02:31 +09:00
James Vaughn
edc697dd73
fixed javadoc isues
2020-02-07 21:27:00 -06:00
James Vaughn
54a059ff68
updated signatures for addCollaborators methods
...
updated javadoc comments for addCollaborators methods
combined both modifyCollaborators methods into one method
updated addColloaborators test to match new method signature
2020-02-07 21:13:23 -06:00
Liam Newman
289282e235
Move OTP detection earlier
...
Like other errors we've been waiting until later to catch, this one is detectable so
whe should do that before the downstream exception needs to be thrown.
2020-02-06 16:59:49 -08:00
Liam Newman
825c36c15e
Tweaks for clarity
2020-02-06 14:11:16 -08:00
Liam Newman
1234c2e99e
Add tests for rate limit
2020-02-06 13:33:29 -08:00
Liam Newman
b8fae1308d
Streamline fetch and retry process
2020-02-06 08:01:17 -08:00
James Vaughn
dddcf624e6
finished suggested formatting changes
2020-02-05 21:30:52 -06:00
James Vaughn
b33fe9f7fe
Merge branch 'collaborator-permissions' of https://github.com/jimmysombrero/github-api into collaborator-permissions
2020-02-04 21:10:39 -06:00
James Vaughn
5a799400a9
fixed minor formatting issues
2020-02-04 21:10:29 -06:00
Liam Newman
76919a819f
Merge branch 'master' into collaborator-permissions
2020-02-03 12:46:17 -08:00
Liam Newman
9230f51988
Implement new methods on Options
2020-02-03 12:41:33 -08:00
Alex Taylor
134a6fab7e
Merge branch 'master' into replaceAsserts
2020-02-03 14:47:11 -05:00
Alex Taylor
82e27cb962
Replacing asserts with standard
...
Beginning work to replace Asserts with assertThat to keep consistency
2020-02-03 11:43:16 -05:00
James Vaughn
8bcad7b3f9
Merge branch 'collaborator-permissions' of https://github.com/jimmysombrero/github-api into collaborator-permissions
2020-02-02 22:03:08 -06:00
James Vaughn
d767575f76
Added test for addCollaborators
...
Mark old addCollaborators methods depricated
2020-02-02 22:02:56 -06:00
jimmysombrero
7214c7d393
Merge branch 'master' into collaborator-permissions
2020-02-01 22:40:54 -06:00
James Vaughn
205e5ab03d
Merge branch 'collaborator-permissions' of https://github.com/jimmysombrero/github-api into collaborator-permissions
2020-02-01 22:39:28 -06:00
James Vaughn
6576beae76
Added missing methods to keep the API from breaking
...
added tests for addCollaborators()
2020-02-01 22:39:14 -06:00
Liam Newman
3b694a87ef
Fix formatting
2020-01-31 13:17:16 -08:00
