Commit Graph

1814 Commits

Author SHA1 Message Date
Kevin Harrington
feabd07a21 adding javadoc 2019-11-13 00:28:18 -05:00
Kevin Harrington
e138c6fd61 Switch interface to existing Supplier class 2019-11-13 00:26:20 -05:00
Kevin Harrington
d32299fde5 add testing of scopes in assigned token 2019-11-13 00:23:38 -05:00
Kevin Harrington
3d7d780e8f only run test with moc date 2019-11-13 00:19:06 -05:00
Kevin Harrington
9f49854033 Comments for the path of OTP exception 2019-11-13 00:17:57 -05:00
Kevin Harrington
1fe820d463 instructions for reproducing the test data 2019-11-12 18:15:08 -05:00
Kevin Harrington
4a78690fde Remove old function prototype and replace it with the lambda model. 2019-11-12 18:10:05 -05:00
Kevin Harrington
3dcaf5a9de Unit test passing with Mock data 2019-11-12 18:05:39 -05:00
Kevin Harrington
ff788852d6 added the filter to the test to only run with mock data 2019-11-12 17:58:21 -05:00
Kevin Harrington
5ae062719e re-run the data capture with the overloaded function 2019-11-12 17:56:25 -05:00
Kevin Harrington
421c0a11fb Implement @PauloMigAlmeida suggested lambda style OTP workflow 2019-11-12 17:32:24 -05:00
Kevin Harrington
6ae586aeb7 Creating a receiver lambda for the PTM functionality 2019-11-12 17:28:23 -05:00
Liam Newman
7036423084 Merge pull request #595 from bitwiseman/issue/rate-limit
Adjust GHRateLimit to system time instead of depending on synchronization
2019-11-12 13:01:58 -08:00
Kevin Harrington
2f118a9cbe Adding suggested exception from @PauloMigAlmeida
When the OTP code is requested, then the special GHOTPRequiredException
is raised instead of the generic IOException. This differentiates
between an OTP request and a failed password.
2019-11-12 15:44:45 -05:00
Kevin Harrington
2c50255b21 renaming 2019-11-12 15:35:55 -05:00
harrington
8cb7210c46 set the timestamp in the token name to match the test data 2019-11-12 15:01:14 -05:00
harrington
ad0a24ad2f Make sure test is only run with stored mock data 2019-11-12 14:54:38 -05:00
harrington
df6c951830 Unit test passing with OTP data 2019-11-12 14:53:14 -05:00
harrington
5da2caa616 Adding the assume only valid when live 2019-11-12 13:00:51 -05:00
harrington
a3fe95d1e4 clear junk data 2019-11-12 12:58:22 -05:00
Liam Newman
38e61c121b Merge pull request #604 from sullis/jackson-2.10.1
jackson 2.10.1
2019-11-11 14:31:21 -08:00
Liam Newman
03e9623073 Updates based on review feedback
Created GHRateLimit.Record
Add the four rate limit records to GHRateLimit
Moved getLimt(), getRemaining(), and so on to point to core record for ease of use.
Fixed update check for header to not replace existing with older when remaining count is lower.

NOTE: Did not expose records other than core and did not resolve header update behavior to respect non-core records.
2019-11-11 14:29:36 -08:00
Sean C. Sullivan
93a1657e1e jackson 2.10.1 2019-11-10 18:31:29 -05:00
Kevin Harrington
91d67fb72f Tuning the test to pass 2019-11-10 12:13:38 -05:00
Kevin Harrington
d8cc1f885c Properly disabling the test 2019-11-10 11:32:59 -05:00
Kevin Harrington
c1f999d896 Disabling test that can't run on CI 2019-11-10 11:27:45 -05:00
Kevin Harrington
efc4d0f59b Merge branch 'master' of git@github.com:madhephaestus/github-api.git 2019-11-10 11:20:50 -05:00
Kevin Harrington
cf55d670b9 Added test to comply with CONTRIBUTING.md
Test extends AbstractGitHubWireMockTest

Test requires 2fa and the user at the command line as the test is run.
2019-11-10 11:20:32 -05:00
Kevin Harrington
8567c5e6a1 Update src/main/java/org/kohsuke/github/GitHub.java
spelling

Co-Authored-By: Liam Newman <bitwiseman@gmail.com>
2019-11-10 10:26:51 -05:00
Kevin Harrington
331084fefd comments 2019-11-09 16:47:26 -05:00
Kevin Harrington
62bf691ac1 Add Functionality of OTP to github
close #602 by adding an API to request a token using an OTP.
2019-11-09 16:43:25 -05:00
Liam Newman
09b41d4665 Merge pull request #593 from github-api/dependabot/maven/com.squareup.okhttp3-okhttp-4.2.2
Bump okhttp from 3.14.2 to 4.2.2
2019-11-07 17:36:00 -08:00
Liam Newman
71645240e9 Address Spotbugs issues in dependency update 2019-11-07 16:40:59 -08:00
dependabot-preview[bot]
603468823d Bump okhttp from 3.14.2 to 4.2.2
Bumps [okhttp](https://github.com/square/okhttp) from 3.14.2 to 4.2.2.
- [Release notes](https://github.com/square/okhttp/releases)
- [Changelog](https://github.com/square/okhttp/blob/master/CHANGELOG.md)
- [Commits](https://github.com/square/okhttp/compare/parent-3.14.2...parent-4.2.2)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2019-11-07 16:18:48 -08:00
Liam Newman
01f464cc69 Add gitter.io chat 2019-11-07 15:47:39 -08:00
Liam Newman
57ac6e982f Updated Last-Modified headers
Introduces #597

This does not appear to be a bug in github-api but in OkHttp 2.7.5
(and/or the Cache implementation in that version).
2019-11-07 14:05:54 -08:00
Liam Newman
319d2d1efe Update cache test Date and Limit values 2019-11-07 13:50:57 -08:00
Liam Newman
37de3a4122 Add tests for server time ahead and behind local time
Sometimes adding tests finds broken product code.  Sometimes it finds broken test environment.
This was the latter.

The wiremock templating returns dates in UTC format not RFC-1123 format.
2019-11-07 13:24:31 -08:00
Liam Newman
bb3a49264d Merge remote-tracking branch 'github-api/master' into issue/rate-limit 2019-11-07 11:38:00 -08:00
Liam Newman
9cecce74fa Merge pull request #594 from martinvanzijl/add-method-to-set-topics
Add method to set repository topics
2019-11-06 21:26:31 -08:00
Liam Newman
f9cf2878ef Tweaks to test 2019-11-06 21:20:55 -08:00
Liam Newman
9c80b7cf54 Various clean up and fixes for GHRateLimit 2019-11-06 20:38:10 -08:00
Liam Newman
1ecad7031f Handle GHRateLimit expiration and server time inconsistency 2019-11-06 17:17:26 -08:00
Martin van Zijl
c85d6107ec Added method to set repository topics. Fixes #546. 2019-11-07 13:41:14 +13:00
Liam Newman
7b7445b601 Clean up GHRateLimit
Improves the way reset date is calculated - uses server date if possible.

Fixes #383
2019-11-06 11:11:53 -08:00
Liam Newman
1ab474673d Lock okhttp3 UrlConnection to working versions, unlock client 2019-11-04 15:15:28 -08:00
Liam Newman
dbf92e7f20 Added changelog 2019-11-04 11:02:11 -08:00
Liam Newman
6c42db2508 Add release version tag 2019-11-04 10:30:08 -08:00
Liam Newman
c9a42178e8 [maven-release-plugin] prepare for next development iteration 2019-11-04 10:09:02 -08:00
Liam Newman
eff48dfe67 [maven-release-plugin] prepare release github-api-1.99 github-api-1.99 2019-11-04 10:08:55 -08:00