Liam Newman
b550910f4c
Streamline assertThat calls using appropriate matchers
2021-04-20 12:16:55 -07:00
Liam Newman
d13e490be2
Enforce use of assertThat
...
Assert.assert* methods other than assertThat() produce less clear tests.
This change enforces using assertThat() for all verifications.
While more verbose they are generally more consistent and easier to understand.
2021-04-20 00:46:43 -07:00
Liam Newman
3d451526ef
Deprecate all asserts other than assertThat
2021-04-19 19:09:47 -07:00
Liam Newman
bd38897d48
Do not inherit from Assert
2021-04-19 15:58:33 -07:00
Liam Newman
8af66133d2
Switch to 'main' as default branch
2021-04-19 13:27:44 -07:00
Akash Rindhe
092815747a
(refactor) Rename gitHubBeforeAfter to nonRecordingGitHub #1076
...
[#1076 ]
2021-04-18 18:41:10 +08:00
Guillaume Smet
40937a5cc6
Add the missing fields for GHLabel
...
Fixes #1059
2021-03-19 14:56:05 +01:00
Liam Newman
35c8cfa01d
Push method code coverage bar to 50 percent
...
This change adds or update a swath of tests to push method code coverage numbers up.
Yes, method coverage is not super meaningful, but it is one metric that we can use to
ensure at least minimal coverage of this library.
Almost no product changes in here.
2021-01-25 12:08:57 -08:00
Liam Newman
cf9caa6af5
Update test to check values
2020-12-28 22:00:44 -08:00
Liam Newman
865a49d2e8
Update GHRepository method to use Setter
...
It appears that the correct way to pass these booleans is as booleans not as strings.
Fixes #765
2020-12-28 18:07:32 -08:00
Liam Newman
70ba4df385
Make root field transient in all classes
2020-12-18 14:58:12 -08:00
Marco Ferrer
89a08b021d
formatting
2020-10-02 17:14:28 -04:00
Marco Ferrer
04b553cdec
update deployment status checks
2020-10-02 17:12:10 -04:00
Liam Newman
46e3b2272e
Clean up and reorganize changes
...
Changed GitHubRateLimitSpecifier to RateLimitTarget
Made RateLimitTarget public so it can be passed to GitHubBuilder
2020-07-10 09:01:29 -07:00
Liam Newman
4ef0d00846
Integrate full rate limit checking
2020-07-10 09:01:29 -07:00
Liam Newman
6f9182f1f6
Rename organization to hub4j
...
Fixes #801
2020-05-08 15:17:14 -07:00
Liam Newman
87f37e9f1c
Formatting and improved bridge method tests
2020-04-22 09:40:19 -07:00
Karol Lassak
b45f353fa9
Fix tests + add deprecation to one of methods
2020-04-19 11:38:36 +02:00
Liam Newman
279df00404
Add checks for hasProjects()
2020-03-31 14:54:16 -07:00
Liam Newman
65ae41c5f1
Fix tests for isCredentialsValid
2020-03-31 09:36:26 -07:00
Liam Newman
796c644c4a
Change credential check to use rate limit
...
Fixes #582
2020-03-31 08:28:57 -07:00
Liam Newman
418df15f7b
Merge branch 'master' into sign_verification
2020-03-26 10:23:16 -07:00
Liam Newman
494318b879
Change method name to isVerified
2020-03-26 09:49:03 -07:00
Liam Newman
f554ddc372
Capitalize and Move GHVerification.Reason enum
2020-03-26 09:45:20 -07:00
D067452
a78d2f28d7
Get commit or tag signature verified flag
...
This fixes #737
- A new entity GHVerification.java has been added which would be reflecting Verification flag
- Updating GHCommit.java and GHTagObject.java with GHVerification
- Altering few test cases AppTest.java and GHTagTest.java to verify if the Verification entity is being picked up
- A separate test class SignatureVerificationTest.java with the associated wiremock test resources
- Adding a new enum GHReason.java
- Updating tests to check the GHReason implementation, GHReasonTest.java with the associated wiremock test resources
2020-03-25 17:19:56 +01:00
Liam Newman
772272ff36
Re-record test for GHLabel
2020-03-24 12:32:13 -07:00
Liam Newman
2ab4eafee9
Tweaks and cleanup
2020-03-23 17:40:01 -07:00
Liam Newman
fcb8d03a0f
Ensure that Description is part of GHLabel comparision
2020-03-23 17:40:01 -07:00
Liam Newman
79a1bb3571
Update src/test/java/org/kohsuke/github/AppTest.java
2020-03-23 17:40:01 -07:00
Liam Newman
9f1d7323c7
Reverted getter changes to highlight the more important set/update changes
2020-03-23 17:40:01 -07:00
Liam Newman
b7de4359fd
Alternative proposal
...
The guts of this version are a bit ugly but they result reasonable API code without a ton of extra
code needed.
2020-03-23 17:40:01 -07:00
Liam Newman
2607d6a107
Make GHLabel example of proposed API design
2020-03-23 17:40:01 -07:00
Karol Lassak
78b9ff49d4
Fix tests
2020-03-17 22:36:54 +01:00
Karol Lassak
fca425d25e
Add test for old getteam method
2020-03-17 22:34:13 +01:00
Karol Lassak
f6210cc014
Change variable name to something meningfull
2020-03-17 11:21:58 +01:00
Karol Lassak
2aebe97f9f
Add/restore test for getTeam
2020-03-17 11:18:33 +01:00
Liam Newman
75d95d844c
Update src/test/java/org/kohsuke/github/AppTest.java
...
Co-Authored-By: Karl Shultz <kshultz@cloudbees.com >
2020-03-02 08:41:21 -08:00
Liam Newman
1b63a58e63
Increase coverage
2020-02-27 09:38:24 -08:00
Liam Newman
804fa60317
Deprecate asList and asSet
2020-02-24 18:40:23 -08:00
Liam Newman
0c3c490d58
Merge pull request #707 from rdvdijk/add-rocket-eyes-reactions
...
Add support for rocket and eyes reactions.
2020-02-22 19:33:08 -08:00
Liam Newman
fa2601386c
Add tests for new reactions
2020-02-22 19:16:33 -08:00
Liam Newman
a0baf33459
Fix for NullPointer in issue search results
...
User reported #708 which made me realize that search tests were basically all disabled.
This terms on two basic search tests and also makes it so GHIssue can continue to work without
a GHRepository set on it.
Fixes #708
2020-02-22 17:01:12 -08:00
Liam Newman
53041a4117
Merge branch 'master' into assertThatIssues
2020-01-29 18:32:47 -08:00
Alex Taylor
aba60587ab
Corrected massive change
...
Added back the extends Assert to the wiremock test base class so that I am not making a massive change and potentially breaking inflight work people are doing
2020-01-29 16:49:33 -05:00
Liam Newman
9675126298
Turn off some tests for windows
2020-01-29 13:30:01 -08:00
Alex Taylor
4c3a0d329b
added Authentication Check
...
Added additional authentication checks on gitHubBeforeAfter so that cleanup is done with a user logged in
2020-01-27 15:24:28 -05:00
Alex Taylor
12c3a0b1fa
Authentication and assertThat issues
...
Fixed some problems with tests trying to authenticate when you are not actually signed in. This hit rate API limiting which caused tests to hang/fail
Also fixed assertThat getting deprecated from junit
2020-01-27 14:29:46 -05:00
Liam Newman
5a6a29cbb5
Add array and iterator tests
2020-01-15 19:31:30 -08:00
Liam Newman
049db83423
Merge remote-tracking branch 'github-api/master' into task/iterator
2019-12-17 14:35:37 -08:00
Liam Newman
7e4f98d328
Remove dependency on apache commons-codec
2019-12-03 11:39:05 +00:00
