Commit Graph

30 Commits

Author SHA1 Message Date
Liam Newman
cd1454ac03 More assertThat matchers 2021-04-20 12:34:01 -07:00
Liam Newman
3d451526ef Deprecate all asserts other than assertThat 2021-04-19 19:09:47 -07:00
Liam Newman
35c8cfa01d Push method code coverage bar to 50 percent
This change adds or update a swath of tests to push method code coverage numbers up.
Yes, method coverage is not super meaningful, but it is one metric that we can use to
ensure at least minimal coverage of this library.

Almost no product changes in here.
2021-01-25 12:08:57 -08:00
Liam Newman
a42305dd59 Revert "Removed extraneous author javadocs"
This reverts commit 888abc9e2a.
2020-03-04 11:32:12 -08:00
Liam Newman
888abc9e2a Removed extraneous author javadocs 2020-02-21 15:58:39 -08:00
Alex Taylor
12c3a0b1fa Authentication and assertThat issues
Fixed some problems with tests trying to authenticate when you are not actually signed in. This hit rate API limiting which caused tests to hang/fail

Also fixed assertThat getting deprecated from junit
2020-01-27 14:29:46 -05:00
Liam Newman
2af4f61882 Cleanup imports 2019-11-18 11:35:45 -08:00
Liam Newman
da11702f68 Modify formatting to columnize
Turns out I do care about formatting a little.  We have a lot of builders and chained methods.
I think it is easier to follow long chains when lined up veritcally.
2019-11-15 15:18:07 -08:00
Liam Newman
9d8460bb81 Enable automatic code formatter with CI validation
This may be controversial but it we're doing it. Having code formatting needs to be consistent
and a non-issue during code review. I'm willing modify the configuration if people see a strong
need, but formatting needs to be present and enforced.
2019-11-13 13:28:23 -08:00
Liam Newman
8943af9840 Cleanup tabs and whitespace 2019-11-13 12:47:19 -08:00
Kevin Harrington
e325bf7771 fixed for the sensitive javadoc parser 2019-11-13 00:38:51 -05:00
Kevin Harrington
feabd07a21 adding javadoc 2019-11-13 00:28:18 -05:00
Kevin Harrington
d32299fde5 add testing of scopes in assigned token 2019-11-13 00:23:38 -05:00
Kevin Harrington
3d7d780e8f only run test with moc date 2019-11-13 00:19:06 -05:00
Kevin Harrington
1fe820d463 instructions for reproducing the test data 2019-11-12 18:15:08 -05:00
Kevin Harrington
3dcaf5a9de Unit test passing with Mock data 2019-11-12 18:05:39 -05:00
Kevin Harrington
ff788852d6 added the filter to the test to only run with mock data 2019-11-12 17:58:21 -05:00
Kevin Harrington
5ae062719e re-run the data capture with the overloaded function 2019-11-12 17:56:25 -05:00
Kevin Harrington
421c0a11fb Implement @PauloMigAlmeida suggested lambda style OTP workflow 2019-11-12 17:32:24 -05:00
Kevin Harrington
2f118a9cbe Adding suggested exception from @PauloMigAlmeida
When the OTP code is requested, then the special GHOTPRequiredException
is raised instead of the generic IOException. This differentiates
between an OTP request and a failed password.
2019-11-12 15:44:45 -05:00
Kevin Harrington
2c50255b21 renaming 2019-11-12 15:35:55 -05:00
harrington
8cb7210c46 set the timestamp in the token name to match the test data 2019-11-12 15:01:14 -05:00
harrington
ad0a24ad2f Make sure test is only run with stored mock data 2019-11-12 14:54:38 -05:00
harrington
df6c951830 Unit test passing with OTP data 2019-11-12 14:53:14 -05:00
harrington
5da2caa616 Adding the assume only valid when live 2019-11-12 13:00:51 -05:00
harrington
a3fe95d1e4 clear junk data 2019-11-12 12:58:22 -05:00
Kevin Harrington
91d67fb72f Tuning the test to pass 2019-11-10 12:13:38 -05:00
Kevin Harrington
d8cc1f885c Properly disabling the test 2019-11-10 11:32:59 -05:00
Kevin Harrington
c1f999d896 Disabling test that can't run on CI 2019-11-10 11:27:45 -05:00
Kevin Harrington
cf55d670b9 Added test to comply with CONTRIBUTING.md
Test extends AbstractGitHubWireMockTest

Test requires 2fa and the user at the command line as the test is run.
2019-11-10 11:20:32 -05:00