Jesse Glick
c499c73dcc
Merge branch 'master' of github.com:github-api/github-api into createCheckRun
2020-03-26 19:09:13 -04:00
Jesse Glick
c01f3f5e8a
NPE when there are no annotations
2020-03-26 19:07:35 -04:00
Liam Newman
e911e86c4c
Merge pull request #755 from jglick/javadoc
...
#724 broke the site goal from .github/PULL_REQUEST_TEMPLATE.md
2020-03-26 13:57:51 -07:00
Jesse Glick
b4c4a05f3b
Moving enums inside GHCheckRun
2020-03-26 16:44:01 -04:00
Jesse Glick
fd3c36a259
IMHO treating Javadoc warnings as fatal makes sources less legible and does not improve API comprehension at all
2020-03-26 16:33:57 -04:00
Jesse Glick
d8274ac2d4
Merge branch 'javadoc' into createCheckRun
2020-03-26 16:26:52 -04:00
Jesse Glick
9c7479f953
#724 broke the site goal from .github/PULL_REQUEST_TEMPLATE.md
2020-03-26 16:25:32 -04:00
Jesse Glick
b5dc3c4366
Added some Javadoc.
2020-03-26 16:22:04 -04:00
Jesse Glick
26b8082155
Handle >50 annotations
2020-03-26 16:14:39 -04:00
Liam Newman
418df15f7b
Merge branch 'master' into sign_verification
2020-03-26 10:23:16 -07:00
Liam Newman
494318b879
Change method name to isVerified
2020-03-26 09:49:03 -07:00
Liam Newman
f554ddc372
Capitalize and Move GHVerification.Reason enum
2020-03-26 09:45:20 -07:00
Jesse Glick
03de12c221
SpotBugs
2020-03-25 20:03:18 -04:00
Jesse Glick
7ae96388e3
Merge branch 'master' of github.com:github-api/github-api into createCheckRun
2020-03-25 19:21:46 -04:00
Jesse Glick
e8b4de00d2
WireMock coverage
2020-03-25 19:18:11 -04:00
Jesse Glick
c7fb390c38
Introduced enums
2020-03-25 13:40:00 -04:00
Jesse Glick
572ff9df19
I guess nullability annotations can be omitted from internal members
2020-03-25 13:20:33 -04:00
Jesse Glick
b715e0cef7
Reformatted
2020-03-25 13:18:11 -04:00
Jesse Glick
36ab2a889f
Redesigned using a fluent builder idiom
2020-03-25 13:14:06 -04:00
D067452
a78d2f28d7
Get commit or tag signature verified flag
...
This fixes #737
- A new entity GHVerification.java has been added which would be reflecting Verification flag
- Updating GHCommit.java and GHTagObject.java with GHVerification
- Altering few test cases AppTest.java and GHTagTest.java to verify if the Verification entity is being picked up
- A separate test class SignatureVerificationTest.java with the associated wiremock test resources
- Adding a new enum GHReason.java
- Updating tests to check the GHReason implementation, GHReasonTest.java with the associated wiremock test resources
2020-03-25 17:19:56 +01:00
Jesse Glick
7d5a39ed89
GHRepository.createCheckRun
2020-03-24 23:51:38 -04:00
Liam Newman
772272ff36
Re-record test for GHLabel
2020-03-24 12:32:13 -07:00
Liam Newman
2ab4eafee9
Tweaks and cleanup
2020-03-23 17:40:01 -07:00
Liam Newman
b15e0d4c45
Cleanup and tweaks
2020-03-23 17:40:01 -07:00
Liam Newman
b8180314d8
Change to Preview for new builder pattern
2020-03-23 17:40:01 -07:00
Liam Newman
09ec89bc2e
Remove Repository member from GHLabel
...
It turns out GHLabel instances do not need a reference to their repo, just to root.
2020-03-23 17:40:01 -07:00
Liam Newman
863ad0f486
Clarify behavior
2020-03-23 17:40:01 -07:00
Liam Newman
9f1d7323c7
Reverted getter changes to highlight the more important set/update changes
2020-03-23 17:40:01 -07:00
Liam Newman
64a82f4785
Clean up proposed API changes
2020-03-23 17:40:01 -07:00
Liam Newman
f37e4bd76e
Private fields
2020-03-23 17:40:01 -07:00
Liam Newman
98ef2cc640
Update-in-place and safer single or batch calculation
2020-03-23 17:40:01 -07:00
Liam Newman
134222fd69
Minor cleanups
2020-03-23 17:40:01 -07:00
Liam Newman
0cb2371517
Third alternative proposal
...
This removes the from the fields. Functionally the behavior is unchanged but
it is no longer guaranteed at compile time. This simplifies streamlines the code slightly,
but at the cost of only being able to assert immutability rather than know it.
However, as we move to using this structure through more of the library, this is may be a better choice.
There are so many places where the GitHub API itself returns partial records or updates them dynamically.
Trying to claim immutability where it doesn't exist is not great either.
2020-03-23 17:40:01 -07:00
Liam Newman
b7de4359fd
Alternative proposal
...
The guts of this version are a bit ugly but they result reasonable API code without a ton of extra
code needed.
2020-03-23 17:40:01 -07:00
Liam Newman
2607d6a107
Make GHLabel example of proposed API design
2020-03-23 17:40:01 -07:00
Liam Newman
a1a73568ae
Merge branch 'master' into addHtmlURL
2020-03-20 11:41:23 -07:00
Andrej Vano
452b56c47b
[GHEvent] Add new enum for registry_package event
2020-03-20 11:47:04 +01:00
Andrej Vano
5cb6bfa633
[CheckRuns] Add method for listing checkruns for given ref
2020-03-20 11:47:04 +01:00
Liam Newman
10827c7e21
Merge branch 'master' into addHtmlURL
2020-03-18 08:43:43 -07:00
Karol Lassak
1a4238156c
Fix javadocs
2020-03-17 11:34:31 +01:00
Karol Lassak
2aebe97f9f
Add/restore test for getTeam
2020-03-17 11:18:33 +01:00
Karol Lassak
6cbb1a0bee
Fix tests partially
2020-03-17 10:13:43 +01:00
Karol Lassak
9213f80435
Add comment to deprecation
...
Co-Authored-By: Liam Newman <bitwiseman@gmail.com >
2020-03-17 09:07:37 +01:00
Sladyn
4bb1d78939
Merge branch 'master' into addHtmlURL
2020-03-15 18:41:22 +05:30
Sladyn Nunes
53c37ef413
Retrieve html_url from PRReviewComment
2020-03-15 18:30:29 +05:30
Karol Lassak
2e25f37433
Format code
2020-03-09 16:39:22 +01:00
Karol Lassak
fbf6c73226
Make getTeambySlug fast enought
2020-03-09 16:04:01 +01:00
Liam Newman
a42305dd59
Revert "Removed extraneous author javadocs"
...
This reverts commit 888abc9e2a
2020-03-04 11:32:12 -08:00
XiongKezhi
768f60709f
Add Output and more tests
2020-03-03 23:45:01 +08:00
Kezhi Xiong
ce7cfc0648
Merge branch 'master' into complete-checks-api
2020-03-03 12:57:42 +08:00
