Commit Graph

17 Commits

Author SHA1 Message Date
Liam Newman
35c8cfa01d Push method code coverage bar to 50 percent
This change adds or update a swath of tests to push method code coverage numbers up.
Yes, method coverage is not super meaningful, but it is one metric that we can use to
ensure at least minimal coverage of this library.

Almost no product changes in here.
2021-01-25 12:08:57 -08:00
Tobias Nett
5d796d1f79 revert unwanted assertion change 2020-11-18 21:24:58 +01:00
Tobias Nett
68a82be6c4 rename 'getCachedAssets' to 'assets' (bare property name as getter)) 2020-11-18 19:28:27 +01:00
Tobias Nett
2676ef2b73 rename 'fetchAssets' to 'listAssets' and return PagedIterable 2020-11-18 19:27:31 +01:00
Tobias Nett
98b067937a Make changes backwards compatible
Add '@Deprecation' and '@Preview' annotations to make the changes
backwards compatible and prepare for a transition to the cached behavior
as default.
This explicitly leaves the variant for re-fetching assets under a
different name.
2020-11-17 17:16:44 +01:00
Tobias Nett
d881bf6504 Bring back previous semantic of getAssets() as fetchAssets()
I don't know a better name for this, and I also don't know whether this
should be an option or not.
The life cycle tests use the feature that retrieving the assets from a
release actually does a roundtrip to Github and sends another request.
This indicates that re-purposing `getAssets()` to be the cached access
might cause problems on consumers that potentially rely on this
assumption, too.
2020-11-11 19:49:58 +01:00
Liam Newman
9675126298 Turn off some tests for windows 2020-01-29 13:30:01 -08:00
Liam Newman
b3d79622e6 Fix lifecycle test to not fail during release 2019-11-26 17:46:49 -08:00
Liam Newman
ff766a46c8 Enable uploads testing and LifecycleTest
Fixed asset upload url to not hard coded
2019-11-21 17:07:38 -08:00
Liam Newman
cbd06eef96 Code formatting 2019-11-15 15:51:07 -08:00
Liam Newman
9d8460bb81 Enable automatic code formatter with CI validation
This may be controversial but it we're doing it. Having code formatting needs to be consistent
and a non-issue during code review. I'm willing modify the configuration if people see a strong
need, but formatting needs to be present and enforced.
2019-11-13 13:28:23 -08:00
Liam Newman
b35509150a Enable part of AppTest in CI 2019-10-02 15:27:22 -07:00
Kohsuke Kawaguchi
f8fe1dda6d Presence check needs to run on the same repo 2014-05-10 15:46:14 -07:00
Kohsuke Kawaguchi
8c8ba47ef9 Fork into an org to simplify access control 2014-05-10 15:38:13 -07:00
Kohsuke Kawaguchi
1249199b22 push fails with HTTPS 2014-05-10 15:34:57 -07:00
Kohsuke Kawaguchi
f39a47f354 This test seems to fail randomly 2014-05-10 15:32:58 -07:00
Kohsuke Kawaguchi
9d91ebc47a Not sure why tests weren't in the right package 2014-05-10 13:53:13 -07:00