jlengrand/github-api
1
0
Fork 0
mirror of https://github.com/jlengrand/github-api.git synced 2026-04-05 08:21:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

Capitalize and Move GHVerification.Reason enum

Browse Source
This commit is contained in:
Liam Newman
2020-03-26 09:45:20 -07:00
parent a78d2f28d7
commit f554ddc372
111 changed files with 70 additions and 73 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/test/java/org/kohsuke/github/AppTest.java
View File

@@ -597,7 +597,7 @@ public class AppTest extends AbstractGitHubWireMockTest {
assertEquals(commit.getCommitShortInfo().getAuthor().getName(), "Kohsuke Kawaguchi");
assertEquals(commit.getCommitShortInfo().getMessage(), "doc");
assertFalse(commit.getCommitShortInfo().getVerification().getVerified());
assertEquals(commit.getCommitShortInfo().getVerification().getReason(), GHReason.unsigned);
assertEquals(commit.getCommitShortInfo().getVerification().getReason(), GHVerification.Reason.UNSIGNED);
}
@Ignore("Needs mocking check")

17
src/test/java/org/kohsuke/github/CommitTest.java
View File

@@ -24,4 +24,21 @@ public class CommitTest extends AbstractGitHubWireMockTest {
assertEquals(expected.getFiles().size(), commit.getFiles().size());
}
}
@Test // issue 737
public void commitSignatureVerification() throws Exception {
GHRepository repo = gitHub.getRepository("stapler/stapler");
PagedIterable<GHCommit> commits = repo.queryCommits().path("pom.xml").list();
for (GHCommit commit : Iterables.limit(commits, 10)) {
GHCommit expected = repo.getCommit(commit.getSHA1());
assertEquals(expected.getCommitShortInfo().getVerification().getVerified(),
commit.getCommitShortInfo().getVerification().getVerified());
assertEquals(expected.getCommitShortInfo().getVerification().getReason(),
commit.getCommitShortInfo().getVerification().getReason());
assertEquals(expected.getCommitShortInfo().getVerification().getSignature(),
commit.getCommitShortInfo().getVerification().getSignature());
assertEquals(expected.getCommitShortInfo().getVerification().getPayload(),
commit.getCommitShortInfo().getVerification().getPayload());
}
}
}

2
src/test/java/org/kohsuke/github/GHTagTest.java
View File

@@ -48,7 +48,7 @@ public class GHTagTest extends AbstractGitHubWireMockTest {
assertEquals(tagMessage, tag.getMessage());
assertEquals(commitSha, tag.getObject().getSha());
assertFalse(tag.getVerification().getVerified());
assertEquals(tag.getVerification().getReason(), GHReason.unsigned);
assertEquals(tag.getVerification().getReason(), GHVerification.Reason.UNSIGNED);
// Make a reference to the newly created tag.
GHRef ref = repo.createRef("refs/tags/" + tagName, tag.getSha());

31
src/test/java/org/kohsuke/github/GHReasonTest.java → src/test/java/org/kohsuke/github/GHVerificationReasonTest.java
View File

@@ -5,7 +5,7 @@ import org.junit.Test;
/**
* @author Sourabh Sarvotham Parkala
*/
public class GHReasonTest extends AbstractGitHubWireMockTest {
public class GHVerificationReasonTest extends AbstractGitHubWireMockTest {
// Issue 737
@Test
public void testExpiredKeyVerification() throws Exception {
@@ -13,7 +13,7 @@ public class GHReasonTest extends AbstractGitHubWireMockTest {
GHCommit commit = r.getCommit("86a2e245aa6d71d54923655066049d9e21a15f01");
assertEquals(commit.getCommitShortInfo().getAuthor().getName(), "Sourabh Parkala");
assertFalse(commit.getCommitShortInfo().getVerification().getVerified());
assertEquals(commit.getCommitShortInfo().getVerification().getReason(), GHReason.expired_key);
assertEquals(commit.getCommitShortInfo().getVerification().getReason(), GHVerification.Reason.EXPIRED_KEY);
}
@Test
@@ -22,7 +22,7 @@ public class GHReasonTest extends AbstractGitHubWireMockTest {
GHCommit commit = r.getCommit("86a2e245aa6d71d54923655066049d9e21a15f02");
assertEquals(commit.getCommitShortInfo().getAuthor().getName(), "Sourabh Parkala");
assertFalse(commit.getCommitShortInfo().getVerification().getVerified());
assertEquals(commit.getCommitShortInfo().getVerification().getReason(), GHReason.not_signing_key);
assertEquals(commit.getCommitShortInfo().getVerification().getReason(), GHVerification.Reason.NOT_SIGNING_KEY);
}
@Test
@@ -31,7 +31,7 @@ public class GHReasonTest extends AbstractGitHubWireMockTest {
GHCommit commit = r.getCommit("86a2e245aa6d71d54923655066049d9e21a15f03");
assertEquals(commit.getCommitShortInfo().getAuthor().getName(), "Sourabh Parkala");
assertFalse(commit.getCommitShortInfo().getVerification().getVerified());
assertEquals(commit.getCommitShortInfo().getVerification().getReason(), GHReason.gpgverify_error);
assertEquals(commit.getCommitShortInfo().getVerification().getReason(), GHVerification.Reason.GPGVERIFY_ERROR);
}
@Test
@@ -40,7 +40,8 @@ public class GHReasonTest extends AbstractGitHubWireMockTest {
GHCommit commit = r.getCommit("86a2e245aa6d71d54923655066049d9e21a15f04");
assertEquals(commit.getCommitShortInfo().getAuthor().getName(), "Sourabh Parkala");
assertFalse(commit.getCommitShortInfo().getVerification().getVerified());
assertEquals(commit.getCommitShortInfo().getVerification().getReason(), GHReason.gpgverify_unavailable);
assertEquals(commit.getCommitShortInfo().getVerification().getReason(),
GHVerification.Reason.GPGVERIFY_UNAVAILABLE);
}
@Test
@@ -49,7 +50,7 @@ public class GHReasonTest extends AbstractGitHubWireMockTest {
GHCommit commit = r.getCommit("86a2e245aa6d71d54923655066049d9e21a15f05");
assertEquals(commit.getCommitShortInfo().getAuthor().getName(), "Sourabh Parkala");
assertFalse(commit.getCommitShortInfo().getVerification().getVerified());
assertEquals(commit.getCommitShortInfo().getVerification().getReason(), GHReason.unsigned);
assertEquals(commit.getCommitShortInfo().getVerification().getReason(), GHVerification.Reason.UNSIGNED);
}
@Test
@@ -58,7 +59,8 @@ public class GHReasonTest extends AbstractGitHubWireMockTest {
GHCommit commit = r.getCommit("86a2e245aa6d71d54923655066049d9e21a15f06");
assertEquals(commit.getCommitShortInfo().getAuthor().getName(), "Sourabh Parkala");
assertFalse(commit.getCommitShortInfo().getVerification().getVerified());
assertEquals(commit.getCommitShortInfo().getVerification().getReason(), GHReason.unknown_signature_type);
assertEquals(commit.getCommitShortInfo().getVerification().getReason(),
GHVerification.Reason.UNKNOWN_SIGNATURE_TYPE);
}
@Test
@@ -67,7 +69,7 @@ public class GHReasonTest extends AbstractGitHubWireMockTest {
GHCommit commit = r.getCommit("86a2e245aa6d71d54923655066049d9e21a15f07");
assertEquals(commit.getCommitShortInfo().getAuthor().getName(), "Sourabh Parkala");
assertFalse(commit.getCommitShortInfo().getVerification().getVerified());
assertEquals(commit.getCommitShortInfo().getVerification().getReason(), GHReason.no_user);
assertEquals(commit.getCommitShortInfo().getVerification().getReason(), GHVerification.Reason.NO_USER);
}
@Test
@@ -76,7 +78,7 @@ public class GHReasonTest extends AbstractGitHubWireMockTest {
GHCommit commit = r.getCommit("86a2e245aa6d71d54923655066049d9e21a15f08");
assertEquals(commit.getCommitShortInfo().getAuthor().getName(), "Sourabh Parkala");
assertFalse(commit.getCommitShortInfo().getVerification().getVerified());
assertEquals(commit.getCommitShortInfo().getVerification().getReason(), GHReason.unverified_email);
assertEquals(commit.getCommitShortInfo().getVerification().getReason(), GHVerification.Reason.UNVERIFIED_EMAIL);
}
@Test
@@ -85,7 +87,7 @@ public class GHReasonTest extends AbstractGitHubWireMockTest {
GHCommit commit = r.getCommit("86a2e245aa6d71d54923655066049d9e21a15f09");
assertEquals(commit.getCommitShortInfo().getAuthor().getName(), "Sourabh Parkala");
assertFalse(commit.getCommitShortInfo().getVerification().getVerified());
assertEquals(commit.getCommitShortInfo().getVerification().getReason(), GHReason.bad_email);
assertEquals(commit.getCommitShortInfo().getVerification().getReason(), GHVerification.Reason.BAD_EMAIL);
}
@Test
@@ -94,7 +96,7 @@ public class GHReasonTest extends AbstractGitHubWireMockTest {
GHCommit commit = r.getCommit("86a2e245aa6d71d54923655066049d9e21a15f10");
assertEquals(commit.getCommitShortInfo().getAuthor().getName(), "Sourabh Parkala");
assertFalse(commit.getCommitShortInfo().getVerification().getVerified());
assertEquals(commit.getCommitShortInfo().getVerification().getReason(), GHReason.unknown_key);
assertEquals(commit.getCommitShortInfo().getVerification().getReason(), GHVerification.Reason.UNKNOWN_KEY);
}
@Test
@@ -103,7 +105,8 @@ public class GHReasonTest extends AbstractGitHubWireMockTest {
GHCommit commit = r.getCommit("86a2e245aa6d71d54923655066049d9e21a15f11");
assertEquals(commit.getCommitShortInfo().getAuthor().getName(), "Sourabh Parkala");
assertFalse(commit.getCommitShortInfo().getVerification().getVerified());
assertEquals(commit.getCommitShortInfo().getVerification().getReason(), GHReason.malformed_signature);
assertEquals(commit.getCommitShortInfo().getVerification().getReason(),
GHVerification.Reason.MALFORMED_SIGNATURE);
}
@Test
@@ -112,7 +115,7 @@ public class GHReasonTest extends AbstractGitHubWireMockTest {
GHCommit commit = r.getCommit("86a2e245aa6d71d54923655066049d9e21a15f12");
assertEquals(commit.getCommitShortInfo().getAuthor().getName(), "Sourabh Parkala");
assertFalse(commit.getCommitShortInfo().getVerification().getVerified());
assertEquals(commit.getCommitShortInfo().getVerification().getReason(), GHReason.invalid);
assertEquals(commit.getCommitShortInfo().getVerification().getReason(), GHVerification.Reason.INVALID);
}
@Test
@@ -121,7 +124,7 @@ public class GHReasonTest extends AbstractGitHubWireMockTest {
GHCommit commit = r.getCommit("86a2e245aa6d71d54923655066049d9e21a15f13");
assertEquals(commit.getCommitShortInfo().getAuthor().getName(), "Sourabh Parkala");
assertTrue(commit.getCommitShortInfo().getVerification().getVerified());
assertEquals(commit.getCommitShortInfo().getVerification().getReason(), GHReason.valid);
assertEquals(commit.getCommitShortInfo().getVerification().getReason(), GHVerification.Reason.VALID);
assertNotNull(commit.getCommitShortInfo().getVerification().getPayload());
assertNotNull(commit.getCommitShortInfo().getVerification().getSignature());
}

27
src/test/java/org/kohsuke/github/SignatureVerificationTest.java
View File

@@ -1,27 +0,0 @@
package org.kohsuke.github;
import com.google.common.collect.Iterables;
import org.junit.Test;
/**
* @author Sourabh Sarvotham Parkala
*/
public class SignatureVerificationTest extends AbstractGitHubWireMockTest {
@Test // issue 737
public void commitSignatureVerification() throws Exception {
GHRepository repo = gitHub.getRepository("stapler/stapler");
PagedIterable<GHCommit> commits = repo.queryCommits().path("pom.xml").list();
for (GHCommit commit : Iterables.limit(commits, 10)) {
GHCommit expected = repo.getCommit(commit.getSHA1());
assertEquals(expected.getCommitShortInfo().getVerification().getVerified(),
commit.getCommitShortInfo().getVerification().getVerified());
assertEquals(expected.getCommitShortInfo().getVerification().getReason(),
commit.getCommitShortInfo().getVerification().getReason());
assertEquals(expected.getCommitShortInfo().getVerification().getSignature(),
commit.getCommitShortInfo().getVerification().getSignature());
assertEquals(expected.getCommitShortInfo().getVerification().getPayload(),
commit.getCommitShortInfo().getVerification().getPayload());
}
}
}