jlengrand/github-api
1
0
Fork 0
mirror of https://github.com/jlengrand/github-api.git synced 2026-03-24 00:11:23 +00:00
Code Issues Packages Projects Releases Wiki Activity

support create PR review in single API call & remove @Preview

Browse Source
This commit is contained in:
Sébastien Lesaint
2017-12-04 11:11:58 +01:00
parent 6961c467a6
commit e74346fed6
5 changed files with 217 additions and 132 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/test/java/org/kohsuke/github/PullRequestTest.java
View File

@@ -33,7 +33,7 @@ public class PullRequestTest extends AbstractGitHubApiTestBase {
public void testPullRequestReviews() throws Exception {
String name = rnd.next();
GHPullRequest p = getRepository().createPullRequest(name, "stable", "master", "## test");
GHPullRequestReview draftReview = p.createReview("Some draft review", null,
GHPullRequestReviewDraft draftReview = p.newDraftReview(null, "Some draft review",
GHPullRequestReviewComment.draft("Some niggle", "changelog.html", 1)
);
assertThat(draftReview.getState(), is(GHPullRequestReviewState.PENDING));
@@ -45,15 +45,15 @@ public class PullRequestTest extends AbstractGitHubApiTestBase {
assertThat(review.getState(), is(GHPullRequestReviewState.PENDING));
assertThat(review.getBody(), is("Some draft review"));
assertThat(review.getCommitId(), notNullValue());
review.submit("Some review comment", GHPullRequestReviewEvent.COMMENT);
draftReview.submit("Some review comment", GHPullRequestReviewEvent.COMMENT);
List<GHPullRequestReviewComment> comments = review.listReviewComments().asList();
assertEquals(1, comments.size());
GHPullRequestReviewComment comment = comments.get(0);
assertEquals("Some niggle", comment.getBody());
review = p.createReview("Some new review", null,
draftReview = p.newDraftReview(null, "Some new review",
GHPullRequestReviewComment.draft("Some niggle", "changelog.html", 1)
);
review.delete();
draftReview.delete();
}
@Test